[Qemu-devel] [PATCH v2 0/5] RBD: blockdev-add

Jeff Cody posted 5 patches 7 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1488220970.git.jcody@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
block/rbd.c          | 464 ++++++++++++++++++++++++++++++---------------------
qapi/block-core.json |  42 ++++-
2 files changed, 316 insertions(+), 190 deletions(-)
[Qemu-devel] [PATCH v2 0/5] RBD: blockdev-add
Posted by Jeff Cody 7 years, 2 months ago
This series adds blockdev-add for rbd.

Changes from v1:

Overall:

* QAPI interface does not allow arbitrary key/value pairs
  in v2 (Thanks Daniel)

* QAPI interface adds 'mon_host' and 'auth_supported' options (Thanks Daniel)

* Use 'user' instead of 'rbd-id' (Thanks Daniel)


By patch:

Patch 1:
 * Fixed some indentation in patch 1 (Thanks Markus)

Patch 2:
 * 'rbd-id' becomes 'user', and the commit message is fixed. (Thanks Daniel)

Patch 3:
 * Ripple-through from changes in patch 2
 * Removed the string unescape from qemu_rbd_set_keypairs(), because the
   strings have already been unescaped by the time they hit this function.

Patch 4:
 * 'rbd-id' becomes 'user'
 * drop the 'keyvalue-pairs' from the QAPI  (both, thanks Daniel)

Patch 5:
 * new patch
 * Adds the 'server' (mon_host) and 'auth_supported' options to the
   QAPI (Thanks Daniel)


Jeff Cody (5):
  block/rbd: don't copy strings in qemu_rbd_next_tok()
  block/rbd: add all the currently supported runtime_opts
  block/rbd: parse all options via bdrv_parse_filename
  block/rbd: add blockdev-add support
  block/rbd: add support for 'mon_host', 'auth_supported' via QAPI

 block/rbd.c          | 464 ++++++++++++++++++++++++++++++---------------------
 qapi/block-core.json |  42 ++++-
 2 files changed, 316 insertions(+), 190 deletions(-)

-- 
2.9.3v