[v3] bsd-user: Fix some code style problems

[PATCH V3 0/4] bsd-user: Fix some code style problems

Posted by shiliyang 3 years, 3 months ago

This patch series fixes error style problems found by checkpatch.pl.

V2->V3:
Make the patch into a series.

V1->V2:
Add cover letter message.
Fix some style error in patch file before.

Liyang Shi (4):
  bsd-user: "foo * bar" should be "foo *bar"
  bsd-user: suspect code indent for conditional statements
  bsd-user: space required after semicolon
  bsd-user: do not use C99 // comments

 bsd-user/bsdload.c |  6 +++---
 bsd-user/elfload.c | 38 +++++++++++++++++++-------------------
 bsd-user/qemu.h    | 14 +++++++-------
 bsd-user/syscall.c |  6 +++---
 4 files changed, 32 insertions(+), 32 deletions(-)

-- 
2.29.1.59.gf9b6481aed

Re: [PATCH V3 0/4] bsd-user: Fix some code style problems

Posted by Warner Losh 3 years, 3 months ago

While these changes look good, can you submit this against the bsd-user
repository? White space changes like this in mainline make rebasing harder
than needed.

https://github.com/qemu-bsd-user/qemu-bsd-user branch
bsd-user-rebase-3.1and we'll make sure they get via our coming pull
requests..

Warner

On Wed, Jan 13, 2021 at 2:31 AM shiliyang <shiliyang@huawei.com> wrote:

> This patch series fixes error style problems found by checkpatch.pl.
>
> V2->V3:
> Make the patch into a series.
>
> V1->V2:
> Add cover letter message.
> Fix some style error in patch file before.
>
> Liyang Shi (4):
>   bsd-user: "foo * bar" should be "foo *bar"
>   bsd-user: suspect code indent for conditional statements
>   bsd-user: space required after semicolon
>   bsd-user: do not use C99 // comments
>
>  bsd-user/bsdload.c |  6 +++---
>  bsd-user/elfload.c | 38 +++++++++++++++++++-------------------
>  bsd-user/qemu.h    | 14 +++++++-------
>  bsd-user/syscall.c |  6 +++---
>  4 files changed, 32 insertions(+), 32 deletions(-)
>
> --
> 2.29.1.59.gf9b6481aed
>
>
>

Re: [PATCH V3 0/4] bsd-user: Fix some code style problems

Posted by shiliyang 3 years, 3 months ago

On 2021/1/14 6:03, Warner Losh wrote:
> While these changes look good, can you submit this against the bsd-user repository? White space changes like this in mainline make rebasing harder than needed.
> 
> https://github.com/qemu-bsd-user/qemu-bsd-user <https://github.com/qemu-bsd-user/qemu-bsd-user> branch bsd-user-rebase-3.1and we'll make sure they get via our coming pull requests..
> 
> Warner
> 
> On Wed, Jan 13, 2021 at 2:31 AM shiliyang <shiliyang@huawei.com <mailto:shiliyang@huawei.com>> wrote:
> 
>     This patch series fixes error style problems found by checkpatch.pl <http://checkpatch.pl>.
> 
>     V2->V3:
>     Make the patch into a series.
> 
>     V1->V2:
>     Add cover letter message.
>     Fix some style error in patch file before.
> 
>     Liyang Shi (4):
>       bsd-user: "foo * bar" should be "foo *bar"
>       bsd-user: suspect code indent for conditional statements
>       bsd-user: space required after semicolon
>       bsd-user: do not use C99 // comments
> 
>      bsd-user/bsdload.c |  6 +++---
>      bsd-user/elfload.c | 38 +++++++++++++++++++-------------------
>      bsd-user/qemu.h    | 14 +++++++-------
>      bsd-user/syscall.c |  6 +++---
>      4 files changed, 32 insertions(+), 32 deletions(-)
> 
>     -- 
>     2.29.1.59.gf9b6481aed
> 
> 

OK, I get it, thanks!

Best regards.