iotest 051 failure on s390

Posted by Christian Borntraeger 4 years, 10 months ago

On s390 with latest master I do get

051   fail       [17:30:00] [17:30:05]   5.4s                 output mismatch (see 051.out.bad)
--- /home/cborntra/REPOS/qemu/tests/qemu-iotests/051.out
+++ 051.out.bad
@@ -61,13 +61,13 @@
  (qemu) quit

  Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo
-QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node name
+QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node-name: '123foo'

  Testing: -drive file=TEST_DIR/t.qcow2,node-name=_foo
-QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node name
+QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node-name: '_foo'

  Testing: -drive file=TEST_DIR/t.qcow2,node-name=foo#12
-QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node name
+QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node-name: 'foo#12'

Re: iotest 051 failure on s390

Posted by John Snow 4 years, 10 months ago

On 3/18/21 12:32 PM, Christian Borntraeger wrote:
> On s390 with latest master I do get
> 
> 051   fail       [17:30:00] [17:30:05]   5.4s                 output 
> mismatch (see 051.out.bad)
> --- /home/cborntra/REPOS/qemu/tests/qemu-iotests/051.out
> +++ 051.out.bad
> @@ -61,13 +61,13 @@
>   (qemu) quit
> 
>   Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo
> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node 
> name
> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid 
> node-name: '123foo'
> 
>   Testing: -drive file=TEST_DIR/t.qcow2,node-name=_foo
> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node name
> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid 
> node-name: '_foo'
> 
>   Testing: -drive file=TEST_DIR/t.qcow2,node-name=foo#12
> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node 
> name
> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid 
> node-name: 'foo#12'
> 

Looks like we forgot to update 051.out in addition to 051.pc.out in 
785ec4b1. Easy to fix.

--js