[PATCH] qapi: Set boolean value correctly in examples

Guoyi Tu posted 1 patch 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/a21a2b61-2653-a2c9-4478-715e5fb19120@chinatelecom.cn
Maintainers: Eric Blake <eblake@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>
qapi/trace.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qapi: Set boolean value correctly in examples
Posted by Guoyi Tu 2 years, 7 months ago

Signed-off-by: Guoyi Tu <tugy@chinatelecom.cn>
---
  qapi/trace.json | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/trace.json b/qapi/trace.json
index 47c68f04da..eedfded512 100644
--- a/qapi/trace.json
+++ b/qapi/trace.json
@@ -99,7 +99,7 @@
  # Example:
  #
  # -> { "execute": "trace-event-set-state",
-#      "arguments": { "name": "qemu_memalign", "enable": "true" } }
+#      "arguments": { "name": "qemu_memalign", "enable": true } }
  # <- { "return": {} }
  #
  ##
-- 
2.25.1

-- 
Best Regards,
Guoyi Tu

Re: [PATCH] qapi: Set boolean value correctly in examples
Posted by Eric Blake 2 years, 7 months ago
On Fri, Aug 27, 2021 at 05:06:27PM +0800, Guoyi Tu wrote:
> 
> Signed-off-by: Guoyi Tu <tugy@chinatelecom.cn>
> ---
>  qapi/trace.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/trace.json b/qapi/trace.json
> index 47c68f04da..eedfded512 100644
> --- a/qapi/trace.json
> +++ b/qapi/trace.json
> @@ -99,7 +99,7 @@
>  # Example:
>  #
>  # -> { "execute": "trace-event-set-state",
> -#      "arguments": { "name": "qemu_memalign", "enable": "true" } }
> +#      "arguments": { "name": "qemu_memalign", "enable": true } }
>  # <- { "return": {} }
>  #
>  ##
> -- 
> 2.25.1
> 
> -- 
> Best Regards,
> Guoyi Tu
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


Re: [PATCH] qapi: Set boolean value correctly in examples
Posted by Markus Armbruster 2 years, 7 months ago
Queued, thanks!