thunk: improve readability of allocation loop

[Qemu-devel] [PATCH] thunk: improve readability of allocation loop

Aarushi Mehta posted 1 patch 6 years, 8 months ago

Download mbox

Test asan failed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/a09acf9e093c09a70896bb9886370cf7f049f941.camel@gmail.com

Maintainers: Riku Voipio <riku.voipio@iki.fi>

thunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] thunk: improve readability of allocation loop

Posted by Aarushi Mehta 6 years, 8 months ago

Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
---
 thunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thunk.c b/thunk.c
index 17f3d320bb..7f31cffe09 100644
--- a/thunk.c
+++ b/thunk.c
@@ -86,7 +86,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
 #endif
     /* now we can alloc the data */
 
-    for(i = 0;i < 2; i++) {
+    for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {
         offset = 0;
         max_align = 1;
         se->field_offsets[i] = g_new(int, nb_fields);
-- 
2.17.1

Re: [Qemu-devel] [PATCH] thunk: improve readability of allocation loop

Posted by Stefan Hajnoczi 6 years, 8 months ago

On Fri, Mar 8, 2019 at 7:43 PM Aarushi Mehta <mehta.aaru20@gmail.com> wrote:
>
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
>  thunk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] thunk: improve readability of allocation loop

Posted by Laurent Vivier 6 years, 8 months ago

On 08/03/2019 20:43, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
>  thunk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/thunk.c b/thunk.c
> index 17f3d320bb..7f31cffe09 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -86,7 +86,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
>  #endif
>      /* now we can alloc the data */
>  
> -    for(i = 0;i < 2; i++) {
> +    for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {
>          offset = 0;
>          max_align = 1;
>          se->field_offsets[i] = g_new(int, nb_fields);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent