[PATCH] meson.build: Remove ncurses workaround for OpenBSD

Brad Smith posted 1 patch 1 month, 1 week ago
meson.build | 2 +-
ui/curses.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] meson.build: Remove ncurses workaround for OpenBSD
Posted by Brad Smith 1 month, 1 week ago
meson.build: Remove ncurses workaround for OpenBSD

OpenBSD 7.5 has upgraded to ncurses 6.4.

Signed-off-by: Brad Smith <brad@comstyle.com>
---
 meson.build | 2 +-
 ui/curses.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index 4ea1984fc5..22e7629d81 100644
--- a/meson.build
+++ b/meson.build
@@ -1374,7 +1374,7 @@ iconv = not_found
 curses = not_found
 if have_system and get_option('curses').allowed()
   curses_test = '''
-    #if defined(__APPLE__) || defined(__OpenBSD__)
+    #ifdef __APPLE__
     #define _XOPEN_SOURCE_EXTENDED 1
     #endif
     #include <locale.h>
diff --git a/ui/curses.c b/ui/curses.c
index ec61615f7c..4d0be9b37d 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -38,7 +38,7 @@
 #include "ui/input.h"
 #include "sysemu/sysemu.h"
 
-#if defined(__APPLE__) || defined(__OpenBSD__)
+#ifdef __APPLE__
 #define _XOPEN_SOURCE_EXTENDED 1
 #endif
 
-- 
2.46.1
Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD
Posted by Michael Tokarev 1 month ago
12.10.2024 06:38, Brad Smith wrote:
> meson.build: Remove ncurses workaround for OpenBSD
> 
> OpenBSD 7.5 has upgraded to ncurses 6.4.

Queued to qemu-trivial tree, thanks!

/mjt
Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD
Posted by Daniel P. Berrangé 1 month, 1 week ago
Cc'ing qemu-trivial

On Fri, Oct 11, 2024 at 11:38:55PM -0400, Brad Smith wrote:
> meson.build: Remove ncurses workaround for OpenBSD
> 
> OpenBSD 7.5 has upgraded to ncurses 6.4.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>  meson.build | 2 +-
>  ui/curses.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/meson.build b/meson.build
> index 4ea1984fc5..22e7629d81 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ iconv = not_found
>  curses = not_found
>  if have_system and get_option('curses').allowed()
>    curses_test = '''
> -    #if defined(__APPLE__) || defined(__OpenBSD__)
> +    #ifdef __APPLE__
>      #define _XOPEN_SOURCE_EXTENDED 1
>      #endif
>      #include <locale.h>
> diff --git a/ui/curses.c b/ui/curses.c
> index ec61615f7c..4d0be9b37d 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -38,7 +38,7 @@
>  #include "ui/input.h"
>  #include "sysemu/sysemu.h"
>  
> -#if defined(__APPLE__) || defined(__OpenBSD__)
> +#ifdef __APPLE__
>  #define _XOPEN_SOURCE_EXTENDED 1
>  #endif


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|