[v2] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

[PATCH v2] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

Posted by nia 2 years, 7 months ago

As discussed in issue 614, we're shipping GCC 7.4.0 as the
system compiler in NetBSD 9, the most recent stable branch,
and are still actively interested in QEMU on this platform.

The differences between GCC 7.5.0 and 7.4.0 are trivial.

Signed-off-by: Nia Alarie <nia@NetBSD.org>
---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 1043ccce4f..b0b1a1cc25 100755
--- a/configure
+++ b/configure
@@ -2094,8 +2094,8 @@ cat > $TMPC << EOF
 #  endif
 # endif
 #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
-# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 5)
-#  error You need at least GCC v7.5.0 to compile QEMU
+# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 4)
+#  error You need at least GCC v7.4.0 to compile QEMU
 # endif
 #else
 # error You either need GCC or Clang to compiler QEMU
@@ -2103,7 +2103,7 @@ cat > $TMPC << EOF
 int main (void) { return 0; }
 EOF
 if ! compile_prog "" "" ; then
-    error_exit "You need at least GCC v7.5 or Clang v6.0 (or XCode Clang v10.0)"
+    error_exit "You need at least GCC v7.4 or Clang v6.0 (or XCode Clang v10.0)"
 fi
 
 # Accumulate -Wfoo and -Wno-bar separately.
-- 
2.33.0

Re: [PATCH v2] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

Posted by Richard Henderson 2 years, 7 months ago

On 10/1/21 11:30 AM, nia wrote:
> As discussed in issue 614, we're shipping GCC 7.4.0 as the
> system compiler in NetBSD 9, the most recent stable branch,
> and are still actively interested in QEMU on this platform.
> 
> The differences between GCC 7.5.0 and 7.4.0 are trivial.
> 
> Signed-off-by: Nia Alarie<nia@NetBSD.org>
> ---
>   configure | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH v2] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

Posted by Paolo Bonzini 2 years, 7 months ago

On 01/10/21 18:15, Richard Henderson wrote:
> On 10/1/21 11:30 AM, nia wrote:
>> As discussed in issue 614, we're shipping GCC 7.4.0 as the
>> system compiler in NetBSD 9, the most recent stable branch,
>> and are still actively interested in QEMU on this platform.
>>
>> The differences between GCC 7.5.0 and 7.4.0 are trivial.
>>
>> Signed-off-by: Nia Alarie<nia@NetBSD.org>
>> ---
>>   configure | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> r~
> 

Queued, thanks.

Paolo