Hi Daniel

> Subject: Re: [PATCH v1 00/15] Support the ASPEED HACE crypto command
> 
> On Tue, Jul 14, 2026 at 07:29:01AM +0000, Jamin Lin wrote:
> >  qapi/crypto.json                              |   4 +-
> >  crypto/cipherpriv.h                           |   8 +
> >  include/crypto/cipher.h                       |  36 +
> >  include/hw/misc/aspeed_hace.h                 |   1 -
> >  tests/qtest/aspeed-hace-utils.h               |  20 +
> >  crypto/cipher.c                               |  32 +
> >  hw/misc/aspeed_hace.c                         | 454 +++++++++++-
> >  tests/qtest/aspeed-hace-utils.c               | 662
> ++++++++++++++++++
> >  tests/qtest/aspeed_hace-test.c                |  18 +
> >  tests/qtest/ast2700-hace-test.c               |   9 +
> >  tests/unit/test-crypto-cipher.c               | 240 +++++++
> >  crypto/cipher-gcrypt.c.inc                    | 101 +++
> 
> Both nettle and gnutls also support GCM mode, so can you impl those too.
> 
Thanks for the review and suggestion.
Will do.

Jamin
> >  .../aarch64/test_aspeed_ast2700a1.py          |   5 -
> >  .../aarch64/test_aspeed_ast2700a2.py          |   5 -
> >  .../aarch64/test_aspeed_ast2700fc.py          |   5 -
> >  15 files changed, 1563 insertions(+), 37 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> 
> With regards,
> Daniel
> --
> |: https://berrange.com       ~~
> https://hachyderm.io/@berrange :|
> |: https://libvirt.org          ~~          https://entangle-photo.org :|
> |: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|