RE: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c

Jamin Lin posted 3 patches 2 days, 3 hours ago
Only 0 patches received!
There is a newer version of this series
RE: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
Posted by Jamin Lin 2 days, 3 hours ago
Hi Michael, Cédric

Do I need to resend this PR (v3)?

I am currently waiting for this patch to be merged so that I can proceed with submitting the corresponding update to the ASPEED SDK v11.00.
Thanks,
Jamin

> -----Original Message-----
> From: Jamin Lin
> Sent: Monday, January 19, 2026 9:35 AM
> To: Michael Tokarev <mjt@tls.msk.ru>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Cédric Le Goater <clg@kaod.org>
> Subject: RE: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
> 
> + Cedric
> 
> Hi Michael,
> 
> > Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
> >
> > On 1/16/26 10:30, Jamin Lin wrote:
> > > ----------------------------------------------------------------
> > > vbootrom update pull request
> > >
> > > ----------------------------------------------------------------
> >
> > Hi Jamin!
> >
> > I've become curious.
> >
> > You sent a pull request (and second one), listing multiple people in To: and
> Cc:
> > fields.  Usually, this is done when you're sending a patch series for review.
> > For a pull request, usually it's enough to list qemu-devel@nongnu.org in the
> To:
> > field, and maybe the current person who's managing the master branch,
> > who's merging the pull requests.  Listing multiple people for the pull
> > request makes not much sense, since a pullreq is something which is
> > (almost) cast in stone already, it is being merged as-is, there's no
> > way to comment on it or to modify it - since the whole pull request is being
> applied to the master branch as-is.
> >
> Got it, thanks for the clarification.
> This is my first time sending a pull request, so I’m still learning the QEMU PR
> workflow.
> Thank you for pointing this out.
> 
> I created this pull request because it updates the pre-built VBOOTROM image.
> The patch size is quite large, and both my maintainer and reviewer (Cedric)
> suggested that I submit it as a pull request instead of a regular patch series.
> Since I understood that the pull request still needs to be reviewed, I used git
> send-email together with get_maintainer.pl to include the relevant maintainers
> and reviewers.
> 
> git send-email -cc jamin_lin@aspeedtech.com -cc troy_lee@aspeedtech.com
> -cc kane_chen@aspeedtech.com --to-cmd
> "./scripts/get_maintainer.pl ../v3-patch/*.patch"
> 
> > And another question is why did you add my address to the list of recipients?
> > Is it for me to review the changes, or to pick them up through
> > qemu-trivial tree (in which case it shouldn't be pull request), or to pick it up
> for qemu-stable?
> >
> 
> 
> I added your address because it was automatically included by
> get_maintainer.pl.
> This pull request is intended for the master branch only.
> 
> Thanks-Jamin
> 
> > Thanks,
> >
> > /mjt

Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
Posted by Cédric Le Goater 2 days, 2 hours ago
Hi,

On 1/23/26 05:58, Jamin Lin wrote:
> Hi Michael, Cédric
> 
> Do I need to resend this PR (v3)?

I don't think so.
  
> I am currently waiting for this patch to be merged so that I can proceed 
> with submitting the corresponding update to the ASPEED SDK v11.00.

I plan to send the vbootrom update in the next aspeed PR but I can't tell
you when.

Thanks,

C.


RE: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
Posted by Jamin Lin 2 days, 2 hours ago
Hi Cédric

> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Friday, January 23, 2026 2:06 PM
> To: Jamin Lin <jamin_lin@aspeedtech.com>; Michael Tokarev
> <mjt@tls.msk.ru>; open list:All patches CC here <qemu-devel@nongnu.org>
> Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c
> 
> Hi,
> 
> On 1/23/26 05:58, Jamin Lin wrote:
> > Hi Michael, Cédric
> >
> > Do I need to resend this PR (v3)?
> 
> I don't think so.
> 
> > I am currently waiting for this patch to be merged so that I can
> > proceed with submitting the corresponding update to the ASPEED SDK
> v11.00.
> 
> I plan to send the vbootrom update in the next aspeed PR but I can't tell you
> when.
> 

No problem.
I really appreciate your help and kind support.

Thanks-Jamin

> Thanks,
> 
> C.