1. Patchew
  2. QEMU
  3. View series

[PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform

Sunil Muthuswamy posted 1 patch 4 years, 1 month ago
Test docker-quick@centos7 passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/SN4PR2101MB0880E245954826FD91C9D67DC0110@SN4PR2101MB0880.namprd21.prod.outlook.com
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Sunil Muthuswamy 4 years, 1 month ago 
Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1740a4fddc..9b3ba4e1b5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -404,6 +404,14 @@ S: Supported
 F: target/i386/kvm.c
 F: scripts/kvm/vmxcap
 
+WHPX CPUs
+M: Sunil Muthuswamy <sunilmut@microsoft.com>
+S: Supported
+F: target/i386/whpx-all.c
+F: target/i386/whp-dispatch.h
+F: accel/stubs/whpx-stub.c
+F: include/sysemu/whpx.h
+
 Guest CPU Cores (Xen)
 ---------------------
 X86 Xen CPUs
-- 
2.17.1
RE: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Justin Terry (SF) 4 years, 1 month ago 
Looks good to me! Thanks Sunil.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>

> -----Original Message-----
> From: Sunil Muthuswamy <sunilmut@microsoft.com>
> Sent: Tuesday, February 18, 2020 12:39 PM
> To: Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>
> Cc: Stefan Weil <sw@weilnetz.de>; qemu-devel@nongnu.org; Justin Terry
> (SF) <juterry@microsoft.com>
> Subject: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor
> Platform
> 
> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1740a4fddc..9b3ba4e1b5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -404,6 +404,14 @@ S: Supported
>  F: target/i386/kvm.c
>  F: scripts/kvm/vmxcap
> 
> +WHPX CPUs
> +M: Sunil Muthuswamy <sunilmut@microsoft.com>
> +S: Supported
> +F: target/i386/whpx-all.c
> +F: target/i386/whp-dispatch.h
> +F: accel/stubs/whpx-stub.c
> +F: include/sysemu/whpx.h
> +
>  Guest CPU Cores (Xen)
>  ---------------------
>  X86 Xen CPUs
> --
> 2.17.1
Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Philippe Mathieu-Daudé 4 years, 1 month ago 
Thank you Sunil!

On 2/18/20 9:51 PM, Justin Terry (SF) wrote:
> Looks good to me! Thanks Sunil.
> 
> Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>

Justin, I suppose you meant:
Reviewed-by: Justin Terry (VM) <juterry@microsoft.com>

> 
>> -----Original Message-----
>> From: Sunil Muthuswamy <sunilmut@microsoft.com>
>> Sent: Tuesday, February 18, 2020 12:39 PM
>> To: Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini
>> <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>
>> Cc: Stefan Weil <sw@weilnetz.de>; qemu-devel@nongnu.org; Justin Terry
>> (SF) <juterry@microsoft.com>
>> Subject: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor
>> Platform
>>
>> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
>> ---
>>   MAINTAINERS | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 1740a4fddc..9b3ba4e1b5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -404,6 +404,14 @@ S: Supported
>>   F: target/i386/kvm.c
>>   F: scripts/kvm/vmxcap
>>
>> +WHPX CPUs

Using "X86 WHPX CPUs" instead:

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>> +M: Sunil Muthuswamy <sunilmut@microsoft.com>
>> +S: Supported
>> +F: target/i386/whpx-all.c
>> +F: target/i386/whp-dispatch.h
>> +F: accel/stubs/whpx-stub.c
>> +F: include/sysemu/whpx.h
>> +
>>   Guest CPU Cores (Xen)
>>   ---------------------
>>   X86 Xen CPUs
>> --
>> 2.17.1
>
RE: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Justin Terry (SF) 4 years, 1 month ago 
Ha yes. LGTM Thanks!

Reviewed-by: Justin Terry (VM) <juterry@microsoft.com>

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Wednesday, February 19, 2020 12:32 AM
> To: Justin Terry (SF) <juterry@microsoft.com>; Sunil Muthuswamy
> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>;
> Paolo Bonzini <pbonzini@redhat.com>; Richard Henderson
> <rth@twiddle.net>
> Cc: Stefan Weil <sw@weilnetz.de>; qemu-devel@nongnu.org
> Subject: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows
> Hypervisor Platform
> 
> Thank you Sunil!
> 
> On 2/18/20 9:51 PM, Justin Terry (SF) wrote:
> > Looks good to me! Thanks Sunil.
> >
> > Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
> 
> Justin, I suppose you meant:
> Reviewed-by: Justin Terry (VM) <juterry@microsoft.com>
> 
> >
> >> -----Original Message-----
> >> From: Sunil Muthuswamy <sunilmut@microsoft.com>
> >> Sent: Tuesday, February 18, 2020 12:39 PM
> >> To: Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini
> >> <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>
> >> Cc: Stefan Weil <sw@weilnetz.de>; qemu-devel@nongnu.org; Justin
> Terry
> >> (SF) <juterry@microsoft.com>
> >> Subject: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor
> >> Platform
> >>
> >> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> >> ---
> >>   MAINTAINERS | 8 ++++++++
> >>   1 file changed, 8 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS index 1740a4fddc..9b3ba4e1b5
> >> 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -404,6 +404,14 @@ S: Supported
> >>   F: target/i386/kvm.c
> >>   F: scripts/kvm/vmxcap
> >>
> >> +WHPX CPUs
> 
> Using "X86 WHPX CPUs" instead:
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> >> +M: Sunil Muthuswamy <sunilmut@microsoft.com>
> >> +S: Supported
> >> +F: target/i386/whpx-all.c
> >> +F: target/i386/whp-dispatch.h
> >> +F: accel/stubs/whpx-stub.c
> >> +F: include/sysemu/whpx.h
> >> +
> >>   Guest CPU Cores (Xen)
> >>   ---------------------
> >>   X86 Xen CPUs
> >> --
> >> 2.17.1
> >
Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Stefan Weil 4 years, 1 month ago 
Am 19.02.20 um 16:50 schrieb Justin Terry (SF):

> Ha yes. LGTM Thanks!
>
> Reviewed-by: Justin Terry (VM) <juterry@microsoft.com>
>
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Sent: Wednesday, February 19, 2020 12:32 AM
>> To: Justin Terry (SF) <juterry@microsoft.com>; Sunil Muthuswamy
>> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>;
>> Paolo Bonzini <pbonzini@redhat.com>; Richard Henderson
>> <rth@twiddle.net>
>> Cc: Stefan Weil <sw@weilnetz.de>; qemu-devel@nongnu.org
>> Subject: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows
>> Hypervisor Platform
>>
>> Thank you Sunil!
>>
>> On 2/18/20 9:51 PM, Justin Terry (SF) wrote:
>>> Looks good to me! Thanks Sunil.
>>>
>>> Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>


Hello Justin, hello Sunil,

just a reminder: we still have the problem with the proprietary license
for the required Microsoft header files.

Can you estimate when this will be solved?

Regards,
Stefan
RE: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Sunil Muthuswamy 4 years, 1 month ago 
> -----Original Message-----
> From: Stefan Weil <sw@weilnetz.de>
> Sent: Thursday, February 20, 2020 11:54 PM
> To: Justin Terry (SF) <juterry@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>; Sunil Muthuswamy
> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Richard Henderson
> <rth@twiddle.net>
> Cc: qemu-devel@nongnu.org
> Subject: Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
> 
> Am 19.02.20 um 16:50 schrieb Justin Terry (SF):
> 
> 
> Hello Justin, hello Sunil,
> 
> just a reminder: we still have the problem with the proprietary license
> for the required Microsoft header files.
> 
> Can you estimate when this will be solved?
> 

Thanks for the reminder, Stefan. Yes, agreed this problem still exists. We followed up with
the SDK team and the legal team end of last year. I will nudge them again for an update
here.

> Regards,
> Stefan
>
Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago 
+Mike Battista & lanchpad ticket

On 2/24/20 8:43 PM, Sunil Muthuswamy wrote:
>> -----Original Message-----
>> From: Stefan Weil <sw@weilnetz.de>
>> Sent: Thursday, February 20, 2020 11:54 PM
>> To: Justin Terry (SF) <juterry@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>; Sunil Muthuswamy
>> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Richard Henderson
>> <rth@twiddle.net>
>> Cc: qemu-devel@nongnu.org
>> Subject: Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
>>
>> Am 19.02.20 um 16:50 schrieb Justin Terry (SF):
>>
>>
>> Hello Justin, hello Sunil,
>>
>> just a reminder: we still have the problem with the proprietary license
>> for the required Microsoft header files.
>>
>> Can you estimate when this will be solved?
>>
> 
> Thanks for the reminder, Stefan. Yes, agreed this problem still exists. We followed up with
> the SDK team and the legal team end of last year. I will nudge them again for an update
> here.
> 
>> Regards,
>> Stefan
>>
>
RE: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Sunil Muthuswamy 3 years, 11 months ago 

> -----Original Message-----
> From: Stefan Weil <sw@weilnetz.de>
> Sent: Thursday, February 20, 2020 11:54 PM
> To: Justin Terry (SF) <juterry@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>; Sunil Muthuswamy
> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Richard
> Henderson <rth@twiddle.net>
> Cc: qemu-devel@nongnu.org
> Subject: Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
> 
> Am 19.02.20 um 16:50 schrieb Justin Terry (SF):
> 
> Hello Justin, hello Sunil,
> 
> just a reminder: we still have the problem with the proprietary license
> for the required Microsoft header files.
> 
> Can you estimate when this will be solved?
> 
> Regards,
> Stefan
> 

Adding Mike Battista, who is on the SDK team and can help provide some clarity around the questions about SDK licensing.
Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago 
Hi Sunil,

On 5/19/20 11:59 PM, Sunil Muthuswamy wrote:
>> -----Original Message-----
>> From: Stefan Weil <sw@weilnetz.de>
>> Sent: Thursday, February 20, 2020 11:54 PM
>> To: Justin Terry (SF) <juterry@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>; Sunil Muthuswamy
>> <sunilmut@microsoft.com>; Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Richard
>> Henderson <rth@twiddle.net>
>> Cc: qemu-devel@nongnu.org
>> Subject: Re: [EXTERNAL] Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
>>
>> Am 19.02.20 um 16:50 schrieb Justin Terry (SF):
>>
>> Hello Justin, hello Sunil,
>>
>> just a reminder: we still have the problem with the proprietary license
>> for the required Microsoft header files.
>>
>> Can you estimate when this will be solved?
>>
>> Regards,
>> Stefan
>>
> 
> Adding Mike Battista, who is on the SDK team and can help provide some clarity around the questions about SDK licensing.
> 

To ease communication and track the changes over time regarding this 
problem, I opened a ticket on Launchpad:
https://bugs.launchpad.net/qemu/+bug/1879672

Last time (Sept 2019) Justin Terry contacted Microsoft legal department 
for guidance but no update since.
This is unfortunate as we can not let the community use this feature, 
neither can we keep testing WHPX to avoid code bitrot.

Can you meanwhile provide Azure CI builds using WHPX enabled?

Regards,

Phil.
Re: [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform
Posted by Paolo Bonzini 4 years, 1 month ago 
On 18/02/20 21:38, Sunil Muthuswamy wrote:
> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1740a4fddc..9b3ba4e1b5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -404,6 +404,14 @@ S: Supported
>  F: target/i386/kvm.c
>  F: scripts/kvm/vmxcap
>  
> +WHPX CPUs
> +M: Sunil Muthuswamy <sunilmut@microsoft.com>
> +S: Supported
> +F: target/i386/whpx-all.c
> +F: target/i386/whp-dispatch.h
> +F: accel/stubs/whpx-stub.c
> +F: include/sysemu/whpx.h
> +
>  Guest CPU Cores (Xen)
>  ---------------------
>  X86 Xen CPUs
> 

Queued.  Patches can still go through my tree while you get up to speed.
 Thanks!

Paolo

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.