Hi Cédric,

>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Sent: Tuesday, November 14, 2023 10:52 PM
>Subject: Re: [PATCH v6 00/21] vfio: Adopt iommufd
>
>Hello Zhenzhong,
>
>On 11/14/23 11:09, Zhenzhong Duan wrote:
>> Hi,
>>
>> Thanks all for giving guides and comments on previous series, this is
>> the remaining part of the iommufd support.
>>
>> Based on Cédric's suggestion, replace old config method for IOMMUFD
>> with Kconfig.
>>
>> Based on Jason's suggestion, drop the implementation of manually
>> allocating hwpt and switch to IOAS attach/detach.
>>
>> Beside current test, we also tested mdev with mtty for better cover range.
>>
>> PATCH 1: Introduce iommufd object
>> PATCH 2-9: add IOMMUFD container and cdev support
>> PATCH 10-17: fd passing for cdev and linking to IOMMUFD
>> PATCH 18: make VFIOContainerBase parameter const
>> PATCH 19-21: Compile out for IOMMUFD for arm, s390x and x86
>>
>>
>> We have done wide test with different combinations, e.g:
>> - PCI device were tested
>> - FD passing and hot reset with some trick.
>> - device hotplug test with legacy and iommufd backends
>> - with or without vIOMMU for legacy and iommufd backends
>> - divices linked to different iommufds
>> - VFIO migration with a E800 net card(no dirty sync support) passthrough
>> - platform, ccw and ap were only compile-tested due to environment limit
>> - test mdev pass through with mtty and mix with real device and different BE
>>
>> Given some iommufd kernel limitations, the iommufd backend is
>> not yet fully on par with the legacy backend w.r.t. features like:
>> - p2p mappings (you will see related error traces)
>> - dirty page sync
>> - and etc.
>>
>>
>> qemu code:
>https://github.com/yiliu1765/qemu/commits/zhenzhong/iommufd_cdev_v6
>> Based on vfio-next, commit id: 1a22fb936e
>
>I just had a few comments that I addressed myself in :
>
>   https://github.com/legoater/qemu/commits/vfio-8.2
>
>Please take a look and I will possibly merge the modified v6 in vfio-next
>after a few days or next week when people are back from LPC.

Good for me, only a minor suggestion to use OBJECT_DECLARE_TYPE.

>
>I would like to propose this series for an early merge in QEMU 9.0. So, we
>have a few weeks to polish and test a bit more. I didn't get feedback from
>ARM for instance (that's a message in a bottle for Eric :).

Glad to know, thanks very much for your active review and guidance
since my first version😊
I'll do more test recent days.

>
>My last request would be to take some of the documentation, below in this
>email, and include it in QEMU. It can be done later.

Sure, will do.

BRs.
Zhenzhong