RE: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements

Kane Chen posted 2 patches 1 month, 4 weeks ago
Only 0 patches received!
There is a newer version of this series
RE: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
Posted by Kane Chen 1 month, 4 weeks ago
> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Wednesday, February 11, 2026 4:33 PM
> To: Cédric Le Goater <clg@redhat.com>; qemu-devel@nongnu.org;
> qemu-arm@nongnu.org
> Cc: Peter Maydell <peter.maydell@linaro.org>; Steven Lee
> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Jamin Lin
> <jamin_lin@aspeedtech.com>; Andrew Jeffery
> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; Thomas
> Huth <thuth@redhat.com>; Kane Chen <kane_chen@aspeedtech.com>
> Subject: Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
> 
> Jamin, Kane,
> 
> Could you please review this series ?
> 
> Thanks,
> 
> C.
> 
> 
> 
> On 2/9/26 07:50, Cédric Le Goater wrote:
> > Hi,
> >
> > This allows the functional test suite to run tests in parallel more
> > effectively and adds a new set of tests using the older Linux 5.15
> > kernel.
> >
> > Thanks,
> >
> > C.
> >
> > Cédric Le Goater (2):
> >    tests/functional: Split Aspeed ARM tests into separate files
> >    tests/functional: Add SDK tests with Linux 5.15
> >
> >   tests/functional/arm/meson.build              | 18 ++++--
> >   tests/functional/arm/test_aspeed_ast1060.py   |  0
> >   ...00.py => test_aspeed_ast2500_buildroot.py} | 14 -----
> >   .../functional/arm/test_aspeed_ast2500_sdk.py | 29 +++++++++
> >   .../arm/test_aspeed_ast2500_sdk_515.py        | 29 +++++++++
> >   .../arm/test_aspeed_ast2600_buildroot.py      | 41 +------------
> >   .../arm/test_aspeed_ast2600_buildroot_tpm.py  | 60
> +++++++++++++++++++
> >   .../functional/arm/test_aspeed_ast2600_sdk.py | 15 -----
> >   .../arm/test_aspeed_ast2600_sdk_515.py        | 29 +++++++++
> >   .../arm/test_aspeed_ast2600_sdk_otp.py        | 34 +++++++++++
> >   10 files changed, 196 insertions(+), 73 deletions(-)
> >   mode change 100644 => 100755
> tests/functional/arm/test_aspeed_ast1060.py
> >   rename tests/functional/arm/{test_aspeed_ast2500.py =>
> test_aspeed_ast2500_buildroot.py} (74%)
> >   create mode 100755 tests/functional/arm/test_aspeed_ast2500_sdk.py
> >   create mode 100755
> tests/functional/arm/test_aspeed_ast2500_sdk_515.py
> >   create mode 100755
> tests/functional/arm/test_aspeed_ast2600_buildroot_tpm.py
> >   create mode 100755
> tests/functional/arm/test_aspeed_ast2600_sdk_515.py
> >   create mode 100755
> > tests/functional/arm/test_aspeed_ast2600_sdk_otp.py
> >

Hi Cédric,

Thank you for the effort in improving the test suite. The separation
into firmware-specific files makes it much clearer.

This series is reviewed.

Best Regards,
Kane
Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
Posted by Cédric Le Goater 1 month, 4 weeks ago
Hello Kane,

On 2/12/26 04:39, Kane Chen wrote:
>> -----Original Message-----
>> From: Cédric Le Goater <clg@kaod.org>
>> Sent: Wednesday, February 11, 2026 4:33 PM
>> To: Cédric Le Goater <clg@redhat.com>; qemu-devel@nongnu.org;
>> qemu-arm@nongnu.org
>> Cc: Peter Maydell <peter.maydell@linaro.org>; Steven Lee
>> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Jamin Lin
>> <jamin_lin@aspeedtech.com>; Andrew Jeffery
>> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; Thomas
>> Huth <thuth@redhat.com>; Kane Chen <kane_chen@aspeedtech.com>
>> Subject: Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
>>
>> Jamin, Kane,
>>
>> Could you please review this series ?
>>
>> Thanks,
>>
>> C.
>>
>>
>>
>> On 2/9/26 07:50, Cédric Le Goater wrote:
>>> Hi,
>>>
>>> This allows the functional test suite to run tests in parallel more
>>> effectively and adds a new set of tests using the older Linux 5.15
>>> kernel.
>>>
>>> Thanks,
>>>
>>> C.
>>>
>>> Cédric Le Goater (2):
>>>     tests/functional: Split Aspeed ARM tests into separate files
>>>     tests/functional: Add SDK tests with Linux 5.15
>>>
>>>    tests/functional/arm/meson.build              | 18 ++++--
>>>    tests/functional/arm/test_aspeed_ast1060.py   |  0
>>>    ...00.py => test_aspeed_ast2500_buildroot.py} | 14 -----
>>>    .../functional/arm/test_aspeed_ast2500_sdk.py | 29 +++++++++
>>>    .../arm/test_aspeed_ast2500_sdk_515.py        | 29 +++++++++
>>>    .../arm/test_aspeed_ast2600_buildroot.py      | 41 +------------
>>>    .../arm/test_aspeed_ast2600_buildroot_tpm.py  | 60
>> +++++++++++++++++++
>>>    .../functional/arm/test_aspeed_ast2600_sdk.py | 15 -----
>>>    .../arm/test_aspeed_ast2600_sdk_515.py        | 29 +++++++++
>>>    .../arm/test_aspeed_ast2600_sdk_otp.py        | 34 +++++++++++
>>>    10 files changed, 196 insertions(+), 73 deletions(-)
>>>    mode change 100644 => 100755
>> tests/functional/arm/test_aspeed_ast1060.py
>>>    rename tests/functional/arm/{test_aspeed_ast2500.py =>
>> test_aspeed_ast2500_buildroot.py} (74%)
>>>    create mode 100755 tests/functional/arm/test_aspeed_ast2500_sdk.py
>>>    create mode 100755
>> tests/functional/arm/test_aspeed_ast2500_sdk_515.py
>>>    create mode 100755
>> tests/functional/arm/test_aspeed_ast2600_buildroot_tpm.py
>>>    create mode 100755
>> tests/functional/arm/test_aspeed_ast2600_sdk_515.py
>>>    create mode 100755
>>> tests/functional/arm/test_aspeed_ast2600_sdk_otp.py
>>>
> 
> Hi Cédric,
> 
> Thank you for the effort in improving the test suite. The separation
> into firmware-specific files makes it much clearer.
> 
> This series is reviewed.
Could you please send a Reviewed-by: tag ?

Thanks,

C.

Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
Posted by Cédric Le Goater 1 month, 4 weeks ago
On 2/12/26 08:55, Cédric Le Goater wrote:
> Hello Kane,
> 
> On 2/12/26 04:39, Kane Chen wrote:
>>> -----Original Message-----
>>> From: Cédric Le Goater <clg@kaod.org>
>>> Sent: Wednesday, February 11, 2026 4:33 PM
>>> To: Cédric Le Goater <clg@redhat.com>; qemu-devel@nongnu.org;
>>> qemu-arm@nongnu.org
>>> Cc: Peter Maydell <peter.maydell@linaro.org>; Steven Lee
>>> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Jamin Lin
>>> <jamin_lin@aspeedtech.com>; Andrew Jeffery
>>> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; Thomas
>>> Huth <thuth@redhat.com>; Kane Chen <kane_chen@aspeedtech.com>
>>> Subject: Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
>>>
>>> Jamin, Kane,
>>>
>>> Could you please review this series ?
>>>
>>> Thanks,
>>>
>>> C.
>>>
>>>
>>>
>>> On 2/9/26 07:50, Cédric Le Goater wrote:
>>>> Hi,
>>>>
>>>> This allows the functional test suite to run tests in parallel more
>>>> effectively and adds a new set of tests using the older Linux 5.15
>>>> kernel.
>>>>
>>>> Thanks,
>>>>
>>>> C.
>>>>
>>>> Cédric Le Goater (2):
>>>>     tests/functional: Split Aspeed ARM tests into separate files
>>>>     tests/functional: Add SDK tests with Linux 5.15
>>>>
>>>>    tests/functional/arm/meson.build              | 18 ++++--
>>>>    tests/functional/arm/test_aspeed_ast1060.py   |  0
>>>>    ...00.py => test_aspeed_ast2500_buildroot.py} | 14 -----
>>>>    .../functional/arm/test_aspeed_ast2500_sdk.py | 29 +++++++++
>>>>    .../arm/test_aspeed_ast2500_sdk_515.py        | 29 +++++++++
>>>>    .../arm/test_aspeed_ast2600_buildroot.py      | 41 +------------
>>>>    .../arm/test_aspeed_ast2600_buildroot_tpm.py  | 60
>>> +++++++++++++++++++
>>>>    .../functional/arm/test_aspeed_ast2600_sdk.py | 15 -----
>>>>    .../arm/test_aspeed_ast2600_sdk_515.py        | 29 +++++++++
>>>>    .../arm/test_aspeed_ast2600_sdk_otp.py        | 34 +++++++++++
>>>>    10 files changed, 196 insertions(+), 73 deletions(-)
>>>>    mode change 100644 => 100755
>>> tests/functional/arm/test_aspeed_ast1060.py
>>>>    rename tests/functional/arm/{test_aspeed_ast2500.py =>
>>> test_aspeed_ast2500_buildroot.py} (74%)
>>>>    create mode 100755 tests/functional/arm/test_aspeed_ast2500_sdk.py
>>>>    create mode 100755
>>> tests/functional/arm/test_aspeed_ast2500_sdk_515.py
>>>>    create mode 100755
>>> tests/functional/arm/test_aspeed_ast2600_buildroot_tpm.py
>>>>    create mode 100755
>>> tests/functional/arm/test_aspeed_ast2600_sdk_515.py
>>>>    create mode 100755
>>>> tests/functional/arm/test_aspeed_ast2600_sdk_otp.py
>>>>
>>
>> Hi Cédric,
>>
>> Thank you for the effort in improving the test suite. The separation
>> into firmware-specific files makes it much clearer.
>>
>> This series is reviewed.
> Could you please send a Reviewed-by: tag ?
you did. I received them on my @redhat.com email.

Thanks !

C.


RE: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
Posted by Kane Chen 1 month, 4 weeks ago
> -----Original Message-----
> From: Cédric Le Goater <clg@redhat.com>
> Sent: Thursday, February 12, 2026 4:10 PM
> To: Cédric Le Goater <clg@kaod.org>; Kane Chen
> <kane_chen@aspeedtech.com>; qemu-devel@nongnu.org;
> qemu-arm@nongnu.org
> Cc: Peter Maydell <peter.maydell@linaro.org>; Steven Lee
> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Jamin Lin
> <jamin_lin@aspeedtech.com>; Andrew Jeffery
> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; Thomas
> Huth <thuth@redhat.com>
> Subject: Re: [PATCH 0/2] tests/functional: Aspeed ARM tests enhancements
> 
> On 2/12/26 08:55, Cédric Le Goater wrote:
> > Hello Kane,
> >
> > On 2/12/26 04:39, Kane Chen wrote:
> >>> -----Original Message-----
> >>> From: Cédric Le Goater <clg@kaod.org>
> >>> Sent: Wednesday, February 11, 2026 4:33 PM
> >>> To: Cédric Le Goater <clg@redhat.com>; qemu-devel@nongnu.org;
> >>> qemu-arm@nongnu.org
> >>> Cc: Peter Maydell <peter.maydell@linaro.org>; Steven Lee
> >>> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Jamin
> Lin
> >>> <jamin_lin@aspeedtech.com>; Andrew Jeffery
> >>> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>;
> Thomas
> >>> Huth <thuth@redhat.com>; Kane Chen <kane_chen@aspeedtech.com>
> >>> Subject: Re: [PATCH 0/2] tests/functional: Aspeed ARM tests
> >>> enhancements
> >>>
> >>> Jamin, Kane,
> >>>
> >>> Could you please review this series ?
> >>>
> >>> Thanks,
> >>>
> >>> C.
> >>>
> >>>
> >>>
> >>> On 2/9/26 07:50, Cédric Le Goater wrote:
> >>>> Hi,
> >>>>
> >>>> This allows the functional test suite to run tests in parallel more
> >>>> effectively and adds a new set of tests using the older Linux 5.15
> >>>> kernel.
> >>>>
> >>>> Thanks,
> >>>>
> >>>> C.
> >>>>
> >>>> Cédric Le Goater (2):
> >>>>     tests/functional: Split Aspeed ARM tests into separate files
> >>>>     tests/functional: Add SDK tests with Linux 5.15
> >>>>
> >>>>    tests/functional/arm/meson.build              | 18 ++++--
> >>>>    tests/functional/arm/test_aspeed_ast1060.py   |  0
> >>>>    ...00.py => test_aspeed_ast2500_buildroot.py} | 14 -----
> >>>>    .../functional/arm/test_aspeed_ast2500_sdk.py | 29 +++++++++
> >>>>    .../arm/test_aspeed_ast2500_sdk_515.py        | 29
> +++++++++
> >>>>    .../arm/test_aspeed_ast2600_buildroot.py      | 41 +------------
> >>>>    .../arm/test_aspeed_ast2600_buildroot_tpm.py  | 60
> >>> +++++++++++++++++++
> >>>>    .../functional/arm/test_aspeed_ast2600_sdk.py | 15 -----
> >>>>    .../arm/test_aspeed_ast2600_sdk_515.py        | 29
> +++++++++
> >>>>    .../arm/test_aspeed_ast2600_sdk_otp.py        | 34
> +++++++++++
> >>>>    10 files changed, 196 insertions(+), 73 deletions(-)
> >>>>    mode change 100644 => 100755
> >>> tests/functional/arm/test_aspeed_ast1060.py
> >>>>    rename tests/functional/arm/{test_aspeed_ast2500.py =>
> >>> test_aspeed_ast2500_buildroot.py} (74%)
> >>>>    create mode 100755
> >>>> tests/functional/arm/test_aspeed_ast2500_sdk.py
> >>>>    create mode 100755
> >>> tests/functional/arm/test_aspeed_ast2500_sdk_515.py
> >>>>    create mode 100755
> >>> tests/functional/arm/test_aspeed_ast2600_buildroot_tpm.py
> >>>>    create mode 100755
> >>> tests/functional/arm/test_aspeed_ast2600_sdk_515.py
> >>>>    create mode 100755
> >>>> tests/functional/arm/test_aspeed_ast2600_sdk_otp.py
> >>>>
> >>
> >> Hi Cédric,
> >>
> >> Thank you for the effort in improving the test suite. The separation
> >> into firmware-specific files makes it much clearer.
> >>
> >> This series is reviewed.
> > Could you please send a Reviewed-by: tag ?
> you did. I received them on my @redhat.com email.
> 
> Thanks !
> 
> C.

Hi Cédric,

Glad to hear you received them.

I was a bit concerned because I imported the emails from an mbox file
into Outlook, and I wasn't sure if they would be sent or formatted
correctly.

Best Regards,
Kane