Hi Cédric,

Thanks for the review.

Best Regards,
Kane
> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Wednesday, September 17, 2025 2:23 PM
> To: Kane Chen <kane_chen@aspeedtech.com>; Peter Maydell
> <peter.maydell@linaro.org>; Steven Lee <steven_lee@aspeedtech.com>; Troy
> Lee <leetroy@gmail.com>; Jamin Lin <jamin_lin@aspeedtech.com>; Andrew
> Jeffery <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>;
> open list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC
> here <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_lee@aspeedtech.com>; thuth@redhat.com
> Subject: Re: [SPAM] [PATCH v2 0/3] tests/functional/arm: Add OTP functional
> test
> 
> On 9/17/25 05:59, Kane Chen wrote:
> > From: Kane-Chen-AS <kane_chen@aspeedtech.com>
> >
> > Hi all,
> >
> > During early boot, SoC firmware reads from the OTP region to obtain
> > the chip ID and default configuration. This series adds functional
> > tests that boot with a generated OTP image and verify that the
> > firmware reads these contents correctly during initialization.
> >
> > Any feedback or suggestions are appreciated.
> >
> > Best Regards,
> > Kane
> > ---
> > Change log:
> > v2: Fine-tune test scripts
> >
> > v1: Initial version
> > ---
> > Kane-Chen-AS (3):
> >    tests/functional/arm: Add helper to generate OTP images
> >    tests/functional/arm: Add AST1030 boot test with generated OTP image
> >    tests/functional/arm: Add AST2600 boot test with generated OTP
> > image
> >
> >   tests/functional/arm/test_aspeed_ast1030.py | 24
> +++++++++++++++++----
> >   tests/functional/arm/test_aspeed_ast2600.py | 14 ++++++++++++
> >   tests/functional/aspeed.py                  |  8 +++++++
> >   3 files changed, 42 insertions(+), 4 deletions(-)
> >
> 
> For the series,
> 
> Reviewed-by: Cédric Le Goater <clg@redhat.com>
> 
> Thanks,
> 
> C.
>