Hi Cedric,

> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode
> 
> Hello Jamin,
> 
> On 10/22/24 11:40, Jamin Lin wrote:
> > change from v1:
> >   1. Fix write incorrect data into flash in user mode.
> >   2. Refactor aspeed smc qtest testcases to support AST2600, AST2500
> > and AST1030.
> >   3. Add ast2700 smc qtest testcase to support AST2700.
> >
> > change from v2:
> > 1. Introduce a new aspeed-smc-utils.c to place common testcases.
> > 2. Fix hardcode attach flash model of spi controllers 3. Add reviewers
> > suggestion and fix review issue.
> I have applied 1-6,8 to aspeed-next and should send a PR with them. I kept the
> test extensions for later, to take a closer a look and also because I will be on
> PTO next week. Tests can be merged in the next PR if we have time in this cycle
> or in QEMU 10.0.
> 
Got it and thanks for help.
Jamin
> Thanks,
> 
> C.
> 

Hi Cedric,

> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode
> 
> Hi Cedric,
> 
> > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in
> > user mode
> >
> > Hello Jamin,
> >
> > On 10/22/24 11:40, Jamin Lin wrote:
> > > change from v1:
> > >   1. Fix write incorrect data into flash in user mode.
> > >   2. Refactor aspeed smc qtest testcases to support AST2600, AST2500
> > > and AST1030.
> > >   3. Add ast2700 smc qtest testcase to support AST2700.
> > >
> > > change from v2:
> > > 1. Introduce a new aspeed-smc-utils.c to place common testcases.
> > > 2. Fix hardcode attach flash model of spi controllers 3. Add
> > > reviewers suggestion and fix review issue.
> > I have applied 1-6,8 to aspeed-next and should send a PR with them. I
> > kept the test extensions for later, to take a closer a look and also
> > because I will be on PTO next week. Tests can be merged in the next PR
> > if we have time in this cycle or in QEMU 10.0.
> >
> Got it and thanks for help.
> Jamin
> > Thanks,

Could you please help to review patch 17 and 18 ?
Do I need to re-send patch from 9 to 18 of this patch series? 
Thanks-Jamin

> >
> > C.
> >

Hello Jamin,

On 11/14/24 06:30, Jamin Lin wrote:
> Hi Cedric,
> 
>> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode
>>
>> Hi Cedric,
>>
>>> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in
>>> user mode
>>>
>>> Hello Jamin,
>>>
>>> On 10/22/24 11:40, Jamin Lin wrote:
>>>> change from v1:
>>>>    1. Fix write incorrect data into flash in user mode.
>>>>    2. Refactor aspeed smc qtest testcases to support AST2600, AST2500
>>>> and AST1030.
>>>>    3. Add ast2700 smc qtest testcase to support AST2700.
>>>>
>>>> change from v2:
>>>> 1. Introduce a new aspeed-smc-utils.c to place common testcases.
>>>> 2. Fix hardcode attach flash model of spi controllers 3. Add
>>>> reviewers suggestion and fix review issue.
>>> I have applied 1-6,8 to aspeed-next and should send a PR with them. I
>>> kept the test extensions for later, to take a closer a look and also
>>> because I will be on PTO next week. Tests can be merged in the next PR
>>> if we have time in this cycle or in QEMU 10.0.
>>>
>> Got it and thanks for help.
>> Jamin
>>> Thanks,
> 
> Could you please help to review patch 17 and 18 ?
> Do I need to re-send patch from 9 to 18 of this patch series?

Not yet. I have some comments to send but I am busy on another topic.

We have some time before QEMU 10.0. They are in my aspeed-9.2 branch,
so that I don't forget about them.

Thanks,

C.

Hi Cedric,

> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode
> 
> Hello Jamin,
> 
> On 11/14/24 06:30, Jamin Lin wrote:
> > Hi Cedric,
> >
> >> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in
> >> user mode
> >>
> >> Hi Cedric,
> >>
> >>> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in
> >>> user mode
> >>>
> >>> Hello Jamin,
> >>>
> >>> On 10/22/24 11:40, Jamin Lin wrote:
> >>>> change from v1:
> >>>>    1. Fix write incorrect data into flash in user mode.
> >>>>    2. Refactor aspeed smc qtest testcases to support AST2600,
> >>>> AST2500 and AST1030.
> >>>>    3. Add ast2700 smc qtest testcase to support AST2700.
> >>>>
> >>>> change from v2:
> >>>> 1. Introduce a new aspeed-smc-utils.c to place common testcases.
> >>>> 2. Fix hardcode attach flash model of spi controllers 3. Add
> >>>> reviewers suggestion and fix review issue.
> >>> I have applied 1-6,8 to aspeed-next and should send a PR with them.
> >>> I kept the test extensions for later, to take a closer a look and
> >>> also because I will be on PTO next week. Tests can be merged in the
> >>> next PR if we have time in this cycle or in QEMU 10.0.
> >>>
> >> Got it and thanks for help.
> >> Jamin
> >>> Thanks,
> >
> > Could you please help to review patch 17 and 18 ?
> > Do I need to re-send patch from 9 to 18 of this patch series?
> 
> Not yet. I have some comments to send but I am busy on another topic.
> 
Got it.
Thanks for your kindly support.
Jamin
> We have some time before QEMU 10.0. They are in my aspeed-9.2 branch, so
> that I don't forget about them.
> 
> Thanks,
> 
> C.
>