[v2] backends/cryptodev-vhost-user: Fix local_error leaks

[PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

Posted by Gabriel Barrantes 3 months, 1 week ago

From 532af9eecee4695abb02b40f2c18b711370aa7d2 Mon Sep 17 00:00:00 2001
From: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
Date: Fri, 27 Dec 2024 18:02:32 -0600
Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

Do not propagate error to the upper, directly output the error to
avoid leaks.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2714
Fixes: 2fda101de07 ("virtio-crypto: Support asynchronous mode")

Signed-off-by: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
---
Changes in v2:

  *
Add full link to issue.
  *
Add reference to first bad commit.

---
backends/cryptodev-vhost-user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.
c
index 43efdf9747..f87172b330 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -281,8 +281,8 @@ static int cryptodev_vhost_user_create_session(
        break;

    default:
-        error_setg(&local_error, "Unsupported opcode :%" PRIu32 "",
-                   sess_info->op_code);
+        error_report("Unsupported opcode :%" PRIu32 "",
+                     sess_info->op_code);
        return -VIRTIO_CRYPTO_NOTSUPP;
    }

--
2.34.1

Re: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

Posted by Michael Tokarev 2 months, 2 weeks ago

28.12.2024 04:16, Gabriel Barrantes wrote:
>  From 532af9eecee4695abb02b40f2c18b711370aa7d2 Mon Sep 17 00:00:00 2001
> From: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
> Date: Fri, 27 Dec 2024 18:02:32 -0600
> Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks
> 
> Do not propagate error to the upper, directly output the error to
> avoid leaks.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2714
> Fixes: 2fda101de07 ("virtio-crypto: Support asynchronous mode")

This looks like a qemu-stable material.  Please let me know if it is not.

Thanks,

/mjt

> Signed-off-by: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
> ---
> Changes in v2:
> 
>   *
>     Add full link to issue.
>   *
>     Add reference to first bad commit.
> 
> ---
> backends/cryptodev-vhost-user.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.
> c
> index 43efdf9747..f87172b330 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -281,8 +281,8 @@ static int cryptodev_vhost_user_create_session(
>          break;
> 
>      default:
> -        error_setg(&local_error, "Unsupported opcode :%" PRIu32 "",
> -                   sess_info->op_code);
> +        error_report("Unsupported opcode :%" PRIu32 "",
> +                     sess_info->op_code);
>          return -VIRTIO_CRYPTO_NOTSUPP;
>      }
> 
> -- 
> 2.34.1
>

Re: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago

On 28/12/24 02:16, Gabriel Barrantes wrote:
>  From 532af9eecee4695abb02b40f2c18b711370aa7d2 Mon Sep 17 00:00:00 2001
> From: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
> Date: Fri, 27 Dec 2024 18:02:32 -0600
> Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks
> 
> Do not propagate error to the upper, directly output the error to
> avoid leaks.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2714
> Fixes: 2fda101de07 ("virtio-crypto: Support asynchronous mode")
> 
> Signed-off-by: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
> ---
> Changes in v2:
> 
>   *
>     Add full link to issue.
>   *
>     Add reference to first bad commit.
> 
> ---
> backends/cryptodev-vhost-user.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch queued adding zhenwei pi R-b tag from v1, thanks.