Series comparison

-[PATCH v3] hw/avr: Add limited support for avr gpio registers
+[PATCH v5] hw/avr: Add limited support for avr gpio registers
-I am very sorry for your inconvenience. This is 3rd version of the patch for what I did.
+Add some of these features for AVR GPIO:
 I should have read the contribution guide again and again. I am very sorry again.
 The contents of the patch is the same with the v2. This mail is just for patchew and making a new thread.
 Here are what I changed from the v1:
   *   Remove unnecessary header inclusions
   *   Replace codes for unreachable conditions with g_assert_not_reached() function
   *   Remove 'enable' field from AVRGPIOState structure: It is actually unnecessary. I copied this field from AVRUSARTState structure.
 Thanks a lot!
 With best regards
 Heecheol Yang.
 Add some of these features for avr gpio:
   - GPIO I/O : PORTx registers
   - Data Direction : DDRx registers
+  - DDRx toggling : PINx registers
 Following things are not supported yet:
-  - PINx registers
   - MCUR registers
-  - Even though read/write for DDRx registers are
-    implemented, actual direction controls are not
-    supported yet.
 Signed-off-by: Heecheol Yang <heecheol.yang@outlook.com>
 ---
  hw/avr/Kconfig             |   1 +
- hw/avr/atmega.c            |   7 ++-
+ hw/avr/atmega.c            |   7 +-
  hw/avr/atmega.h            |   2 +
  hw/gpio/Kconfig            |   3 +
- hw/gpio/avr_gpio.c         | 112 +++++++++++++++++++++++++++++++++++++
+ hw/gpio/avr_gpio.c         | 136 +++++++++++++++++++++++++++++++++++++
  hw/gpio/meson.build        |   2 +
- include/hw/gpio/avr_gpio.h |  46 +++++++++++++++
+ include/hw/gpio/avr_gpio.h |  53 +++++++++++++++
-files changed, 171 insertions(+), 2 deletions(-)
+files changed, 202 insertions(+), 2 deletions(-)
  create mode 100644 hw/gpio/avr_gpio.c
  create mode 100644 include/hw/gpio/avr_gpio.h
 diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
 index XXXXXXX..XXXXXXX 100644
 ...
 @@ -XXX,XX +XXX,XX @@ config AVR_ATMEGA_MCU
      select AVR_TIMER16
      select AVR_USART
      select AVR_POWER
 +    select AVR_GPIO
  config ARDUINO
      select AVR_ATMEGA_MCU
 diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/avr/atmega.c
 ...
 +        sysbus_realize(SYS_BUS_DEVICE(&s->gpio[i]), &error_abort);
 +        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0,
 +            OFFSET_DATA + mc->dev[idx].addr);
          g_free(devname);
      }
 diff --git a/hw/avr/atmega.h b/hw/avr/atmega.h
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/avr/atmega.h
 +++ b/hw/avr/atmega.h
 @@ -XXX,XX +XXX,XX @@
  #include "hw/char/avr_usart.h"
  #include "hw/timer/avr_timer16.h"
 +#include "hw/gpio/avr_gpio.h"
  #include "hw/misc/avr_power.h"
  #include "target/avr/cpu.h"
 ...
 diff --git a/hw/gpio/Kconfig b/hw/gpio/Kconfig
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/gpio/Kconfig
 +++ b/hw/gpio/Kconfig
 @@ -XXX,XX +XXX,XX @@ config GPIO_KEY
  config SIFIVE_GPIO
      bool
 +
 +config AVR_GPIO
 +    bool
 ...
 + * with this program; if not, see <http://www.gnu.org/licenses/>.
 + */
 +#include "qemu/osdep.h"
 +#include "qemu/log.h"
 +#include "qemu/module.h"
++#include "qemu/osdep.h"
 +#include "qapi/error.h"
 +#include "hw/sysbus.h"
 +#include "hw/irq.h"
 +#include "hw/gpio/avr_gpio.h"
 +#include "hw/qdev-properties.h"
 +
 +static void avr_gpio_reset(DeviceState *dev)
 +{
 +    AVRGPIOState *gpio = AVR_GPIO(dev);
-+    gpio->ddr_val = 0u;
++    gpio->reg.pin = 0u;
-+    gpio->port_val = 0u;
++    gpio->reg.ddr = 0u;
 +    gpio->reg.port = 0u;
 +}
 +
 +static void avr_gpio_write_port(AVRGPIOState *s, uint64_t value)
 +{
 +    uint8_t pin;
 +    uint8_t cur_port_val = s->reg.port;
 +    uint8_t cur_ddr_val = s->reg.ddr;
 +
 +    for (pin = 0u; pin < 8u ; pin++) {
 +        uint8_t cur_port_pin_val = cur_port_val & 0x01u;
 +        uint8_t cur_ddr_pin_val = cur_ddr_val & 0x01u;
 +        uint8_t new_port_pin_val = value & 0x01u;
 +
 +        if (cur_ddr_pin_val && (cur_port_pin_val != new_port_pin_val)) {
 +            qemu_set_irq(s->out[pin], new_port_pin_val);
 +        }
 +        cur_port_val >>= 1u;
 +        cur_ddr_val >>= 1u;
 +        value >>= 1u;
 +    }
 +    s->reg.port = value & s->reg.ddr;
 +}
 +static uint64_t avr_gpio_read(void *opaque, hwaddr offset, unsigned int size)
 +{
 +    AVRGPIOState *s = (AVRGPIOState *)opaque;
 +    switch (offset) {
 +    case GPIO_PIN:
-+        /* Not implemented yet */
++        return s->reg.pin;
 +        break;
 +    case GPIO_DDR:
-+        return s->ddr_val;
++        return s->reg.ddr;
 +        break;
 +    case GPIO_PORT:
-+        return s->port_val;
++        return s->reg.port;
 +    default:
 +        g_assert_not_reached();
 +        break;
 +    }
 +    return 0;
 +}
 +
 +static void avr_gpio_write(void *opaque, hwaddr offset, uint64_t value,
 +                                unsigned int size)
 +{
 +    AVRGPIOState *s = (AVRGPIOState *)opaque;
++    value = value & 0xF;
 +    switch (offset) {
 +    case GPIO_PIN:
-+        /* Not implemented yet */
++        s->reg.pin = value;
 +        s->reg.port ^= s->reg.pin;
 +        break;
 +    case GPIO_DDR:
-+        s->ddr_val = value & 0xF;
++        s->reg.ddr = value;
 +        break;
 +    case GPIO_PORT:
-+        s->port_val = value & 0xF;
++        avr_gpio_write_port(s, value);
 +        break;
 +    default:
 +        g_assert_not_reached();
 +        break;
 +    }
 ...
 +};
 +
 +static void avr_gpio_init(Object *obj)
 +{
 +    AVRGPIOState *s = AVR_GPIO(obj);
++    qdev_init_gpio_out(DEVICE(obj), s->out, ARRAY_SIZE(s->out));
 +    memory_region_init_io(&s->mmio, obj, &avr_gpio_ops, s, TYPE_AVR_GPIO, 3);
 +    sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
 +}
 +static void avr_gpio_realize(DeviceState *dev, Error **errp)
 +{
-+    avr_gpio_reset(dev);
++    /* Do nothing currently */
 +}
 +
 +
 +static void avr_gpio_class_init(ObjectClass *klass, void *data)
 +{
 ...
 +#define GPIO_DDR   0x01
 +#define GPIO_PORT  0x02
 +
 +#define TYPE_AVR_GPIO "avr-gpio"
 +OBJECT_DECLARE_SIMPLE_TYPE(AVRGPIOState, AVR_GPIO)
++#define AVR_GPIO_COUNT 8
 +
 +struct AVRGPIOState {
 +    /*< private >*/
 +    SysBusDevice parent_obj;
 +
 +    /*< public >*/
 +    MemoryRegion mmio;
 +
-+    uint8_t ddr_val;
++    struct {
-+    uint8_t port_val;
++        uint8_t pin;
 +        uint8_t ddr;
 +        uint8_t port;
 +    } reg;
 +
 +    /* PORTx data changed IRQs */
 +    qemu_irq out[8u];
 +
 +};
 +
 +#endif /* AVR_GPIO_H */
 --
 .17.1

I am very sorry for your inconvenience. This is 3rd version of the patch for what I did.
I should have read the contribution guide again and again. I am very sorry again.

The contents of the patch is the same with the v2. This mail is just for patchew and making a new thread.
Here are what I changed from the v1:

*   Remove unnecessary header inclusions
  *   Replace codes for unreachable conditions with g_assert_not_reached() function
  *   Remove 'enable' field from AVRGPIOState structure: It is actually unnecessary. I copied this field from AVRUSARTState structure.

Thanks a lot!
With best regards
Heecheol Yang.

Add some of these features for avr gpio:

- GPIO I/O : PORTx registers
  - Data Direction : DDRx registers

Following things are not supported yet:
  - PINx registers
  - MCUR registers
  - Even though read/write for DDRx registers are
    implemented, actual direction controls are not
    supported yet.

Signed-off-by: Heecheol Yang <heecheol.yang@outlook.com>
---
 hw/avr/Kconfig             |   1 +
 hw/avr/atmega.c            |   7 ++-
 hw/avr/atmega.h            |   2 +
 hw/gpio/Kconfig            |   3 +
 hw/gpio/avr_gpio.c         | 112 +++++++++++++++++++++++++++++++++++++
 hw/gpio/meson.build        |   2 +
 include/hw/gpio/avr_gpio.h |  46 +++++++++++++++
 7 files changed, 171 insertions(+), 2 deletions(-)
 create mode 100644 hw/gpio/avr_gpio.c
 create mode 100644 include/hw/gpio/avr_gpio.h

config ARDUINO
     select AVR_ATMEGA_MCU
diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/avr/atmega.c
+++ b/hw/avr/atmega.c
@@ -XXX,XX +XXX,XX @@ static void atmega_realize(DeviceState *dev, Error **errp)
             continue;
         }
         devname = g_strdup_printf("atmega-gpio-%c", 'a' + (char)i);
-        create_unimplemented_device(devname,
-                                    OFFSET_DATA + mc->dev[idx].addr, 3);
+        object_initialize_child(OBJECT(dev), devname, &s->gpio[i],
+                                TYPE_AVR_GPIO);
+        sysbus_realize(SYS_BUS_DEVICE(&s->gpio[i]), &error_abort);
+        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0,
+            OFFSET_DATA + mc->dev[idx].addr);
         g_free(devname);
     }

diff --git a/hw/avr/atmega.h b/hw/avr/atmega.h
index XXXXXXX..XXXXXXX 100644
--- a/hw/avr/atmega.h
+++ b/hw/avr/atmega.h
@@ -XXX,XX +XXX,XX @@

#include "hw/char/avr_usart.h"
 #include "hw/timer/avr_timer16.h"
+#include "hw/gpio/avr_gpio.h"
 #include "hw/misc/avr_power.h"
 #include "target/avr/cpu.h"
 #include "qom/object.h"
@@ -XXX,XX +XXX,XX @@ struct AtmegaMcuState {
     DeviceState *io;
     AVRMaskState pwr[POWER_MAX];
     AVRUsartState usart[USART_MAX];
+    AVRGPIOState gpio[GPIO_MAX];
     AVRTimer16State timer[TIMER_MAX];
     uint64_t xtal_freq_hz;
 };
diff --git a/hw/gpio/Kconfig b/hw/gpio/Kconfig
index XXXXXXX..XXXXXXX 100644
--- a/hw/gpio/Kconfig
+++ b/hw/gpio/Kconfig
@@ -XXX,XX +XXX,XX @@ config GPIO_KEY

config SIFIVE_GPIO
     bool
+
+config AVR_GPIO
+    bool
diff --git a/hw/gpio/avr_gpio.c b/hw/gpio/avr_gpio.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/hw/gpio/avr_gpio.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * AVR processors GPIO registers emulation.
+ *
+ * Copyright (C) 2020 Heecheol Yang <heecheol.yang@outlook.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+#include "qemu/osdep.h"
+#include "qemu/log.h"
+#include "qemu/module.h"
+#include "qapi/error.h"
+#include "hw/sysbus.h"
+#include "hw/irq.h"
+#include "hw/gpio/avr_gpio.h"
+#include "hw/qdev-properties.h"
+
+static void avr_gpio_reset(DeviceState *dev)
+{
+    AVRGPIOState *gpio = AVR_GPIO(dev);
+    gpio->ddr_val = 0u;
+    gpio->port_val = 0u;
+}
+static uint64_t avr_gpio_read(void *opaque, hwaddr offset, unsigned int size)
+{
+    AVRGPIOState *s = (AVRGPIOState *)opaque;
+    switch (offset) {
+    case GPIO_PIN:
+        /* Not implemented yet */
+        break;
+    case GPIO_DDR:
+        return s->ddr_val;
+        break;
+    case GPIO_PORT:
+        return s->port_val;
+    default:
+        g_assert_not_reached();
+        break;
+    }
+    return 0;
+}
+
+static void avr_gpio_write(void *opaque, hwaddr offset, uint64_t value,
+                                unsigned int size)
+{
+    AVRGPIOState *s = (AVRGPIOState *)opaque;
+    switch (offset) {
+    case GPIO_PIN:
+        /* Not implemented yet */
+        break;
+    case GPIO_DDR:
+        s->ddr_val = value & 0xF;
+        break;
+    case GPIO_PORT:
+        s->port_val = value & 0xF;
+        break;
+    default:
+        g_assert_not_reached();
+        break;
+    }
+}
+
+static const MemoryRegionOps avr_gpio_ops = {
+    .read = avr_gpio_read,
+    .write = avr_gpio_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+};
+
+static void avr_gpio_init(Object *obj)
+{
+    AVRGPIOState *s = AVR_GPIO(obj);
+    memory_region_init_io(&s->mmio, obj, &avr_gpio_ops, s, TYPE_AVR_GPIO, 3);
+    sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
+}
+static void avr_gpio_realize(DeviceState *dev, Error **errp)
+{
+    avr_gpio_reset(dev);
+}
+
+
+static void avr_gpio_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->reset = avr_gpio_reset;
+    dc->realize = avr_gpio_realize;
+}
+
+static const TypeInfo avr_gpio_info = {
+    .name          = TYPE_AVR_GPIO,
+    .parent        = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(AVRGPIOState),
+    .instance_init = avr_gpio_init,
+    .class_init    = avr_gpio_class_init,
+};
+
+static void avr_gpio_register_types(void)
+{
+    type_register_static(&avr_gpio_info);
+}
+
+type_init(avr_gpio_register_types)
diff --git a/hw/gpio/meson.build b/hw/gpio/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/hw/gpio/meson.build
+++ b/hw/gpio/meson.build
@@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_OMAP', if_true: files('omap_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2835_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files('aspeed_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_SIFIVE_GPIO', if_true: files('sifive_gpio.c'))
+
+softmmu_ss.add(when: 'CONFIG_AVR_GPIO', if_true: files('avr_gpio.c'))
diff --git a/include/hw/gpio/avr_gpio.h b/include/hw/gpio/avr_gpio.h
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/include/hw/gpio/avr_gpio.h
@@ -XXX,XX +XXX,XX @@
+/*
+ * AVR processors GPIO registers definition.
+ *
+ * Copyright (C) 2020 Heecheol Yang <heecheol.yang@outlook.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef AVR_GPIO_H
+#define AVR_GPIO_H
+
+#include "hw/sysbus.h"
+#include "qom/object.h"
+
+/* Offsets of registers. */
+#define GPIO_PIN   0x00
+#define GPIO_DDR   0x01
+#define GPIO_PORT  0x02
+
+#define TYPE_AVR_GPIO "avr-gpio"
+OBJECT_DECLARE_SIMPLE_TYPE(AVRGPIOState, AVR_GPIO)
+
+struct AVRGPIOState {
+    /*< private >*/
+    SysBusDevice parent_obj;
+
+    /*< public >*/
+    MemoryRegion mmio;
+
+    uint8_t ddr_val;
+    uint8_t port_val;
+
+};
+
+#endif /* AVR_GPIO_H */
--
2.17.1

Add some of these features for AVR GPIO:

- GPIO I/O : PORTx registers
  - Data Direction : DDRx registers
  - DDRx toggling : PINx registers

Following things are not supported yet:
  - MCUR registers

Signed-off-by: Heecheol Yang <heecheol.yang@outlook.com>
---
 hw/avr/Kconfig             |   1 +
 hw/avr/atmega.c            |   7 +-
 hw/avr/atmega.h            |   2 +
 hw/gpio/Kconfig            |   3 +
 hw/gpio/avr_gpio.c         | 136 +++++++++++++++++++++++++++++++++++++
 hw/gpio/meson.build        |   2 +
 include/hw/gpio/avr_gpio.h |  53 +++++++++++++++
 7 files changed, 202 insertions(+), 2 deletions(-)
 create mode 100644 hw/gpio/avr_gpio.c
 create mode 100644 include/hw/gpio/avr_gpio.h

diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
index XXXXXXX..XXXXXXX 100644
--- a/hw/avr/Kconfig
+++ b/hw/avr/Kconfig
@@ -XXX,XX +XXX,XX @@ config AVR_ATMEGA_MCU
     select AVR_TIMER16
     select AVR_USART
     select AVR_POWER
+    select AVR_GPIO
 
 config ARDUINO
     select AVR_ATMEGA_MCU
diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/avr/atmega.c
+++ b/hw/avr/atmega.c
@@ -XXX,XX +XXX,XX @@ static void atmega_realize(DeviceState *dev, Error **errp)
             continue;
         }
         devname = g_strdup_printf("atmega-gpio-%c", 'a' + (char)i);
-        create_unimplemented_device(devname,
-                                    OFFSET_DATA + mc->dev[idx].addr, 3);
+        object_initialize_child(OBJECT(dev), devname, &s->gpio[i],
+                                TYPE_AVR_GPIO);
+        sysbus_realize(SYS_BUS_DEVICE(&s->gpio[i]), &error_abort);
+        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0,
+            OFFSET_DATA + mc->dev[idx].addr);
         g_free(devname);
     }
 
diff --git a/hw/avr/atmega.h b/hw/avr/atmega.h
index XXXXXXX..XXXXXXX 100644
--- a/hw/avr/atmega.h
+++ b/hw/avr/atmega.h
@@ -XXX,XX +XXX,XX @@
 
 #include "hw/char/avr_usart.h"
 #include "hw/timer/avr_timer16.h"
+#include "hw/gpio/avr_gpio.h"
 #include "hw/misc/avr_power.h"
 #include "target/avr/cpu.h"
 #include "qom/object.h"
@@ -XXX,XX +XXX,XX @@ struct AtmegaMcuState {
     DeviceState *io;
     AVRMaskState pwr[POWER_MAX];
     AVRUsartState usart[USART_MAX];
+    AVRGPIOState gpio[GPIO_MAX];
     AVRTimer16State timer[TIMER_MAX];
     uint64_t xtal_freq_hz;
 };
diff --git a/hw/gpio/Kconfig b/hw/gpio/Kconfig
index XXXXXXX..XXXXXXX 100644
--- a/hw/gpio/Kconfig
+++ b/hw/gpio/Kconfig
@@ -XXX,XX +XXX,XX @@ config GPIO_KEY
 
 config SIFIVE_GPIO
     bool
+
+config AVR_GPIO
+    bool
diff --git a/hw/gpio/avr_gpio.c b/hw/gpio/avr_gpio.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/hw/gpio/avr_gpio.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * AVR processors GPIO registers emulation.
+ *
+ * Copyright (C) 2020 Heecheol Yang <heecheol.yang@outlook.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+#include "qemu/osdep.h"
+#include "qemu/log.h"
+#include "qemu/module.h"
+#include "qemu/osdep.h"
+#include "qapi/error.h"
+#include "hw/sysbus.h"
+#include "hw/irq.h"
+#include "hw/gpio/avr_gpio.h"
+#include "hw/qdev-properties.h"
+
+static void avr_gpio_reset(DeviceState *dev)
+{
+    AVRGPIOState *gpio = AVR_GPIO(dev);
+    gpio->reg.pin = 0u;
+    gpio->reg.ddr = 0u;
+    gpio->reg.port = 0u;
+}
+
+static void avr_gpio_write_port(AVRGPIOState *s, uint64_t value)
+{
+    uint8_t pin;
+    uint8_t cur_port_val = s->reg.port;
+    uint8_t cur_ddr_val = s->reg.ddr;
+
+    for (pin = 0u; pin < 8u ; pin++) {
+        uint8_t cur_port_pin_val = cur_port_val & 0x01u;
+        uint8_t cur_ddr_pin_val = cur_ddr_val & 0x01u;
+        uint8_t new_port_pin_val = value & 0x01u;
+
+        if (cur_ddr_pin_val && (cur_port_pin_val != new_port_pin_val)) {
+            qemu_set_irq(s->out[pin], new_port_pin_val);
+        }
+        cur_port_val >>= 1u;
+        cur_ddr_val >>= 1u;
+        value >>= 1u;
+    }
+    s->reg.port = value & s->reg.ddr;
+}
+static uint64_t avr_gpio_read(void *opaque, hwaddr offset, unsigned int size)
+{
+    AVRGPIOState *s = (AVRGPIOState *)opaque;
+    switch (offset) {
+    case GPIO_PIN:
+        return s->reg.pin;
+    case GPIO_DDR:
+        return s->reg.ddr;
+    case GPIO_PORT:
+        return s->reg.port;
+    default:
+        g_assert_not_reached();
+        break;
+    }
+    return 0;
+}
+
+static void avr_gpio_write(void *opaque, hwaddr offset, uint64_t value,
+                                unsigned int size)
+{
+    AVRGPIOState *s = (AVRGPIOState *)opaque;
+    value = value & 0xF;
+    switch (offset) {
+    case GPIO_PIN:
+        s->reg.pin = value;
+        s->reg.port ^= s->reg.pin;
+        break;
+    case GPIO_DDR:
+        s->reg.ddr = value;
+        break;
+    case GPIO_PORT:
+        avr_gpio_write_port(s, value);
+        break;
+    default:
+        g_assert_not_reached();
+        break;
+    }
+}
+
+static const MemoryRegionOps avr_gpio_ops = {
+    .read = avr_gpio_read,
+    .write = avr_gpio_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+};
+
+static void avr_gpio_init(Object *obj)
+{
+    AVRGPIOState *s = AVR_GPIO(obj);
+    qdev_init_gpio_out(DEVICE(obj), s->out, ARRAY_SIZE(s->out));
+    memory_region_init_io(&s->mmio, obj, &avr_gpio_ops, s, TYPE_AVR_GPIO, 3);
+    sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
+}
+static void avr_gpio_realize(DeviceState *dev, Error **errp)
+{
+    /* Do nothing currently */
+}
+
+
+static void avr_gpio_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->reset = avr_gpio_reset;
+    dc->realize = avr_gpio_realize;
+}
+
+static const TypeInfo avr_gpio_info = {
+    .name          = TYPE_AVR_GPIO,
+    .parent        = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(AVRGPIOState),
+    .instance_init = avr_gpio_init,
+    .class_init    = avr_gpio_class_init,
+};
+
+static void avr_gpio_register_types(void)
+{
+    type_register_static(&avr_gpio_info);
+}
+
+type_init(avr_gpio_register_types)
diff --git a/hw/gpio/meson.build b/hw/gpio/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/hw/gpio/meson.build
+++ b/hw/gpio/meson.build
@@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_OMAP', if_true: files('omap_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2835_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files('aspeed_gpio.c'))
 softmmu_ss.add(when: 'CONFIG_SIFIVE_GPIO', if_true: files('sifive_gpio.c'))
+
+softmmu_ss.add(when: 'CONFIG_AVR_GPIO', if_true: files('avr_gpio.c'))
diff --git a/include/hw/gpio/avr_gpio.h b/include/hw/gpio/avr_gpio.h
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/include/hw/gpio/avr_gpio.h
@@ -XXX,XX +XXX,XX @@
+/*
+ * AVR processors GPIO registers definition.
+ *
+ * Copyright (C) 2020 Heecheol Yang <heecheol.yang@outlook.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef AVR_GPIO_H
+#define AVR_GPIO_H
+
+#include "hw/sysbus.h"
+#include "qom/object.h"
+
+/* Offsets of registers. */
+#define GPIO_PIN   0x00
+#define GPIO_DDR   0x01
+#define GPIO_PORT  0x02
+
+#define TYPE_AVR_GPIO "avr-gpio"
+OBJECT_DECLARE_SIMPLE_TYPE(AVRGPIOState, AVR_GPIO)
+#define AVR_GPIO_COUNT 8
+
+struct AVRGPIOState {
+    /*< private >*/
+    SysBusDevice parent_obj;
+
+    /*< public >*/
+    MemoryRegion mmio;
+
+    struct {
+        uint8_t pin;
+        uint8_t ddr;
+        uint8_t port;
+    } reg;
+
+    /* PORTx data changed IRQs */
+    qemu_irq out[8u];
+
+};
+
+#endif /* AVR_GPIO_H */
-- 
2.17.1