> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: 16 September 2025 15:27
> To: Shameer Kolothum <skolothumtho@nvidia.com>
> Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org;
> eric.auger@redhat.com; Jason Gunthorpe <jgg@nvidia.com>; Nicolin Chen
> <nicolinc@nvidia.com>; ddutile@redhat.com; berrange@redhat.com;
> imammedo@redhat.com; Nathan Chen <nathanc@nvidia.com>; Matt Ochs
> <mochs@nvidia.com>; smostafa@google.com; mst@redhat.com;
> marcel.apfelbaum@gmail.com; wangzhou1@hisilicon.com;
> jiangkunkun@huawei.com; jonathan.cameron@huawei.com;
> zhangfei.gao@linaro.org
> Subject: Re: [PATCH v9 00/11] hw/arm/virt: Add support for user creatable
> SMMUv3 device
>
>
> On Fri, 29 Aug 2025 at 09:28, Shameer Kolothum
> <skolothumtho@nvidia.com> wrote:
> >
> > Hi,
> >
> > Changes from v8:
> >
> https://lore.k/
> ernel.org%2Fqemu-devel%2F20250711084749.18300-1-
> shameerali.kolothum.thodi%40huawei.com%2F&data=05%7C02%7Cskolothu
> mtho%40nvidia.com%7Cb353ba5aeb52400076e808ddf52d18d4%7C43083d1
> 5727340c1b7db39efd9ccc17a%7C0%7C0%7C638936296246973267%7CUnkno
> wn%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsI
> lAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> a=d2GPo8T%2BgwLfrfvYg7Zal8JbjpyVk%2BueWdAK1ycvBPU%3D&reserved=0
> >
> > 1.Dropped previous patch #1 as that one is now already in.
> > 2.Rebased and updated DSDT in patch #11 to make bios table tests happy.
> >   The DSDT has changed since Eric's PCI hotplug series work.
> > 3.Added T-by tags from Nicolin. Thanks!.
> >
> > I think this is in a good shape now. Please take a look.
>
> Hi; I've applied this version to target-arm.next. Thanks
> for this work, and also to everybody who has helped out with
> code review and testing on the series.

Thanks!

> >  hw/arm/smmu-common.c                          |  37 +++-
> >  hw/arm/smmuv3.c                               |   2 +
> >  hw/arm/virt-acpi-build.c                      | 201 ++++++++++++++----
> >  hw/arm/virt.c                                 | 111 +++++++---
> >  hw/core/sysbus-fdt.c                          |   3 +
> >  hw/pci-bridge/pci_expander_bridge.c           |   1 -
> >  hw/pci/pci.c                                  |  31 +++
> >  include/hw/arm/smmu-common.h                  |   1 +
> >  include/hw/arm/virt.h                         |   1 +
> >  include/hw/pci/pci.h                          |   2 +
> >  include/hw/pci/pci_bridge.h                   |   1 +
> >  include/hw/pci/pci_bus.h                      |   1 +
> >  qemu-options.hx                               |   7 +
> >  tests/data/acpi/aarch64/virt/DSDT.smmuv3-dev  | Bin 0 -> 10230 bytes
> >  .../data/acpi/aarch64/virt/DSDT.smmuv3-legacy | Bin 0 -> 10230 bytes
> >  tests/data/acpi/aarch64/virt/IORT.smmuv3-dev  | Bin 0 -> 364 bytes
> >  .../data/acpi/aarch64/virt/IORT.smmuv3-legacy | Bin 0 -> 276 bytes
> >  tests/qtest/bios-tables-test.c                |  86 ++++++++
>
> Could I ask you to write a followup documentation patch which
> adds something to docs/system/arm/virt.rst to describe the
> new functionality and give an example of how to use it?

Ok. Will do.

Thanks,
Shameer