RE: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3

Shameer Kolothum posted 33 patches 3 days ago
Only 0 patches received!
RE: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3
Posted by Shameer Kolothum 3 days ago

> -----Original Message-----
> From: Cédric Le Goater <clg@redhat.com>
> Sent: 09 December 2025 10:32
> To: Shameer Kolothum <skolothumtho@nvidia.com>; qemu-
> arm@nongnu.org; qemu-devel@nongnu.org
> Cc: eric.auger@redhat.com; peter.maydell@linaro.org; Jason Gunthorpe
> <jgg@nvidia.com>; Nicolin Chen <nicolinc@nvidia.com>;
> ddutile@redhat.com; berrange@redhat.com; Nathan Chen
> <nathanc@nvidia.com>; Matt Ochs <mochs@nvidia.com>;
> smostafa@google.com; wangzhou1@hisilicon.com;
> jiangkunkun@huawei.com; jonathan.cameron@huawei.com;
> zhangfei.gao@linaro.org; zhenzhong.duan@intel.com; yi.l.liu@intel.com;
> Krishnakant Jaju <kjaju@nvidia.com>
> Subject: Re: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable
> accelerated SMMUv3
> 
[...]

> 
> FYI, I am seeing configure errors :
> 
> The following clauses were found for ARM_SMMUV3_ACCEL
>      select ARM_SMMUV3_ACCEL if ARM_VIRT
>      config ARM_SMMUV3_ACCEL depends on (ARM_SMMUV3 && IOMMUFD)

-    select ARM_SMMUV3_ACCEL
+    imply  ARM_SMMUV3_ACCEL

the above will fix it?

> 
> KconfigDataError: contradiction between clauses when setting
> ARM_SMMUV3_ACCEL

Just curious, how to trigger these errors easily? Any scripts?

Thanks,
Shameer

> 
> Thanks,
> 
> C.

Re: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3
Posted by Cédric Le Goater 2 days, 23 hours ago
On 12/10/25 16:07, Shameer Kolothum wrote:
> 
> 
>> -----Original Message-----
>> From: Cédric Le Goater <clg@redhat.com>
>> Sent: 09 December 2025 10:32
>> To: Shameer Kolothum <skolothumtho@nvidia.com>; qemu-
>> arm@nongnu.org; qemu-devel@nongnu.org
>> Cc: eric.auger@redhat.com; peter.maydell@linaro.org; Jason Gunthorpe
>> <jgg@nvidia.com>; Nicolin Chen <nicolinc@nvidia.com>;
>> ddutile@redhat.com; berrange@redhat.com; Nathan Chen
>> <nathanc@nvidia.com>; Matt Ochs <mochs@nvidia.com>;
>> smostafa@google.com; wangzhou1@hisilicon.com;
>> jiangkunkun@huawei.com; jonathan.cameron@huawei.com;
>> zhangfei.gao@linaro.org; zhenzhong.duan@intel.com; yi.l.liu@intel.com;
>> Krishnakant Jaju <kjaju@nvidia.com>
>> Subject: Re: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable
>> accelerated SMMUv3
>>
> [...]
> 
>>
>> FYI, I am seeing configure errors :
>>
>> The following clauses were found for ARM_SMMUV3_ACCEL
>>       select ARM_SMMUV3_ACCEL if ARM_VIRT
>>       config ARM_SMMUV3_ACCEL depends on (ARM_SMMUV3 && IOMMUFD)
> 
> -    select ARM_SMMUV3_ACCEL
> +    imply  ARM_SMMUV3_ACCEL
> 
> the above will fix it?

No. I would propose :

@@ -12,7 +12,6 @@ config ARM_VIRT
      select ARM_GIC
      select ACPI
      select ARM_SMMUV3
-    select ARM_SMMUV3_ACCEL
      select GPIO_KEY
      select DEVICE_TREE
      select FW_CFG_DMA
@@ -627,12 +626,13 @@ config FSL_IMX8MP_EVK
      depends on TCG
      select FSL_IMX8MP
  
-config ARM_SMMUV3
+config ARM_SMMUV3_ACCEL
      bool
+    depends on ARM_SMMUV3
  
-config ARM_SMMUV3_ACCEL
+config ARM_SMMUV3
      bool
-    depends on ARM_SMMUV3 && IOMMUFD
+    select ARM_SMMUV3_ACCEL if IOMMUFD
  
  config FSL_IMX6UL
      bool

>>
>> KconfigDataError: contradiction between clauses when setting
>> ARM_SMMUV3_ACCEL
> 
> Just curious, how to trigger these errors easily? Any scripts?
Try the windows build :

   ../configure --cross-prefix=x86_64-w64-mingw32- \
     --disable-sdl \
     --prefix=/path/to/install-mingw64 \
     --target-list=aarch64-softmmu,ppc64-softmmu,x86_64-softmmu,s390x-softmmu \
     --disable-docs

problems such as :

../hw/arm/smmuv3-accel.h:14:10: fatal error: linux/iommufd.h: No such file or directory
    14 | #include <linux/iommufd.h>
       |          ^~~~~~~~~~~~~~~~~

should be fixed too.

Thanks,

C.


Re: [PATCH v6 00/33] hw/arm/virt: Add support for user-creatable accelerated SMMUv3
Posted by Eric Auger 2 days, 23 hours ago

On 12/10/25 5:07 PM, Cédric Le Goater wrote:
> On 12/10/25 16:07, Shameer Kolothum wrote:
>>
>>
>>> -----Original Message-----
>>> From: Cédric Le Goater <clg@redhat.com>
>>> Sent: 09 December 2025 10:32
>>> To: Shameer Kolothum <skolothumtho@nvidia.com>; qemu-
>>> arm@nongnu.org; qemu-devel@nongnu.org
>>> Cc: eric.auger@redhat.com; peter.maydell@linaro.org; Jason Gunthorpe
>>> <jgg@nvidia.com>; Nicolin Chen <nicolinc@nvidia.com>;
>>> ddutile@redhat.com; berrange@redhat.com; Nathan Chen
>>> <nathanc@nvidia.com>; Matt Ochs <mochs@nvidia.com>;
>>> smostafa@google.com; wangzhou1@hisilicon.com;
>>> jiangkunkun@huawei.com; jonathan.cameron@huawei.com;
>>> zhangfei.gao@linaro.org; zhenzhong.duan@intel.com; yi.l.liu@intel.com;
>>> Krishnakant Jaju <kjaju@nvidia.com>
>>> Subject: Re: [PATCH v6 00/33] hw/arm/virt: Add support for
>>> user-creatable
>>> accelerated SMMUv3
>>>
>> [...]
>>
>>>
>>> FYI, I am seeing configure errors :
>>>
>>> The following clauses were found for ARM_SMMUV3_ACCEL
>>>       select ARM_SMMUV3_ACCEL if ARM_VIRT
>>>       config ARM_SMMUV3_ACCEL depends on (ARM_SMMUV3 && IOMMUFD)
>>
>> -    select ARM_SMMUV3_ACCEL
>> +    imply  ARM_SMMUV3_ACCEL
>>
>> the above will fix it?
>
> No. I would propose :
>
> @@ -12,7 +12,6 @@ config ARM_VIRT
>      select ARM_GIC
>      select ACPI
>      select ARM_SMMUV3
> -    select ARM_SMMUV3_ACCEL
>      select GPIO_KEY
>      select DEVICE_TREE
>      select FW_CFG_DMA
> @@ -627,12 +626,13 @@ config FSL_IMX8MP_EVK
>      depends on TCG
>      select FSL_IMX8MP
>  
> -config ARM_SMMUV3
> +config ARM_SMMUV3_ACCEL
>      bool
> +    depends on ARM_SMMUV3
>  
> -config ARM_SMMUV3_ACCEL
> +config ARM_SMMUV3
>      bool
> -    depends on ARM_SMMUV3 && IOMMUFD
> +    select ARM_SMMUV3_ACCEL if IOMMUFD 

Zhenzhong has a variant in

https://lore.kernel.org/all/20251117093729.1121324-10-zhenzhong.duan@intel.com/

I guess it also works

Eric
>  
>  config FSL_IMX6UL
>      bool
>
>>>
>>> KconfigDataError: contradiction between clauses when setting
>>> ARM_SMMUV3_ACCEL
>>
>> Just curious, how to trigger these errors easily? Any scripts?
> Try the windows build :
>
>   ../configure --cross-prefix=x86_64-w64-mingw32- \
>     --disable-sdl \
>     --prefix=/path/to/install-mingw64 \
>    
> --target-list=aarch64-softmmu,ppc64-softmmu,x86_64-softmmu,s390x-softmmu
> \
>     --disable-docs
>
> problems such as :
>
> ../hw/arm/smmuv3-accel.h:14:10: fatal error: linux/iommufd.h: No such
> file or directory
>    14 | #include <linux/iommufd.h>
>       |          ^~~~~~~~~~~~~~~~~
>
> should be fixed too.
>
> Thanks,
>
> C.
>