Make some structure static

[PATCH] Make some structure static

Posted by Frediano Ziglio 8 months, 4 weeks ago

Not used outside C module.

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 hw/vfio/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 4fa387f043..a1522a011a 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2558,7 +2558,7 @@ static bool vfio_display_migration_needed(void *opaque)
         (vdev->ramfb_migrate == ON_OFF_AUTO_AUTO && vdev->enable_ramfb);
 }

-const VMStateDescription vmstate_vfio_display = {
+static const VMStateDescription vmstate_vfio_display = {
     .name = "VFIOPCIDevice/VFIODisplay",
     .version_id = 1,
     .minimum_version_id = 1,
@@ -2570,7 +2570,7 @@ const VMStateDescription vmstate_vfio_display = {
     }
 };

-const VMStateDescription vmstate_vfio_pci_config = {
+static const VMStateDescription vmstate_vfio_pci_config = {
     .name = "VFIOPCIDevice",
     .version_id = 1,
     .minimum_version_id = 1,
-- 
2.34.1

Re: [PATCH] Make some structure static

Posted by Michael Tokarev 8 months, 3 weeks ago

01.03.2024 21:56, Frediano Ziglio :
> Not used outside C module.
Applied to trivial-patches (with subject fixup)

/mjt

Re: [PATCH] Make some structure static

Posted by Michael Tokarev 8 months, 4 weeks ago

01.03.2024 21:56, Frediano Ziglio wrote:
> Not used outside C module.

Please add a sensible subject prefix, like "hw/vfio/pci.c: ".

With that,

Revieved-by: Michael Tokarev <mjt@tls.msk.ru>

This is a good candidate for trivial-patches@ too (Cc'd).

/mjt

> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 4fa387f043..a1522a011a 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2558,7 +2558,7 @@ static bool vfio_display_migration_needed(void *opaque)
>           (vdev->ramfb_migrate == ON_OFF_AUTO_AUTO && vdev->enable_ramfb);
>   }
> 
> -const VMStateDescription vmstate_vfio_display = {
> +static const VMStateDescription vmstate_vfio_display = {
>       .name = "VFIOPCIDevice/VFIODisplay",
>       .version_id = 1,
>       .minimum_version_id = 1,
> @@ -2570,7 +2570,7 @@ const VMStateDescription vmstate_vfio_display = {
>       }
>   };
> 
> -const VMStateDescription vmstate_vfio_pci_config = {
> +static const VMStateDescription vmstate_vfio_pci_config = {
>       .name = "VFIOPCIDevice",
>       .version_id = 1,
>       .minimum_version_id = 1,

Re: [PATCH] Make some structure static

Posted by Richard Henderson 8 months, 4 weeks ago

On 3/1/24 08:56, Frediano Ziglio wrote:
> Not used outside C module.
> 
> Signed-off-by: Frediano Ziglio<frediano.ziglio@cloud.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] Make some structure static

Posted by Philippe Mathieu-Daudé 8 months, 4 weeks ago

On 1/3/24 19:56, Frediano Ziglio wrote:
> Not used outside C module.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>   hw/vfio/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>