hw/input/hid: Add support for keys of jp106 keyboard.

[PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

Posted by Katsuhiro Ueno 4 years, 9 months ago

Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
RO, and YEN.  Before this commit, these keys did not work as expected
when a jp106 keyboard was connected to the guest as a usb-kbd device.

Signed-off-by: Katsuhiro Ueno <uenobk@gmail.com>
---
 hw/input/hid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/input/hid.c b/hw/input/hid.c
index e1d2e46083..8aab0521f4 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -51,8 +51,8 @@ static const uint8_t hid_usage_keys[0x100] = {
     0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
     0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65,
+    0x88, 0x00, 0x00, 0x87, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x8a, 0x00, 0x8b, 0x00, 0x89, 0xe7, 0x65,

     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-- 
2.24.3 (Apple Git-128)

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

Posted by Katsuhiro Ueno 4 years, 8 months ago

Ping.

2021-04-27 11:02 Katsuhiro Ueno <uenobk@gmail.com>:
>
> Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
> RO, and YEN.  Before this commit, these keys did not work as expected
> when a jp106 keyboard was connected to the guest as a usb-kbd device.
>
> Signed-off-by: Katsuhiro Ueno <uenobk@gmail.com>
> ---
>  hw/input/hid.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/input/hid.c b/hw/input/hid.c
> index e1d2e46083..8aab0521f4 100644
> --- a/hw/input/hid.c
> +++ b/hw/input/hid.c
> @@ -51,8 +51,8 @@ static const uint8_t hid_usage_keys[0x100] = {
>      0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
>      0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
>      0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
> -    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> -    0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65,
> +    0x88, 0x00, 0x00, 0x87, 0x00, 0x00, 0x00, 0x00,
> +    0x00, 0x8a, 0x00, 0x8b, 0x00, 0x89, 0xe7, 0x65,
>
>      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> --
> 2.24.3 (Apple Git-128)

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

Posted by Laurent Vivier 4 years, 8 months ago

Le 13/05/2021 à 08:11, Katsuhiro Ueno a écrit :
> Ping.

cc Gerd

> 2021-04-27 11:02 Katsuhiro Ueno <uenobk@gmail.com>:
>>
>> Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
>> RO, and YEN.  Before this commit, these keys did not work as expected
>> when a jp106 keyboard was connected to the guest as a usb-kbd device.
>>
>> Signed-off-by: Katsuhiro Ueno <uenobk@gmail.com>
>> ---
>>  hw/input/hid.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/input/hid.c b/hw/input/hid.c
>> index e1d2e46083..8aab0521f4 100644
>> --- a/hw/input/hid.c
>> +++ b/hw/input/hid.c
>> @@ -51,8 +51,8 @@ static const uint8_t hid_usage_keys[0x100] = {
>>      0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
>>      0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
>>      0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
>> -    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>> -    0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65,
>> +    0x88, 0x00, 0x00, 0x87, 0x00, 0x00, 0x00, 0x00,
>> +    0x00, 0x8a, 0x00, 0x8b, 0x00, 0x89, 0xe7, 0x65,
>>
>>      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>>      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>> --
>> 2.24.3 (Apple Git-128)
>

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

Posted by Gerd Hoffmann 4 years, 8 months ago

On Thu, May 13, 2021 at 09:53:34AM +0200, Laurent Vivier wrote:
> Le 13/05/2021 à 08:11, Katsuhiro Ueno a écrit :
> > Ping.
> 
> cc Gerd

Added to usb queue.

thanks,
  Gerd