hw/riscv: Update comment for qtest check in riscv_find_firmware()

[PATCH] hw/riscv: Update comment for qtest check in riscv_find_firmware()

Posted by Bin Meng 3 years, 4 months ago

From: Bin Meng <bmeng.cn@gmail.com>

Since commit 4211fc553234 ("roms/opensbi: Remove ELF images"), the
comment for qtest check in riscv_find_firmware() is out of date.
Update it to reflect the latest status.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 hw/riscv/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index 1ae7596873..f6e8eafa28 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@ -111,8 +111,8 @@ char *riscv_find_firmware(const char *firmware_filename)
     if (filename == NULL) {
         if (!qtest_enabled()) {
             /*
-             * We only ship plain binary bios images in the QEMU source.
-             * With Spike machine that uses ELF images as the default bios,
+             * We only ship OpenSBI binary bios images in the QEMU source.
+             * For machines that use images other than the default bios,
              * running QEMU test will complain hence let's suppress the error
              * report for QEMU testing.
              */
-- 
2.25.1

Re: [PATCH] hw/riscv: Update comment for qtest check in riscv_find_firmware()

Posted by Alistair Francis 3 years, 4 months ago

On Sun, Oct 9, 2022 at 11:04 PM Bin Meng <bmeng@outlook.com> wrote:
>
> From: Bin Meng <bmeng.cn@gmail.com>
>
> Since commit 4211fc553234 ("roms/opensbi: Remove ELF images"), the
> comment for qtest check in riscv_find_firmware() is out of date.
> Update it to reflect the latest status.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>
>  hw/riscv/boot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index 1ae7596873..f6e8eafa28 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -111,8 +111,8 @@ char *riscv_find_firmware(const char *firmware_filename)
>      if (filename == NULL) {
>          if (!qtest_enabled()) {
>              /*
> -             * We only ship plain binary bios images in the QEMU source.
> -             * With Spike machine that uses ELF images as the default bios,
> +             * We only ship OpenSBI binary bios images in the QEMU source.
> +             * For machines that use images other than the default bios,
>               * running QEMU test will complain hence let's suppress the error
>               * report for QEMU testing.
>               */
> --
> 2.25.1
>
>

Re: [PATCH] hw/riscv: Update comment for qtest check in riscv_find_firmware()

Posted by Alistair Francis 3 years, 4 months ago

On Sun, Oct 9, 2022 at 11:04 PM Bin Meng <bmeng@outlook.com> wrote:
>
> From: Bin Meng <bmeng.cn@gmail.com>
>
> Since commit 4211fc553234 ("roms/opensbi: Remove ELF images"), the
> comment for qtest check in riscv_find_firmware() is out of date.
> Update it to reflect the latest status.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
>  hw/riscv/boot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index 1ae7596873..f6e8eafa28 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -111,8 +111,8 @@ char *riscv_find_firmware(const char *firmware_filename)
>      if (filename == NULL) {
>          if (!qtest_enabled()) {
>              /*
> -             * We only ship plain binary bios images in the QEMU source.
> -             * With Spike machine that uses ELF images as the default bios,
> +             * We only ship OpenSBI binary bios images in the QEMU source.
> +             * For machines that use images other than the default bios,
>               * running QEMU test will complain hence let's suppress the error
>               * report for QEMU testing.
>               */
> --
> 2.25.1
>
>