[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave

Chen Zhang via Qemu-devel posted 2 patches 4 years, 10 months ago
Test s390x passed
Test checkpatch failed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
ui/cocoa.m | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 47 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by Chen Zhang via Qemu-devel 4 years, 10 months ago
The following patches fixed issues of absolute and relative input devices 
on macOS Mojave.

Chen Zhang (2):
  ui/cocoa: Fix absolute input device grabbing issue on Mojave
  ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input
    device

 ui/cocoa.m | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 47 insertions(+), 3 deletions(-)

-- 
2.21.0


Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by no-reply@patchew.org 4 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Type: series
Message-id: B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com -> patchew/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com
Switched to a new branch 'test'
0f454224fc ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device
808e94256f ui/cocoa: Fix absolute input device grabbing issue on Mojave

=== OUTPUT BEGIN ===
1/2 Checking commit 808e94256fc5 (ui/cocoa: Fix absolute input device grabbing issue on Mojave)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Chen Zhang via Qemu-devel <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 61 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 0f454224fcd9 (ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Chen Zhang via Qemu-devel <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 13 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by Peter Maydell 4 years, 10 months ago
On Tue, 4 Jun 2019 at 10:34, Chen Zhang <tgfbeta@me.com> wrote:
>
> The following patches fixed issues of absolute and relative input devices
> on macOS Mojave.
>
> Chen Zhang (2):
>   ui/cocoa: Fix absolute input device grabbing issue on Mojave
>   ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input
>     device
>
>  ui/cocoa.m | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 47 insertions(+), 3 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
I'll apply these to master some time this week.

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by Chen Zhang via Qemu-devel 4 years, 10 months ago
Thank you and best regards.

> On Jun 12, 2019, at 6:39 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> 
> On Tue, 4 Jun 2019 at 10:34, Chen Zhang <tgfbeta@me.com> wrote:
>> 
>> The following patches fixed issues of absolute and relative input devices
>> on macOS Mojave.
>> 
>> Chen Zhang (2):
>>  ui/cocoa: Fix absolute input device grabbing issue on Mojave
>>  ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input
>>    device
>> 
>> ui/cocoa.m | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 47 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> I'll apply these to master some time this week.
> 
> thanks
> -- PMM


Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by Peter Maydell 4 years, 10 months ago
On Wed, 12 Jun 2019 at 11:39, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 4 Jun 2019 at 10:34, Chen Zhang <tgfbeta@me.com> wrote:
> >
> > The following patches fixed issues of absolute and relative input devices
> > on macOS Mojave.
> >
> > Chen Zhang (2):
> >   ui/cocoa: Fix absolute input device grabbing issue on Mojave
> >   ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input
> >     device
> >
> >  ui/cocoa.m | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
> >  1 file changed, 47 insertions(+), 3 deletions(-)
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> I'll apply these to master some time this week.

Now applied, thanks.

-- PMM

[Qemu-devel] A patch has been merged in QEMU: [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by no-reply@patchew.org 4 years, 10 months ago
Congratulations, [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave was merged by the QEMU
maintainers.

http://next.patchew.org/QEMU/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com/
[Qemu-devel] A patch has been merged in QEMU: [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave
Posted by no-reply@patchew.org 4 years, 10 months ago
Congratulations, [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave was merged by the QEMU
maintainers.

http://next.patchew.org/QEMU/B3540B0C-9A71-4733-8109-11B0DC7A17D2@me.com/