ping

-----Original Message-----
From: Gaurav Sharma <gaurav.sharma_7@nxp.com> 
Sent: 19 November 2025 18:30
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com; peter.maydell@linaro.org; Gaurav Sharma <gaurav.sharma_7@nxp.com>
Subject: [PATCHv3 00/13] Adding comprehensive support for i.MX8MM EVK board

Changes in v3:
- Minor documentation change - Added KVM Acceleration section in docs/system/arm/imx8mm-evk.rst
 
Changes in v2:
- Fixed the DTB offset in functional testing script test_imx8mm_evk.py
  and preserved alphabetical order of machine names in tests/functional/aarch64/meson.build
- Fixed a typo and updated the documentation
- Modified structures type to static const in fsl-imx8mm.c wherever
  applicable.
- Added CSI and DSI nodes to the nodes_to_remove list in imx8mm-evk.c. This
  is needed because the default DTB in the iMX LF BSP images have CSI
  and DSI enabled. Developers/Hobbyists using these BSP images will
  observe CSI and DSI crash logs on the console since these are unimplemented.
  With this change, both debian and iMX LF images will boot up without any issues.

Changes in v1:

This patch series adds support for the NXP i.MX8MM EVK (Evaluation Kit) board to QEMU, enabling emulation of this ARM Cortex-A53 based development platform.

The series includes:

1. Core peripheral support (CCM clock controller, Analog module) 2. GPT(General Purpose Timer) and WDT(Watchdog Timer) Emulation support 3. GPIO,I2C,SPI,USDHC and USB Emulation support 4. PCIe and ENET Controller Emulation support 5. Documentation and functional test included

Key features ported:
- Basic boot support with Linux
- UART console for serial communication
- Interrupt handling
- Clock and power management infrastructure

Testing:
- Linux kernel boots to console

Signed-off-by: Gaurav Sharma <gaurav.sharma_7@nxp.com>

Gaurav Sharma (13):
  hw/arm: Add the i.MX 8MM EVK(Evaluation Kit) board
  hw/arm/fsl-imx8mm: Implemented CCM(Clock Control Module) and Analog IP
  hw/arm/fsl-imx8mm: Implemented support for SNVS
  hw/arm/fsl-imx8mm: Adding support for USDHC storage controllers
  hw/arm/fsl-imx8mm: Add PCIe support
  hw/arm/fsl-imx8mm: Add GPIO controllers
  hw/arm/fsl-imx8mm: Adding support for I2C emulation
  hw/arm/fsl-imx8mm: Adding support for SPI controller
  hw/arm/fsl-imx8mm: Adding support for Watchdog Timers
  hw/arm/fsl-imx8mm: Adding support for General Purpose Timers
  hw/arm/fsl-imx8mm: Adding support for ENET ethernet controller
  hw/arm/fsl-imx8mm: Adding support for USB controller
  hw/arm/fsl-imx8mm: Adding functional testing of iMX8MM emulation

 docs/system/arm/imx8mm-evk.rst              |  79 +++
 docs/system/target-arm.rst                  |   1 +
 hw/arm/Kconfig                              |  24 +
 hw/arm/fsl-imx8mm.c                         | 687 ++++++++++++++++++++
 hw/arm/imx8mm-evk.c                         | 127 ++++
 hw/arm/meson.build                          |   2 +
 hw/misc/Kconfig                             |   6 +
 hw/misc/imx8mm_analog.c                     | 160 +++++
 hw/misc/imx8mm_ccm.c                        | 175 +++++
 hw/misc/meson.build                         |   2 +
 hw/timer/imx_gpt.c                          |  26 +
 include/hw/arm/fsl-imx8mm.h                 | 240 +++++++
 include/hw/misc/imx8mm_analog.h             |  81 +++
 include/hw/misc/imx8mm_ccm.h                |  30 +
 include/hw/timer/imx_gpt.h                  |   2 +
 tests/functional/aarch64/meson.build        |   2 +
 tests/functional/aarch64/test_imx8mm_evk.py |  67 ++
 17 files changed, 1711 insertions(+)
 create mode 100644 docs/system/arm/imx8mm-evk.rst  create mode 100644 hw/arm/fsl-imx8mm.c  create mode 100644 hw/arm/imx8mm-evk.c  create mode 100644 hw/misc/imx8mm_analog.c  create mode 100644 hw/misc/imx8mm_ccm.c  create mode 100644 include/hw/arm/fsl-imx8mm.h  create mode 100644 include/hw/misc/imx8mm_analog.h  create mode 100644 include/hw/misc/imx8mm_ccm.h  create mode 100755 tests/functional/aarch64/test_imx8mm_evk.py

--
2.34.1

On Tue, 25 Nov 2025 at 05:22, Gaurav Sharma <gaurav.sharma_7@nxp.com> wrote:
>
> ping
>
> -----Original Message-----
> From: Gaurav Sharma <gaurav.sharma_7@nxp.com>
> Sent: 19 November 2025 18:30
> To: qemu-devel@nongnu.org
> Cc: pbonzini@redhat.com; peter.maydell@linaro.org; Gaurav Sharma <gaurav.sharma_7@nxp.com>
> Subject: [PATCHv3 00/13] Adding comprehensive support for i.MX8MM EVK board
>
> Changes in v3:
> - Minor documentation change - Added KVM Acceleration section in docs/system/arm/imx8mm-evk.rst
>
> Changes in v2:
> - Fixed the DTB offset in functional testing script test_imx8mm_evk.py
>   and preserved alphabetical order of machine names in tests/functional/aarch64/meson.build
> - Fixed a typo and updated the documentation
> - Modified structures type to static const in fsl-imx8mm.c wherever
>   applicable.
> - Added CSI and DSI nodes to the nodes_to_remove list in imx8mm-evk.c. This
>   is needed because the default DTB in the iMX LF BSP images have CSI
>   and DSI enabled. Developers/Hobbyists using these BSP images will
>   observe CSI and DSI crash logs on the console since these are unimplemented.
>   With this change, both debian and iMX LF images will boot up without any issues.

At least some of these patches were reviewed by Philippe in v1.
Did they all change?

The way this is supposed to work is that where a patch has been
reviewed and hasn't changed in a followup respin of a patchset,
you keep the reviewed-by tag, which tells us that we don't need
to repeat that bit of the review. More detail:

https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review

thanks
-- PMM

> At least some of these patches were reviewed by Philippe in v1.
> Did they all change?
>
> The way this is supposed to work is that where a patch has been reviewed
> and hasn't changed in a followup respin of a patchset, you keep the
> reviewed-by tag, which tells us that we don't need to repeat that bit of the
> review. More detail:
>
> https://www.q/
> emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a-patch.html%23proper-
> use-of-reviewed-by-tags-can-aid-
> review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334
> 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki
> OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy
> fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH
> E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0
>

The v1 patch files reviewed by Philippe changed. Structure type was changed in all those reviewed patches that's why reviewed-by tag was not retained in the follow-up revisions.

On Tue, 2 Dec 2025 at 05:19, Gaurav Sharma <gaurav.sharma_7@nxp.com> wrote:
>
>
> > At least some of these patches were reviewed by Philippe in v1.
> > Did they all change?
> >
> > The way this is supposed to work is that where a patch has been reviewed
> > and hasn't changed in a followup respin of a patchset, you keep the
> > reviewed-by tag, which tells us that we don't need to repeat that bit of the
> > review. More detail:
> >
> > https://www.q/
> > emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a-patch.html%23proper-
> > use-of-reviewed-by-tags-can-aid-
> > review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334
> > 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> > 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki
> > OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy
> > fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH
> > E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0
> >
>
> The v1 patch files reviewed by Philippe changed. Structure type was changed in all those reviewed patches that's why reviewed-by tag was not retained in the follow-up revisions.

Generally, if somebody says "do this trivial change X"
and then gives an R-by tag, they mean "if you do this
thing and nothing else then you can add my tag to it".

thanks
-- PMM

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: 02 December 2025 15:14
> To: Gaurav Sharma <gaurav.sharma_7@nxp.com>
> Cc: qemu-devel@nongnu.org; pbonzini@redhat.com
> Subject: Re: [EXT] Re: [PATCHv3 00/13] Adding comprehensive support for
> i.MX8MM EVK board
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Tue, 2 Dec 2025 at 05:19, Gaurav Sharma <gaurav.sharma_7@nxp.com>
> wrote:
> >
> >
> > > At least some of these patches were reviewed by Philippe in v1.
> > > Did they all change?
> > >
> > > The way this is supposed to work is that where a patch has been
> > > reviewed and hasn't changed in a followup respin of a patchset, you
> > > keep the reviewed-by tag, which tells us that we don't need to
> > > repeat that bit of the review. More detail:
> > >
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > >
> w.q%2F&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C5426ed39023f
> 453ab8
> > >
> 5908de31875150%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 900265
> > >
> 4453250191%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIl
> YiOiIwL
> > >
> jAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7
> C%7
> > >
> C%7C&sdata=5MI2GF5C0W%2Fwuyoysgtn4m%2BZQSMrEALcRtZhTxjchcs%3D
> &reserv
> > > ed=0
> > > emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a-
> patch.html%23proper-
> > > use-of-reviewed-by-tags-can-aid-
> > >
> review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334
> > >
> 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> > >
> 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki
> > >
> OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy
> > >
> fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH
> > > E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0
> > >
> >
> > The v1 patch files reviewed by Philippe changed. Structure type was
> changed in all those reviewed patches that's why reviewed-by tag was not
> retained in the follow-up revisions.
> 
> Generally, if somebody says "do this trivial change X"
> and then gives an R-by tag, they mean "if you do this thing and nothing else
> then you can add my tag to it".
> 

Got it.