[PATCH] SMBIOS: fix long lines

Michael S. Tsirkin posted 1 patch 1 month, 2 weeks ago
Failed in applying to current master (apply log)
There is a newer version of this series
hw/smbios/smbios.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
[PATCH] SMBIOS: fix long lines
Posted by Michael S. Tsirkin 1 month, 2 weeks ago
Break up long lines to fit under 80/90 char limit.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/smbios/smbios.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index e3d5d8f2e2..949c2d74a1 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -1592,12 +1592,15 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
             t = g_new0(struct type9_instance, 1);
             save_opt(&t->slot_designation, opts, "slot_designation");
             t->slot_type = qemu_opt_get_number(opts, "slot_type", 0);
-            t->slot_data_bus_width = qemu_opt_get_number(opts, "slot_data_bus_width", 0);
+            t->slot_data_bus_width =
+                qemu_opt_get_number(opts, "slot_data_bus_width", 0);
             t->current_usage = qemu_opt_get_number(opts, "current_usage", 0);
             t->slot_length = qemu_opt_get_number(opts, "slot_length", 0);
             t->slot_id = qemu_opt_get_number(opts, "slot_id", 0);
-            t->slot_characteristics1 = qemu_opt_get_number(opts, "slot_characteristics1", 0);
-            t->slot_characteristics2 = qemu_opt_get_number(opts, "slot_characteristics2", 0);
+            t->slot_characteristics1 =
+                qemu_opt_get_number(opts, "slot_characteristics1", 0);
+            t->slot_characteristics2 =
+                qemu_opt_get_number(opts, "slot_characteristics2", 0);
             save_opt(&t->pcidev, opts, "pcidev");
             QTAILQ_INSERT_TAIL(&type9, t, next);
             return;
-- 
MST
Re: [PATCH] SMBIOS: fix long lines
Posted by Ani Sinha 1 month, 2 weeks ago

> On 13-Mar-2024, at 03:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> Break up long lines to fit under 80/90 char limit.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Ani Sinha <anisinha@redhat.com>

> ---
> hw/smbios/smbios.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index e3d5d8f2e2..949c2d74a1 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -1592,12 +1592,15 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
>             t = g_new0(struct type9_instance, 1);
>             save_opt(&t->slot_designation, opts, "slot_designation");
>             t->slot_type = qemu_opt_get_number(opts, "slot_type", 0);
> -            t->slot_data_bus_width = qemu_opt_get_number(opts, "slot_data_bus_width", 0);
> +            t->slot_data_bus_width =
> +                qemu_opt_get_number(opts, "slot_data_bus_width", 0);
>             t->current_usage = qemu_opt_get_number(opts, "current_usage", 0);
>             t->slot_length = qemu_opt_get_number(opts, "slot_length", 0);
>             t->slot_id = qemu_opt_get_number(opts, "slot_id", 0);
> -            t->slot_characteristics1 = qemu_opt_get_number(opts, "slot_characteristics1", 0);
> -            t->slot_characteristics2 = qemu_opt_get_number(opts, "slot_characteristics2", 0);
> +            t->slot_characteristics1 =
> +                qemu_opt_get_number(opts, "slot_characteristics1", 0);
> +            t->slot_characteristics2 =
> +                qemu_opt_get_number(opts, "slot_characteristics2", 0);
>             save_opt(&t->pcidev, opts, "pcidev");
>             QTAILQ_INSERT_TAIL(&type9, t, next);
>             return;
> -- 
> MST
>