[v2] configure: Define target access alignment in configure

[Qemu-devel] [PATCH v2 0/2] configure: Define target access alignment in configure

tony.nguyen@bt.com posted 2 patches 4 years, 9 months ago

Diff against v1 v3 v4 v4
Download series mbox

Test docker-clang@ubuntu passed

Test s390x passed

Test asan passed

Test docker-mingw@fedora passed

Test FreeBSD passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/945056df7ff54ce6b272dce64721d916@tpw09926dag18e.domain1.systemhost.net

Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Richard Henderson <rth@twiddle.net>, Max Filippov <jcmvbkbc@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Aurelien Jarno <aurelien@aurel32.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Eduardo Habkost <ehabkost@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>

There is a newer version of this series

configure             | 12 ++++++++++--
include/exec/poison.h |  1 +
include/qom/cpu.h     |  2 +-
target/alpha/cpu.h    |  2 --
target/hppa/cpu.h     |  1 -
target/mips/cpu.h     |  2 --
target/sh4/cpu.h      |  2 --
target/sparc/cpu.h    |  2 --
target/xtensa/cpu.h   |  2 --
tcg/tcg.c             |  2 +-
tcg/tcg.h             |  8 +++++---
11 files changed, 18 insertions(+), 18 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] configure: Define target access alignment in configure

Posted by tony.nguyen@bt.com 4 years, 9 months ago

Move the define of target access alignment earlier from
target/foo/cpu.h to configure.

Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp
is now accelerator independent MemOp"

Analysed target/foo/cpu.h for more candidates to define earlier but                         
did not spot any other straight forward predicates.

Possible future clean ups:
- TCG_GUEST_DEFAULT_MO and TCG_TARGET_DEFAULT_MO seems like duplicates
- TARGET_INSN_START_EXTRA_WORDS 1 seems redundant as ifndef value is 1

v2:
- split cosmetic changes into separate patch
- cc corresponding maintainers

Thanks to Aleksandar Markovic for the guide in v1 =)

Tony Nguyen (2):
  configure: Define TARGET_ALIGNED_ONLY earlier
  configure: Cosmetic yes to "yes" for consistency

 configure             | 12 ++++++++++--
 include/exec/poison.h |  1 +
 include/qom/cpu.h     |  2 +-
 target/alpha/cpu.h    |  2 --
 target/hppa/cpu.h     |  1 -
 target/mips/cpu.h     |  2 --
 target/sh4/cpu.h      |  2 --
 target/sparc/cpu.h    |  2 --
 target/xtensa/cpu.h   |  2 --
 tcg/tcg.c             |  2 +-
 tcg/tcg.h             |  8 +++++---
 11 files changed, 18 insertions(+), 18 deletions(-)

-- 
1.8.3.1