[PATCH] vhost-user: fix SET_MEM_TABLE number of regions

Michael S. Tsirkin posted 1 patch 1 week, 4 days ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
docs/interop/vhost-user.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] vhost-user: fix SET_MEM_TABLE number of regions
Posted by Michael S. Tsirkin 1 week, 4 days ago
vhost-user.rst says the legacy SET_MEM_TABLE contains 8 regions, but
this does not make sense - we have a num_regions field for this.
And it is not true in practice: if QEMU has less, it sends less.

The incorrect wording was introduced, without explanation, as
part of an editorial cleanup. Probably an oversight.

It's really "up to 8".

Fixes: 1958bb23b9 ("docs: fix vhost-user protocol doc")
Cc: luzhixing12345 <luzhixing12345@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 docs/interop/vhost-user.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index c1e02ff7e9..488214a306 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -248,7 +248,7 @@ Multiple Memory regions description
 
 :padding: 32-bit
 
-:regions: regions field contains 8 regions of type :ref:`Memory region description <memory_region_description>`.
+:regions: regions field contains up to 8 regions of type :ref:`Memory region description <memory_region_description>`.
 
 Log description
 ^^^^^^^^^^^^^^^
-- 
MST
Re: [PATCH] vhost-user: fix SET_MEM_TABLE number of regions
Posted by Stefano Garzarella 1 week, 2 days ago
On Tue, Sep 15, 2026 at 06:44:01AM -0400, Michael S. Tsirkin wrote:
>vhost-user.rst says the legacy SET_MEM_TABLE contains 8 regions, but
>this does not make sense - we have a num_regions field for this.
>And it is not true in practice: if QEMU has less, it sends less.
>
>The incorrect wording was introduced, without explanation, as
>part of an editorial cleanup. Probably an oversight.
>
>It's really "up to 8".
>
>Fixes: 1958bb23b9 ("docs: fix vhost-user protocol doc")

I can't find this SHA, I guess the right one is b87ea798eb

The change LGTM, so with that fixed:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>Cc: luzhixing12345 <luzhixing12345@gmail.com>
>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>---
> docs/interop/vhost-user.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
>index c1e02ff7e9..488214a306 100644
>--- a/docs/interop/vhost-user.rst
>+++ b/docs/interop/vhost-user.rst
>@@ -248,7 +248,7 @@ Multiple Memory regions description
>
> :padding: 32-bit
>
>-:regions: regions field contains 8 regions of type :ref:`Memory region description <memory_region_description>`.
>+:regions: regions field contains up to 8 regions of type :ref:`Memory region description <memory_region_description>`.
>
> Log description
> ^^^^^^^^^^^^^^^
>-- 
>MST
>