[PATCH for 6.1 0/1] Fix chardev frontend bug in HMP

Volker Rümelin posted 1 patch 2 years, 9 months ago
Only 0 patches received!
monitor/hmp.c              |  1 +
monitor/monitor-internal.h |  1 +
monitor/monitor.c          | 19 +++++++++++++++++--
3 files changed, 19 insertions(+), 2 deletions(-)
[PATCH for 6.1 0/1] Fix chardev frontend bug in HMP
Posted by Volker Rümelin 2 years, 9 months ago
Since commit 584af1f1d9 (ui/gtk: add a keyboard fifo to the VTE
consoles) a GTK VTE console chardev backend relies on the
connected chardev frontend to call qemu_chr_fe_accept_input()
whenever it can receive new characters. The HMP monitor doesn't
do this. It only schedules a call to qemu_chr_fe_accept_input()
after it handled a HMP command in monitor_command_cb().

To see the problem copy and paste the word help into the GTK VTE
monitor console. You will only see the letter h. Now press the
enter key several times. Each key press will add another letter
to the word help.

I think I need help with this patch. This is the first time I
had a closer look at the monitor code so it's quite possible my
patch is completely wrong.

Volker Rümelin (1):
   monitor/hmp: schedule qemu_chr_fe_accept_input() after read

  monitor/hmp.c              |  1 +
  monitor/monitor-internal.h |  1 +
  monitor/monitor.c          | 19 +++++++++++++++++--
  3 files changed, 19 insertions(+), 2 deletions(-)

-- 
2.26.2