qga: Fix some style problems

[PATCH 0/4] qga: Fix some style problems

Posted by AlexChen 3 years, 5 months ago

Fix some error style problems found by checkpatch.pl.

alexchen (4):
  qga: Add spaces around operator
  qga: Delete redundant spaces
  qga: Open brace '{' following struct go on the same
  qga: switch and case should be at the same indent

 qga/channel-win32.c  |  6 ++---
 qga/commands-posix.c |  4 +--
 qga/commands-win32.c | 28 ++++++++++-----------
 qga/commands.c       |  4 +--
 qga/main.c           | 59 ++++++++++++++++++++++----------------------
 5 files changed, 50 insertions(+), 51 deletions(-)

-- 
2.19.1

Re: [PATCH 0/4] qga: Fix some style problems

Posted by AlexChen 3 years, 5 months ago

Kindly ping.

On 2020/10/26 17:05, AlexChen wrote:
> Fix some error style problems found by checkpatch.pl.
> 
> alexchen (4):
>   qga: Add spaces around operator
>   qga: Delete redundant spaces
>   qga: Open brace '{' following struct go on the same
>   qga: switch and case should be at the same indent
> 
>  qga/channel-win32.c  |  6 ++---
>  qga/commands-posix.c |  4 +--
>  qga/commands-win32.c | 28 ++++++++++-----------
>  qga/commands.c       |  4 +--
>  qga/main.c           | 59 ++++++++++++++++++++++----------------------
>  5 files changed, 50 insertions(+), 51 deletions(-)
>

Re: [PATCH 0/4] qga: Fix some style problems

Posted by Marc-André Lureau 3 years, 5 months ago

On Mon, Oct 26, 2020 at 1:16 PM AlexChen <alex.chen@huawei.com> wrote:

> Fix some error style problems found by checkpatch.pl.
>
> alexchen (4):
>   qga: Add spaces around operator
>   qga: Delete redundant spaces
>   qga: Open brace '{' following struct go on the same
>   qga: switch and case should be at the same indent
>
>  qga/channel-win32.c  |  6 ++---
>  qga/commands-posix.c |  4 +--
>  qga/commands-win32.c | 28 ++++++++++-----------
>  qga/commands.c       |  4 +--
>  qga/main.c           | 59 ++++++++++++++++++++++----------------------
>  5 files changed, 50 insertions(+), 51 deletions(-)
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


-- 
Marc-André Lureau

Re: [PATCH 0/4] qga: Fix some style problems

Posted by Laurent Vivier 3 years, 2 months ago

Le 04/11/2020 à 08:46, Marc-André Lureau a écrit :
> 
> 
> On Mon, Oct 26, 2020 at 1:16 PM AlexChen <alex.chen@huawei.com <mailto:alex.chen@huawei.com>> wrote:
> 
>     Fix some error style problems found by checkpatch.pl <http://checkpatch.pl>.
> 
>     alexchen (4):
>       qga: Add spaces around operator
>       qga: Delete redundant spaces
>       qga: Open brace '{' following struct go on the same
>       qga: switch and case should be at the same indent
> 
>      qga/channel-win32.c  |  6 ++---
>      qga/commands-posix.c |  4 +--
>      qga/commands-win32.c | 28 ++++++++++-----------
>      qga/commands.c       |  4 +--
>      qga/main.c           | 59 ++++++++++++++++++++++----------------------
>      5 files changed, 50 insertions(+), 51 deletions(-)
> 
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com <mailto:marcandre.lureau@redhat.com>>

Where are the patches?

I don't find them in my mailbox and patchew didn't receive them:

https://patchew.org/QEMU/5F96915D.2040102@huawei.com/

Thanks,
Laurent

Re: [PATCH 0/4] qga: Fix some style problems

Posted by Marc-André Lureau 3 years, 2 months ago

Hi

On Sun, Feb 14, 2021 at 3:20 AM Laurent Vivier <laurent@vivier.eu> wrote:

> Le 04/11/2020 à 08:46, Marc-André Lureau a écrit :
> >
> >
> > On Mon, Oct 26, 2020 at 1:16 PM AlexChen <alex.chen@huawei.com <mailto:
> alex.chen@huawei.com>> wrote:
> >
> >     Fix some error style problems found by checkpatch.pl <
> http://checkpatch.pl>.
> >
> >     alexchen (4):
> >       qga: Add spaces around operator
> >       qga: Delete redundant spaces
> >       qga: Open brace '{' following struct go on the same
> >       qga: switch and case should be at the same indent
> >
> >      qga/channel-win32.c  |  6 ++---
> >      qga/commands-posix.c |  4 +--
> >      qga/commands-win32.c | 28 ++++++++++-----------
> >      qga/commands.c       |  4 +--
> >      qga/main.c           | 59
> ++++++++++++++++++++++----------------------
> >      5 files changed, 50 insertions(+), 51 deletions(-)
> >
> >
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com <mailto:
> marcandre.lureau@redhat.com>>
>
> Where are the patches?
>
> I don't find them in my mailbox and patchew didn't receive them:
>
> https://patchew.org/QEMU/5F96915D.2040102@huawei.com/
>
>
It was received on the mailing list:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/index.html
(I got them in my mailbox as well)

-- 
Marc-André Lureau