block: Remove unused include

AlexChen posted 1 patch 3 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/5F8FFB94.3030209@huawei.com
Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>
block/dmg-lzfse.c | 1 -
1 file changed, 1 deletion(-)
block: Remove unused include
Posted by AlexChen 3 years, 6 months ago
The "qemu-common.h" include is not used, remove it.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
 block/dmg-lzfse.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c
index 19d25bc646..6798cf4fbf 100644
--- a/block/dmg-lzfse.c
+++ b/block/dmg-lzfse.c
@@ -22,7 +22,6 @@
  * THE SOFTWARE.
  */
 #include "qemu/osdep.h"
-#include "qemu-common.h"
 #include "dmg.h"
 #include <lzfse.h>

-- 
2.19.1

Re: block: Remove unused include
Posted by AlexChen 3 years, 6 months ago
Kindly ping.

Thanks,
Alex

On 2020/10/21 17:12, AlexChen wrote:
> The "qemu-common.h" include is not used, remove it.
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
>  block/dmg-lzfse.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c
> index 19d25bc646..6798cf4fbf 100644
> --- a/block/dmg-lzfse.c
> +++ b/block/dmg-lzfse.c
> @@ -22,7 +22,6 @@
>   * THE SOFTWARE.
>   */
>  #include "qemu/osdep.h"
> -#include "qemu-common.h"
>  #include "dmg.h"
>  #include <lzfse.h>
> 


Re: block: Remove unused include
Posted by Max Reitz 3 years, 6 months ago
On 21.10.20 11:12, AlexChen wrote:
> The "qemu-common.h" include is not used, remove it.
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
>  block/dmg-lzfse.c | 1 -
>  1 file changed, 1 deletion(-)

Thanks, I’ve applied this patch to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Please note (for future patches) that all patches’ subjects should by
prefixed by “[PATCH]”, as done by git format-patch (see
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch).

Max


Re: block: Remove unused include
Posted by AlexChen 3 years, 6 months ago
On 2020/11/3 21:26, Max Reitz wrote:
> On 21.10.20 11:12, AlexChen wrote:
>> The "qemu-common.h" include is not used, remove it.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>>  block/dmg-lzfse.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> Thanks, I’ve applied this patch to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> Please note (for future patches) that all patches’ subjects should by
> prefixed by “[PATCH]”, as done by git format-patch (see
> https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch).
>

Oh, this is my fault, I will pay attention to this in my subsequent patches.

Thanks,
Alex