[PATCH] fixed argument order for keymap-get in build

Dorian Bourgeoisat posted 1 patch 2 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/589feb12-5abf-a247-96f7-d8603a35e5ae@telecom-paris.fr
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
ui/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] fixed argument order for keymap-get in build
Posted by Dorian Bourgeoisat 2 years, 3 months ago
Hello, trying to compile QEMU on the latest ArchLinux update (2022-01-05), I encounter a bug where keymap-gen is called with the wrong argument order.

$ ../ui/keycodemapdb/tools/keymap-gen code-map --lang glib2 --varname qemu_input_map_linux_to_qcode ../ui/keycodemapdb/data/keymaps.csv linux qcode
usage: keymap-gen [-h] [--lang LANG] [--varname VARNAME]
                  {code-map,code-table,name-map,name-table,code-docs,name-docs} ...
keymap-gen: error: unrecognized arguments: --lang --varname linux qcode

This patch makes the meson build file compliant with the new argument order.

Signed-off-by: Dorian Bourgeoisat <dorian.bourgeoisat@telecom-paris.fr>
---
 ui/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/meson.build b/ui/meson.build
index 64286ba150..87ecace041 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -161,9 +161,9 @@ if have_system or xkbcommon.found()
                   capture: true,
                   input: files('keycodemapdb/data/keymaps.csv'),
                   command: [python, files('keycodemapdb/tools/keymap-gen'),
-                            'code-map',
                             '--lang', 'glib2',
                             '--varname', 'qemu_input_map_@0@_to_@1@'.format(e[0], e[1]),
+                            'code-map',
                             '@INPUT0@', e[0], e[1]])
   endforeach
 endif
-- 
2.34.1