[v2] virtiofsd: fix some accessing NULL pointer problem

[PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Haotian Li posted 2 patches 3 years, 5 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/4bfe8bbd-282f-f271-735d-8892791327e1@huawei.com

Test checkpatch passed

Maintainers: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

There is a newer version of this series

tools/virtiofsd/buffer.c         |  4 ++++
tools/virtiofsd/passthrough_ll.c | 10 +++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Posted by Haotian Li 3 years, 5 months ago

Haotian Li (2):
  tools/virtiofsd/buffer.c: check whether buf is NULL in
    fuse_bufvec_advance func
  virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL
    in main func

 tools/virtiofsd/buffer.c         |  4 ++++
 tools/virtiofsd/passthrough_ll.c | 10 +++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

--

Re: [Virtio-fs] [PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Posted by Stefan Hajnoczi 3 years, 5 months ago

On Tue, Nov 10, 2020 at 02:32:17PM +0800, Haotian Li wrote:
> Haotian Li (2):
>   tools/virtiofsd/buffer.c: check whether buf is NULL in
>     fuse_bufvec_advance func
>   virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL
>     in main func
> 
>  tools/virtiofsd/buffer.c         |  4 ++++
>  tools/virtiofsd/passthrough_ll.c | 10 +++++++++-
>  2 files changed, 13 insertions(+), 1 deletion(-)

Please consider printing an error message in Patch 2 so that users can
easily tell why the program refused to start.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Virtio-fs] [PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Posted by Zhiqiang Liu 3 years, 5 months ago


On 2020/11/10 19:45, Stefan Hajnoczi wrote:
> On Tue, Nov 10, 2020 at 02:32:17PM +0800, Haotian Li wrote:
>> Haotian Li (2):
>>   tools/virtiofsd/buffer.c: check whether buf is NULL in
>>     fuse_bufvec_advance func
>>   virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL
>>     in main func
>>
>>  tools/virtiofsd/buffer.c         |  4 ++++
>>  tools/virtiofsd/passthrough_ll.c | 10 +++++++++-
>>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> Please consider printing an error message in Patch 2 so that users can
> easily tell why the program refused to start.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
Thanks for your review.
We will add error message in Patch2, and then send the v3-patch series.

Regards
Zhiqiang Liu.
> 
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
>

Re: [Virtio-fs] [PATCH v2 0/2] virtiofsd: fix some accessing NULL pointer problem

Posted by Haotian Li 3 years, 5 months ago

Thanks for your suggestion. New patches will be resent.

> On Tue, Nov 10, 2020 at 02:32:17PM +0800, Haotian Li wrote:
>> Haotian Li (2):
>>   tools/virtiofsd/buffer.c: check whether buf is NULL in
>>     fuse_bufvec_advance func
>>   virtiofsd/passthrough_ll.c: check whether lo_map_reserve returns NULL
>>     in main func
>>
>>  tools/virtiofsd/buffer.c         |  4 ++++
>>  tools/virtiofsd/passthrough_ll.c | 10 +++++++++-
>>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> Please consider printing an error message in Patch 2 so that users can
> easily tell why the program refused to start.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>