[PATCH] hw/ufs: free irq on exit

Zheng Huang posted 1 patch 2 days, 19 hours ago
hw/ufs/ufs.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] hw/ufs: free irq on exit
Posted by Zheng Huang 2 days, 19 hours ago
Hi,

This patch fixes a memory leak bug in `ufs_init_pci()`. `u->irq` is
not freed in `ufs_exit()`.

Signed-off-by: Zheng Huang <hz1624917200@gmail.com>

---
 hw/ufs/ufs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index 1ccd6f88b6..e80e065fea 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -25,6 +25,7 @@
 #include "qapi/error.h"
 #include "migration/vmstate.h"
 #include "scsi/constants.h"
+#include "hw/irq.h"
 #include "trace.h"
 #include "ufs.h"
 
@@ -1732,6 +1733,8 @@ static void ufs_exit(PCIDevice *pci_dev)
 {
     UfsHc *u = UFS(pci_dev);
 
+    qemu_free_irq(u->irq);
+    
     qemu_bh_delete(u->doorbell_bh);
     qemu_bh_delete(u->complete_bh);
 
-- 
2.34.1
Re: [PATCH] hw/ufs: free irq on exit
Posted by Philippe Mathieu-Daudé 20 hours ago
On 29/3/25 12:47, Zheng Huang wrote:
> Hi,
> 
> This patch fixes a memory leak bug in `ufs_init_pci()`. `u->irq` is
> not freed in `ufs_exit()`.
> 
> Signed-off-by: Zheng Huang <hz1624917200@gmail.com>
> 
> ---
>   hw/ufs/ufs.c | 3 +++
>   1 file changed, 3 insertions(+)

Queued to hw-misc, thanks!
Re: [PATCH] hw/ufs: free irq on exit
Posted by Philippe Mathieu-Daudé 2 days, 19 hours ago
On 29/3/25 12:47, Zheng Huang wrote:
> Hi,
> 
> This patch fixes a memory leak bug in `ufs_init_pci()`. `u->irq` is
> not freed in `ufs_exit()`.
> 
> Signed-off-by: Zheng Huang <hz1624917200@gmail.com>
> 
> ---
>   hw/ufs/ufs.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>