[v1] coreaudio: fix coreaudio playback

[PATCH 0/1] coreaudio: fix coreaudio playback

Volker Rümelin posted 1 patch 5 years, 9 months ago

Diff against v1
Download series mbox

Test docker-quick@centos7 failed

Test FreeBSD passed

Test docker-mingw@fedora failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/30c8b9e6-484c-5785-b178-bef01628db49@t-online.de

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

There is a newer version of this series

audio/audio_template.h |  7 +++++++
audio/coreaudio.c      | 32 +++++++++-----------------------
audio/mixeng.c         | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
audio/mixeng.h         |  5 +++++
4 files changed, 69 insertions(+), 23 deletions(-)

Expand all Fold all

[PATCH 0/1] coreaudio: fix coreaudio playback

Posted by Volker Rümelin 5 years, 9 months ago

Hi,

here is a new patch for the CoreAudio playback problem. This patch
is Zoltán's patch from
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html
and a improved version of my patch squashed together.

I actually tested the changes in audio/audio_template.h,
audio/mixeng.c and audio/mixeng.h with all useful permutations of
FLOAT_MIXENG and RECIPROCAL defined/undefined.

@Howard and John
Can you please test this patch? Compared to the patches you tested
this patch is quite different.

@John
'git am exported_mail.eml' knows how to handle
Content-Transfer-Encoding: in a mail file. It's not necessary to
apply this patch by hand.

Volker Rümelin (1):
  coreaudio: fix coreaudio playback

 audio/audio_template.h |  7 +++++++
 audio/coreaudio.c      | 32 +++++++++-----------------------
 audio/mixeng.c         | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 audio/mixeng.h         |  5 +++++
 4 files changed, 69 insertions(+), 23 deletions(-)

-- 
2.16.4

Re: [PATCH 0/1] coreaudio: fix coreaudio playback

Posted by Howard Spoelstra 5 years, 9 months ago

On Sun, Feb 2, 2020 at 3:03 PM Volker Rümelin <vr_qemu@t-online.de> wrote:

> Hi,
>
> here is a new patch for the CoreAudio playback problem. This patch
> is Zoltán's patch from
> https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html
> and a improved version of my patch squashed together.
>
> I actually tested the changes in audio/audio_template.h,
> audio/mixeng.c and audio/mixeng.h with all useful permutations of
> FLOAT_MIXENG and RECIPROCAL defined/undefined.
>
> @Howard and John
> Can you please test this patch? Compared to the patches you tested
> this patch is quite different.
>
> @John
> 'git am exported_mail.eml' knows how to handle
> Content-Transfer-Encoding: in a mail file. It's not necessary to
> apply this patch by hand.
>
> Volker Rümelin (1):
>   coreaudio: fix coreaudio playback
>
>  audio/audio_template.h |  7 +++++++
>  audio/coreaudio.c      | 32 +++++++++-----------------------
>  audio/mixeng.c         | 48
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  audio/mixeng.h         |  5 +++++
>  4 files changed, 69 insertions(+), 23 deletions(-)
>
> --
> 2.16.4
>
> Hi,

This patch restores coreaudio for me.
I applied the patch on top of https://github.com/mcayland/qemu/tree/screamer
to test audio support in qemu-system-ppc running Mac OS 9.2 and OSX 10.5.
Host is OSX Sierra.

Thanks,
Howard