tests/functional: test_acpi_bits requires TCG

[RFC PATCH] tests/functional: test_acpi_bits requires TCG

Posted by Alex Bennée 5 days, 3 hours ago

Running a full thorough test suite on a KVM-only build fails due to
acpi bits needing icount, therefor tcg. Declare the restriction so the
test harness can skip it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/functional/x86_64/test_acpi_bits.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x86_64/test_acpi_bits.py
index ec716d643bf..62c57d23f6c 100755
--- a/tests/functional/x86_64/test_acpi_bits.py
+++ b/tests/functional/x86_64/test_acpi_bits.py
@@ -303,6 +303,8 @@ def test_acpi_smbios_bits(self):
         """The main test case implementation."""
 
         self.set_machine('pc')
+        self.require_accelerator('tcg')
+
         iso_file = self.scratch_file('bits-%d.iso' % self.BITS_INTERNAL_VER)
 
         self.assertTrue(os.access(iso_file, os.R_OK))
-- 
2.47.3

Re: [RFC PATCH] tests/functional: test_acpi_bits requires TCG

Posted by Philippe Mathieu-Daudé 4 days, 10 hours ago

On 21/9/26 18:08, Alex BennÃ©e wrote:
> Running a full thorough test suite on a KVM-only build fails due to
> acpi bits needing icount, therefor tcg. Declare the restriction so the

"therefore"

> test harness can skip it.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/functional/x86_64/test_acpi_bits.py | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x86_64/test_acpi_bits.py
> index ec716d643bf..62c57d23f6c 100755
> --- a/tests/functional/x86_64/test_acpi_bits.py
> +++ b/tests/functional/x86_64/test_acpi_bits.py
> @@ -303,6 +303,8 @@ def test_acpi_smbios_bits(self):
>           """The main test case implementation."""
>   
>           self.set_machine('pc')
> +        self.require_accelerator('tcg')

Could you add a "# see icount comment below" comment? With that:
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

> +
>           iso_file = self.scratch_file('bits-%d.iso' % self.BITS_INTERNAL_VER)
>   
>           self.assertTrue(os.access(iso_file, os.R_OK))

Re: [RFC PATCH] tests/functional: test_acpi_bits requires TCG

Posted by Thomas Huth 4 days, 14 hours ago

On 21/09/2026 18.08, Alex Bennée wrote:
> Running a full thorough test suite on a KVM-only build fails due to
> acpi bits needing icount, therefor tcg. Declare the restriction so the
> test harness can skip it.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/functional/x86_64/test_acpi_bits.py | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x86_64/test_acpi_bits.py
> index ec716d643bf..62c57d23f6c 100755
> --- a/tests/functional/x86_64/test_acpi_bits.py
> +++ b/tests/functional/x86_64/test_acpi_bits.py
> @@ -303,6 +303,8 @@ def test_acpi_smbios_bits(self):
>           """The main test case implementation."""
>   
>           self.set_machine('pc')
> +        self.require_accelerator('tcg')
> +
>           iso_file = self.scratch_file('bits-%d.iso' % self.BITS_INTERNAL_VER)
>   
>           self.assertTrue(os.access(iso_file, os.R_OK))

Reviewed-by: Thomas Huth <thuth@redhat.com>