[PATCH v2 0/3] hw/misc/aspeed_sbc: Fix ABR and secure boot state reporting

Kane Chen posted 3 patches 1 week, 1 day ago
include/hw/misc/aspeed_sbc.h  |  3 --
include/hw/nvram/aspeed_otp.h | 32 ++++++++++++
hw/misc/aspeed_sbc.c          | 97 +++++++++++++++++------------------
hw/nvram/aspeed_otp.c         | 63 +++++++++++++++++++++++
4 files changed, 143 insertions(+), 52 deletions(-)
[PATCH v2 0/3] hw/misc/aspeed_sbc: Fix ABR and secure boot state reporting
Posted by Kane Chen 1 week, 1 day ago
The ABR and secure boot states are currently controlled by the
"emmc-abr" and "signing-settings" machine properties.

On real hardware, these states are determined by the OTP configuration
and reflected in the SBC status registers. This series updates the
model to derive the ABR and secure boot states from OTP instead, and
removes the corresponding machine properties.

The series also consolidates the OTP layout definitions and adds
helpers for reading OTP configuration and strap settings.

Any feedback or suggestions are appreciated!

Kane
---

ChangeLog
---------
v2:
- Move OTP layout definitions to aspeed_otp.h
- Add helpers for reading OTP configuration and strap settings
- Derive ABR and secure boot states using the new OTP helpers

v1:
- Initial version

---

Kane-Chen-AS (3):
  hw/nvram/aspeed_otp, hw/misc/aspeed_sbc: Consolidate OTP layout
    definitions
  hw/misc/aspeed_sbc: Derive ABR state from OTP config straps
  hw/misc/aspeed_sbc: Derive secure boot state from OTP config

 include/hw/misc/aspeed_sbc.h  |  3 --
 include/hw/nvram/aspeed_otp.h | 32 ++++++++++++
 hw/misc/aspeed_sbc.c          | 97 +++++++++++++++++------------------
 hw/nvram/aspeed_otp.c         | 63 +++++++++++++++++++++++
 4 files changed, 143 insertions(+), 52 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/3] hw/misc/aspeed_sbc: Fix ABR and secure boot state reporting
Posted by Cédric Le Goater 1 week, 1 day ago
On 9/18/26 08:53, Kane Chen wrote:
> The ABR and secure boot states are currently controlled by the
> "emmc-abr" and "signing-settings" machine properties.
> 
> On real hardware, these states are determined by the OTP configuration
> and reflected in the SBC status registers. This series updates the
> model to derive the ABR and secure boot states from OTP instead, and
> removes the corresponding machine properties.
> 
> The series also consolidates the OTP layout definitions and adds
> helpers for reading OTP configuration and strap settings.
> 
> Any feedback or suggestions are appreciated!
> 
> Kane
> ---
> 
> ChangeLog
> ---------
> v2:
> - Move OTP layout definitions to aspeed_otp.h
> - Add helpers for reading OTP configuration and strap settings
> - Derive ABR and secure boot states using the new OTP helpers
> 
> v1:
> - Initial version
> 
> ---
> 
> Kane-Chen-AS (3):
>    hw/nvram/aspeed_otp, hw/misc/aspeed_sbc: Consolidate OTP layout
>      definitions
>    hw/misc/aspeed_sbc: Derive ABR state from OTP config straps
>    hw/misc/aspeed_sbc: Derive secure boot state from OTP config
> 
>   include/hw/misc/aspeed_sbc.h  |  3 --
>   include/hw/nvram/aspeed_otp.h | 32 ++++++++++++
>   hw/misc/aspeed_sbc.c          | 97 +++++++++++++++++------------------
>   hw/nvram/aspeed_otp.c         | 63 +++++++++++++++++++++++
>   4 files changed, 143 insertions(+), 52 deletions(-)
> 

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.