ui/gtk: Remove glFlush() after eglSwapBuffers()

[PATCH] ui/gtk: Remove glFlush() after eglSwapBuffers()

Akihiko Odaki posted 1 patch 1 week, 6 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260913-flush-v1-1-229efa3f1e53@rsg.ci.i.u-tokyo.ac.jp

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>

ui/gtk-egl.c | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[PATCH] ui/gtk: Remove glFlush() after eglSwapBuffers()

Posted by Akihiko Odaki 1 week, 6 days ago

It is redundant since eglSwapBuffers() implicitly performs glFlush().

Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
---
 ui/gtk-egl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index d595916476d9..0eec06826bdd 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -104,7 +104,6 @@ void gd_egl_draw(VirtualConsole *vc)
                         surface_width(vc->gfx.ds),
                         surface_height(vc->gfx.ds));
 
-        glFlush();
 #ifdef CONFIG_GBM
         if (dmabuf) {
             gd_gl_wait_sync(vc, sync);
@@ -122,8 +121,6 @@ void gd_egl_draw(VirtualConsole *vc)
         gd_update_scale(vc, ww, wh,
                         surface_width(vc->gfx.ds),
                         surface_height(vc->gfx.ds));
-
-        glFlush();
     }
 }
 

---
base-commit: 209b2afaface001c7d4d981e38f186afe7b24a50
change-id: 20260913-flush-08715ed9f4f2

Best regards,
--  
Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>

Re: [PATCH] ui/gtk: Remove glFlush() after eglSwapBuffers()

Posted by Marc-André Lureau 1 week, 6 days ago

On Sun, Sep 13, 2026 at 10:42 AM Akihiko Odaki
<odaki@rsg.ci.i.u-tokyo.ac.jp> wrote:
>
> It is redundant since eglSwapBuffers() implicitly performs glFlush().
>
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  ui/gtk-egl.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index d595916476d9..0eec06826bdd 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -104,7 +104,6 @@ void gd_egl_draw(VirtualConsole *vc)
>                          surface_width(vc->gfx.ds),
>                          surface_height(vc->gfx.ds));
>
> -        glFlush();
>  #ifdef CONFIG_GBM
>          if (dmabuf) {
>              gd_gl_wait_sync(vc, sync);
> @@ -122,8 +121,6 @@ void gd_egl_draw(VirtualConsole *vc)
>          gd_update_scale(vc, ww, wh,
>                          surface_width(vc->gfx.ds),
>                          surface_height(vc->gfx.ds));
> -
> -        glFlush();
>      }
>  }
>
>
> ---
> base-commit: 209b2afaface001c7d4d981e38f186afe7b24a50
> change-id: 20260913-flush-08715ed9f4f2
>
> Best regards,
> --
> Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
>