[PATCH v8 00/16] s390x/pci: Implement migration for emulated devices

Konstantin Shkolnyy posted 16 patches 1 week, 1 day ago
Maintainers: Matthew Rosato <mjrosato@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>
hw/s390x/s390-pci-bus.c          | 462 +++++++++++++++++++++++++++----
hw/s390x/s390-pci-inst.c         | 159 ++++++-----
hw/s390x/s390-pci-vfio.c         |   4 +-
hw/s390x/s390-virtio-ccw.c       |   4 +
include/hw/s390x/s390-pci-bus.h  |  47 +++-
include/hw/s390x/s390-pci-inst.h |   7 +-
6 files changed, 540 insertions(+), 143 deletions(-)
[PATCH v8 00/16] s390x/pci: Implement migration for emulated devices
Posted by Konstantin Shkolnyy 1 week, 1 day ago
Up until now QEMU marked any zPCI device as "unmigratable."

This patch series adds support for migrating emulated devices, which are
simpler to migrate. It leaves VFIO devices still unmigratable.

To enable migration, the device state needs to be saved/restored to/from
the migration stream.

There are 2 kinds of emulated devices - those that use the zPCI IOMMU page
table emulation in QEMU (e.g., Intel IGB NIC), and those that don't (virtio).
This is important to note for testing purposes.

This change was tested on IGB, virtio-net and virtio-blk devices by running
I/O on them while performing "virsh managedsave, virsh start" and also live
migration to another host and back.

Changes in v8:
 - patch 1: Improve s390_pci_ioat_replay().
 - patch 3..12: Change commit messages as asked by Matt Rosato.
 - patch 13: Clarify comment above S390PCIIOMMU.
 - patch 14: New.
 - patch 15 (formerly 14):
   - remove "Reviewed-by"
   - set .priority to MIG_PRI_IOMMU for the new s390_pci_device_vmstate;
   - add checks for bad values in the incoming migration stream;
   - make sure a zpci device with no PCI function still blocks migration;
   - move zpci blocker from TYPE_PCI_DEVICE plug/unplug() to TYPE_S390_PCI_DEVICE;
   - add proper cleanup on error paths of s390_pcihost_plug(TYPE_PCI_DEVICE);
   - migrate pending zPCI SEI events;
   - sync zpci_fn .uid and .fid to the incoming migrated values;
   - Don't migrate max_dma_limit and pci_unplug_request_processed;
   - few cosmetic non-functional changes.

Konstantin Shkolnyy (15):
  s390x/pci: Create function to contain translation status check
  s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move dm_mr from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move iotlb from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU
  s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move dma_limit from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move g_iota from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move pba from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move pal from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Move max_dma_limit from S390PCIIOMMU to S390PCIBusDevice
  s390x/pci: Add a comment explaining S390PCIIOMMU purpose
  s390x/pci: Factor ioat sanity checks into a separate function
  s390x/pci: Implement migration for emulated devices
  s390x/pci: Create function to contain fmb_timer start

Matthew Rosato (1):
  s390x/pci: implement IOMMU replay

 hw/s390x/s390-pci-bus.c          | 462 +++++++++++++++++++++++++++----
 hw/s390x/s390-pci-inst.c         | 159 ++++++-----
 hw/s390x/s390-pci-vfio.c         |   4 +-
 hw/s390x/s390-virtio-ccw.c       |   4 +
 include/hw/s390x/s390-pci-bus.h  |  47 +++-
 include/hw/s390x/s390-pci-inst.h |   7 +-
 6 files changed, 540 insertions(+), 143 deletions(-)

-- 
2.34.1