[PATCH] rust: qemu-macros: remove redundant clone()

Paolo Bonzini posted 1 patch 3 weeks, 1 day ago
Maintainers: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
rust/qemu-macros/src/lib.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust: qemu-macros: remove redundant clone()
Posted by Paolo Bonzini 3 weeks, 1 day ago
This is reported by Clippy in the latest nightly builds.  Take
a reference instead of cloning.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rust/qemu-macros/src/lib.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs
index ee417bb4b4e..271125185ec 100644
--- a/rust/qemu-macros/src/lib.rs
+++ b/rust/qemu-macros/src/lib.rs
@@ -261,7 +261,7 @@ macro_rules! str_to_c_str {
                 }
             },
         )?;
-        let field_ty = field.ty.clone();
+        let field_ty = &field.ty;
         let (qdev_prop, bitval) = if let Some(bitval) = bitnr {
             (
                 quote! { <#field_ty as ::hwcore::QDevProp>::BIT_INFO },
-- 
2.55.0
Re: [PATCH] rust: qemu-macros: remove redundant clone()
Posted by Philippe Mathieu-Daudé 5 days, 10 hours ago
On 4/9/26 14:48, Paolo Bonzini wrote:
> This is reported by Clippy in the latest nightly builds.  Take
> a reference instead of cloning.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   rust/qemu-macros/src/lib.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>