On 2026/08/25 16:51, Christian Quante wrote:
> v1: https://lore.kernel.org/qemu-devel/20260823071529.16389-1-christian@quante.one/
>
> Patch 1 is the fix from v1 with its commit message corrected. Patch 2 is
> a comment-only follow-up Akihiko suggested, kept separate so patch 1
> stays a pure fix for stable.
>
> Changes since v1:
> - commit message: the probe does not end in the same error either way.
> Without a reply libps2 returns -EIO, with the resend -EPROTO (Akihiko
> Odaki)
> - commit message: cite 06b3611fc2a3 instead of calling the keyboard
> behaviour twenty years old, it is from 2016 (Akihiko Odaki)
> - commit message: name both unknown commands Linux runs into, 0xEC from
> the ALPS probe and 0xE1 from the TrackPoint probe, at a 200 ms reply
> timeout each
> - shorten the new comment. Its last sentence is gone as suggested
> (Akihiko Odaki), and the sentence before it went as well: it described
> the silence this patch removes, which belongs in this message rather
> than next to the code that no longer produces it
> - new patch 2: give the keyboard path the same comment (Akihiko Odaki)
> - Cc: qemu-stable@nongnu.org (Akihiko Odaki)
> - Marc-André Lureau's Reviewed-by carried over: the code of patch 1 is
> unchanged apart from the shortened comment
>
> Christian Quante (2):
> hw/input/ps2: answer unknown mouse commands with a resend
> hw/input/ps2: say why unknown keyboard commands draw a resend
>
> hw/input/ps2.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Now everything looks good to me. For the whole series:
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Regards,
Akihiko Odaki