1. Patchew
  2. QEMU
  3. View series

[PATCH] hw/misc: fix trace-events

marcandre.lureau@redhat.com posted 1 patch 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260825074114.853069-1-marcandre.lureau@redhat.com
hw/misc/trace-events | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] hw/misc: fix trace-events
Posted by marcandre.lureau@redhat.com 1 month ago 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
trace events.

Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/misc/trace-events | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/misc/trace-events b/hw/misc/trace-events
index 16db4ba0cc17..0b8be3d0f226 100644
--- a/hw/misc/trace-events
+++ b/hw/misc/trace-events
@@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
 # k230_decomp_gzip.c
 k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
 k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
+
+# vmlaunchupdate.c
+launch_update_write(void) ""
+vmlaunch_reset_enter(void) ""
+vm_launchupdate_finalize(void) ""
+restore_host_x86_igvm(void) ""
-- 
2.55.0.543.g5ebe2ebe4ea8
Re: [PATCH] hw/misc: fix trace-events
Posted by Philippe Mathieu-Daudé 1 month ago 
On 25/8/26 09:41, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.
> 
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   hw/misc/trace-events | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 16db4ba0cc17..0b8be3d0f226 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
>   # k230_decomp_gzip.c
>   k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
>   k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
> +
> +# vmlaunchupdate.c
> +launch_update_write(void) ""
> +vmlaunch_reset_enter(void) ""
> +vm_launchupdate_finalize(void) ""
> +restore_host_x86_igvm(void) ""

Applying: hw/misc: fix trace-events
Patch failed at 0001 hw/misc: fix trace-events
error: patch failed: hw/misc/trace-events:446
error: hw/misc/trace-events: patch does not apply

already committed as 8fda982a7c083251635a2ce41dcc068ed0e5c124.
Re: [PATCH] hw/misc: fix trace-events
Posted by Philippe Mathieu-Daudé 1 month ago 
On 25/8/26 09:41, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.
> 
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   hw/misc/trace-events | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Re: [PATCH] hw/misc: fix trace-events
Posted by Luigi Leonardi 1 month ago 
On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
>From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
>trace events.
>
>Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
>Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---
> hw/misc/trace-events | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/hw/misc/trace-events b/hw/misc/trace-events
>index 16db4ba0cc17..0b8be3d0f226 100644
>--- a/hw/misc/trace-events
>+++ b/hw/misc/trace-events
>@@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
> # k230_decomp_gzip.c
> k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
> k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
>+
>+# vmlaunchupdate.c
>+launch_update_write(void) ""
>+vmlaunch_reset_enter(void) ""
>+vm_launchupdate_finalize(void) ""
>+restore_host_x86_igvm(void) ""
>-- 
>2.55.0.543.g5ebe2ebe4ea8
>
>

Thanks!

Reviewed-by: Luigi Leonardi <leonardi@redhat.com>
Re: [PATCH] hw/misc: fix trace-events
Posted by Daniel P. Berrangé 1 month ago 
On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> trace events.

More importantly CI failed to report that build failure. IIUC, this
is likely due to missing libigvm library. We have this available in
Fedora at least, not sure about other distros, but we can add igvm
to libvirt-ci and then to QEMU's deps list for CI.

> 
> Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/misc/trace-events | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 16db4ba0cc17..0b8be3d0f226 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d"
>  # k230_decomp_gzip.c
>  k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64
>  k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64
> +
> +# vmlaunchupdate.c
> +launch_update_write(void) ""
> +vmlaunch_reset_enter(void) ""
> +vm_launchupdate_finalize(void) ""
> +restore_host_x86_igvm(void) ""
> -- 
> 2.55.0.543.g5ebe2ebe4ea8
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
Re: [PATCH] hw/misc: fix trace-events
Posted by Daniel P. Berrangé 1 month ago 
On Tue, Aug 25, 2026 at 10:30:32AM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > 
> > The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> > trace events.
> 
> More importantly CI failed to report that build failure. IIUC, this
> is likely due to missing libigvm library. We have this available in
> Fedora at least, not sure about other distros, but we can add igvm
> to libvirt-ci and then to QEMU's deps list for CI.

Proposed the mapping addition which will let us build-test it:

  https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/583


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
Re: [PATCH] hw/misc: fix trace-events
Posted by Marc-André Lureau 1 month ago 
Hi

On Tue, Aug 25, 2026 at 3:29 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Aug 25, 2026 at 10:30:32AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > The commit 8041d1730871 accidentally removed the vmlaunchupdate.c
> > > trace events.
> >
> > More importantly CI failed to report that build failure. IIUC, this
> > is likely due to missing libigvm library. We have this available in
> > Fedora at least, not sure about other distros, but we can add igvm
> > to libvirt-ci and then to QEMU's deps list for CI.
>
> Proposed the mapping addition which will let us build-test it:
>
>   https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/583

thanks!

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.