[PATCH v3 0/3] migration/rdma: Misc RDMA migration fixes

Yanfei Xu posted 3 patches 1 month ago
Failed in applying to current master (apply log)
migration/rdma.c       | 89 +++++++++++++++++++++++++-----------------
migration/trace-events |  2 +-
2 files changed, 55 insertions(+), 36 deletions(-)
[PATCH v3 0/3] migration/rdma: Misc RDMA migration fixes
Posted by Yanfei Xu 1 month ago
This series fixes three RDMA migration issues.

v2->v3:
  - patch3: Change the type of return value to bool. And add an assert
            check to unexpected WR type. (Peter)

v1->v2:
  - patch1/2: Collect Reviewed-by
  - patch2: Add reproducation step and error logs in commit message
  - patch3: Wrap the post-send op and retry logic into a helper, and
            retry only once after draining a completion when the queue
            is full. (I believe ENOMEM is only recoverable in the
            queue-full case, so we retry once; it should succeed after
            a completion is drained. Any further ENOMEM is treated as
            non-recoverable.)

Yanfei Xu (3):
  migration/rdma: Fix write-side shutdown
  migration/rdma: Post initial receive before accepting
  migration/rdma: Retry control sends on full queue

 migration/rdma.c       | 89 +++++++++++++++++++++++++-----------------
 migration/trace-events |  2 +-
 2 files changed, 55 insertions(+), 36 deletions(-)

-- 
2.20.1
Re: [PATCH v3 0/3] migration/rdma: Misc RDMA migration fixes
Posted by Fabiano Rosas 4 days, 9 hours ago
"Yanfei Xu" <yanfei.xu@bytedance.com> writes:

> This series fixes three RDMA migration issues.
>
> v2->v3:
>   - patch3: Change the type of return value to bool. And add an assert
>             check to unexpected WR type. (Peter)
>
> v1->v2:
>   - patch1/2: Collect Reviewed-by
>   - patch2: Add reproducation step and error logs in commit message
>   - patch3: Wrap the post-send op and retry logic into a helper, and
>             retry only once after draining a completion when the queue
>             is full. (I believe ENOMEM is only recoverable in the
>             queue-full case, so we retry once; it should succeed after
>             a completion is drained. Any further ENOMEM is treated as
>             non-recoverable.)
>
> Yanfei Xu (3):
>   migration/rdma: Fix write-side shutdown
>   migration/rdma: Post initial receive before accepting
>   migration/rdma: Retry control sends on full queue
>
>  migration/rdma.c       | 89 +++++++++++++++++++++++++-----------------
>  migration/trace-events |  2 +-
>  2 files changed, 55 insertions(+), 36 deletions(-)

Queued, thanks.