[v1] Add ECDSA akcipher support and the ASPEED SBC ECDSA engine for AST10x0

[PATCH v1 0/8] Add ECDSA akcipher support and the ASPEED SBC ECDSA engine for AST10x0

Jamin Lin posted 8 patches 1 month, 1 week ago

Diff against v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260818092249.602137-1-jamin._5Flin@aspeedtech.com

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

There is a newer version of this series

crypto/akcipher-gcrypt.c.inc      | 328 +++++++++++++++++++++++++++++-
crypto/akcipher-nettle.c.inc      | 267 ++++++++++++++++++++++++
hw/arm/aspeed_ast10x0.c           |   4 +
hw/misc/aspeed_sbc.c              | 158 +++++++++++++-
hw/misc/trace-events              |   2 +
include/hw/misc/aspeed_sbc.h      |   7 +-
qapi/crypto.json                  |  33 ++-
tests/qtest/aspeed-sbc-test.c     | 190 +++++++++++++++++
tests/qtest/meson.build           |   2 +
tests/unit/test-crypto-akcipher.c | 236 +++++++++++++++++++++
10 files changed, 1221 insertions(+), 6 deletions(-)
create mode 100644 tests/qtest/aspeed-sbc-test.c

Expand all Fold all

[PATCH v1 0/8] Add ECDSA akcipher support and the ASPEED SBC ECDSA engine for AST10x0

Posted by Jamin Lin 1 month, 1 week ago

This series adds ECDSA to the QEMU crypto akcipher framework and models the
ASPEED AST10x0 secure boot controller (SBC) ECDSA engine on top of it.

The crypto side adds ECDSA sign/verify for prime256v1 (NIST P-256) and
secp384r1 (NIST P-384) in both the gcrypt and nettle backends, using the raw
big-endian form (public key Qx || Qy, private key scalar d, signature r || s)
with a pre-computed digest as input.

Both the AST2600 and the AST1030/AST1060 have a Secure Boot Controller (SBC)
that supports RSA and ECDSA verification, but only the AST1030/AST1060 have an
ECDSA verify engine, so this series models ECDSA only. RSA verification is used
solely to verify the AST2600 SPL in ROM CODE, which ASPEED does not release,
so it is very unlikely to be used by end users.

v1:
 1. Add ECDSA akcipher support with gcrypt backend
 2. Add ECDSA akcipher support with nettle backend
 3. Add ECDSA sign/verify unit tests
 4. Support the ECDSA verify command for AST10x0
 5. Add ASPEED SBC ECDSA engine qtest

Jamin Lin (8):
  qapi/crypto: Add ECDSA algorithm and curve id
  crypto/akcipher: Support ECDSA sign/verify with gcrypt
  crypto/akcipher: Support ECDSA sign/verify with nettle
  tests/crypto: Add ECDSA sign/verify tests
  hw/misc/aspeed_sbc: Support the ECDSA verify command
  hw/misc/aspeed_sbc: Increase register space to 0x1000
  hw/arm/aspeed_ast10x0: Wire SEC SRAM to the SBC model
  tests/qtest: Add ASPEED SBC ECDSA engine test

 crypto/akcipher-gcrypt.c.inc      | 328 +++++++++++++++++++++++++++++-
 crypto/akcipher-nettle.c.inc      | 267 ++++++++++++++++++++++++
 hw/arm/aspeed_ast10x0.c           |   4 +
 hw/misc/aspeed_sbc.c              | 158 +++++++++++++-
 hw/misc/trace-events              |   2 +
 include/hw/misc/aspeed_sbc.h      |   7 +-
 qapi/crypto.json                  |  33 ++-
 tests/qtest/aspeed-sbc-test.c     | 190 +++++++++++++++++
 tests/qtest/meson.build           |   2 +
 tests/unit/test-crypto-akcipher.c | 236 +++++++++++++++++++++
 10 files changed, 1221 insertions(+), 6 deletions(-)
 create mode 100644 tests/qtest/aspeed-sbc-test.c

-- 
2.53.0