[v3] hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

[PATCH v3 0/3] hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

Jamin Lin posted 3 patches 1 month, 1 week ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260817055318.3826428-1-jamin._5Flin@aspeedtech.com

hw/usb/hcd-ehci.c | 90 ++++++++++++++++++++++-------------------------
1 file changed, 42 insertions(+), 48 deletions(-)

Expand all Fold all

[PATCH v3 0/3] hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

Posted by Jamin Lin 1 month, 1 week ago

v1:
 1. Fix Fix Coverity CID 1685236
 
v2:
 1. Drops the dead NULL test and checks the actual accesses instead, and makes put_dwords() return void
    since no caller can act on a failed writeback.

v3:
 1. Make get_dwords() return bool

Jamin Lin (3):
  hw/usb/hcd-ehci: Check for DMA errors in get_dwords()/put_dwords()
  hw/usb/hcd-ehci: Make get_dwords() return bool
  hw/usb/hcd-ehci: Handle get_dwords() failures in async writeback

 hw/usb/hcd-ehci.c | 90 ++++++++++++++++++++++-------------------------
 1 file changed, 42 insertions(+), 48 deletions(-)

-- 
2.53.0

Re: [PATCH v3 0/3] hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

Posted by Cédric Le Goater 1 month, 1 week ago

On 8/17/26 07:53, Jamin Lin wrote:
> v1:
>   1. Fix Fix Coverity CID 1685236
>   
> v2:
>   1. Drops the dead NULL test and checks the actual accesses instead, and makes put_dwords() return void
>      since no caller can act on a failed writeback.
> 
> v3:
>   1. Make get_dwords() return bool
> 
> Jamin Lin (3):
>    hw/usb/hcd-ehci: Check for DMA errors in get_dwords()/put_dwords()
>    hw/usb/hcd-ehci: Make get_dwords() return bool
>    hw/usb/hcd-ehci: Handle get_dwords() failures in async writeback
> 
>   hw/usb/hcd-ehci.c | 90 ++++++++++++++++++++++-------------------------
>   1 file changed, 42 insertions(+), 48 deletions(-)
> 

Applied to

     https://github.com/legoater/qemu aspeed-next

Thanks,

C.