scripts/clean_functional_cache: Remove also .stamp files

[PATCH] scripts/clean_functional_cache: Remove also .stamp files

Thomas Huth posted 1 patch 1 week, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260814122643.312129-1-thuth@redhat.com

Maintainers: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Thomas Huth <th.huth+qemu@posteo.eu>, "Philippe Mathieu-Daudé" <philmd@mailo.com>, "Daniel P. Berrangé" <berrange@redhat.com>

scripts/clean_functional_cache.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] scripts/clean_functional_cache: Remove also .stamp files

Posted by Thomas Huth 1 week, 5 days ago

The cache cleanup script already successfully removes the assets
that are unused since more than 6 months, but it forgot to delete
the corresponding timestamp files, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/clean_functional_cache.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/clean_functional_cache.py b/scripts/clean_functional_cache.py
index c3370ffbb87..1ff98c7606d 100755
--- a/scripts/clean_functional_cache.py
+++ b/scripts/clean_functional_cache.py
@@ -28,8 +28,9 @@
     if len(file.name) != 64:
         continue
 
+    stampfile = file.with_suffix(".stamp")
     try:
-        timestamp = int(file.with_suffix(".stamp").read_text())
+        timestamp = int(stampfile.read_text())
     except FileNotFoundError:
         # Assume it's an old file that was already in the cache before we
         # added the code for evicting stale assets. Use the release date
@@ -43,3 +44,4 @@
         print(f"Removing {cache_dir}/{file.name}.")
         file.chmod(stat.S_IWRITE)
         file.unlink()
+        stampfile.unlink()
-- 
2.55.0

Re: [PATCH] scripts/clean_functional_cache: Remove also .stamp files

Posted by Daniel P. Berrangé 1 week, 5 days ago

On Fri, Aug 14, 2026 at 02:26:43PM +0200, Thomas Huth wrote:
> The cache cleanup script already successfully removes the assets
> that are unused since more than 6 months, but it forgot to delete
> the corresponding timestamp files, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  scripts/clean_functional_cache.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|