tests/qtest: remove trace output from k230 watchdog test

[PATCH] tests/qtest: remove trace output from k230 watchdog test

Posted by Chao Liu 1 week, 6 days ago

The interrupt mode test does not depend on trace output, but passes a
trace file to QEMU. This makes startup fail when QEMU is built without
the log or simple trace backend, so qtest cannot connect.

Drop the unnecessary trace option.

Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4126

Signed-off-by: Chao Liu <chao.liu@processmission.com>
---
 tests/qtest/k230-wdt-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/k230-wdt-test.c b/tests/qtest/k230-wdt-test.c
index c8eaeaf1ae..b1131f42e3 100644
--- a/tests/qtest/k230-wdt-test.c
+++ b/tests/qtest/k230-wdt-test.c
@@ -76,7 +76,7 @@ static void test_counter_restart(void)
 
 static void test_interrupt_mode(void)
 {
-    QTestState *qts = qtest_init("-machine k230 --trace k230_*,file=k230.log");
+    QTestState *qts = qtest_init("-machine k230");
 
     /* Set interrupt mode and enable watchdog */
     qtest_writel(qts, WDT_BASE + K230_WDT_CR,
-- 
2.54.0

Re: [PATCH] tests/qtest: remove trace output from k230 watchdog test

Posted by Alistair 1 week, 5 days ago

On Thu, 2026-08-13 at 13:43 +0800, Chao Liu wrote:
> The interrupt mode test does not depend on trace output, but passes a
> trace file to QEMU. This makes startup fail when QEMU is built
> without
> the log or simple trace backend, so qtest cannot connect.
> 
> Drop the unnecessary trace option.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4126
> 
> Signed-off-by: Chao Liu <chao.liu@processmission.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  tests/qtest/k230-wdt-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/k230-wdt-test.c b/tests/qtest/k230-wdt-
> test.c
> index c8eaeaf1ae..b1131f42e3 100644
> --- a/tests/qtest/k230-wdt-test.c
> +++ b/tests/qtest/k230-wdt-test.c
> @@ -76,7 +76,7 @@ static void test_counter_restart(void)
>  
>  static void test_interrupt_mode(void)
>  {
> -    QTestState *qts = qtest_init("-machine k230 --trace
> k230_*,file=k230.log");
> +    QTestState *qts = qtest_init("-machine k230");
>  
>      /* Set interrupt mode and enable watchdog */
>      qtest_writel(qts, WDT_BASE + K230_WDT_CR,

Re: [PATCH] tests/qtest: remove trace output from k230 watchdog test

Posted by Bin Meng 1 week, 6 days ago

On Thu, Aug 13, 2026 at 1:44 PM Chao Liu <chao.liu@processmission.com> wrote:
>
> The interrupt mode test does not depend on trace output, but passes a
> trace file to QEMU. This makes startup fail when QEMU is built without
> the log or simple trace backend, so qtest cannot connect.
>
> Drop the unnecessary trace option.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4126
>
> Signed-off-by: Chao Liu <chao.liu@processmission.com>
> ---
>  tests/qtest/k230-wdt-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bin.meng@processmission.com>