[PATCH v3 00/23] monitor: Reduce headers included in 'monitor/monitor.h'

Philippe Mathieu-Daudé posted 23 patches 1 week, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260812211708.92824-1-philmd@oss.qualcomm.com
Maintainers: "Philippe Mathieu-Daudé" <philmd@mailo.com>, Zhao Liu <zhao1.liu@intel.com>, Brian Cain <brian.cain@oss.qualcomm.com>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Jason Wang <jasowangio@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Alistair Francis <alistair.francis@wdc.com>, David Gibson <david@gibson.dropbear.id.au>, Hyman Huang <infra.ai.cloud@bitdeer.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>
MAINTAINERS                      |   2 +
include/hw/hexagon/hexagon_tlb.h |   2 +-
include/monitor/hmp.h            |   1 -
include/monitor/monitor.h        |   7 +-
include/qapi/qmp-registry.h      |   1 -
monitor/monitor-internal.h       |   7 +-
target/hexagon/hex_mmu.h         |   3 +-
hw/core/machine-qmp-cmds.c       |   6 +
migration/migration-hmp-cmds.c   |   5 +-
monitor/fds.c                    |   1 +
monitor/hmp-cmds.c               |  10 +-
monitor/hmp.c                    | 164 ++++++++++---------
monitor/monitor.c                |   2 +
monitor/qmp-cmds-control.c       |  18 +--
monitor/qmp-cmds.c               |  13 +-
monitor/qmp.c                    | 270 ++++++++++++++++---------------
net/vhost-vdpa.c                 |   1 +
qapi/qmp-dispatch.c              |   2 +
system/cpus.c                    | 247 ----------------------------
system/device_tree.c             |   1 -
system/dirtylimit-hmp-cmds.c     |  74 +++++++++
system/dirtylimit.c              |  60 -------
system/physmem-qmp-cmds.c        | 107 ++++++++++++
system/physmem.c                 |   2 -
system/runstate.c                | 154 ++++++++++++++++++
tests/unit/test-util-sockets.c   |   1 +
ui/ui-hmp-cmds.c                 |   6 +-
system/meson.build               |   2 +
28 files changed, 617 insertions(+), 552 deletions(-)
create mode 100644 system/dirtylimit-hmp-cmds.c
create mode 100644 system/physmem-qmp-cmds.c
[PATCH v3 00/23] monitor: Reduce headers included in 'monitor/monitor.h'
Posted by Philippe Mathieu-Daudé 1 week, 6 days ago
Missing review: 2, 11, 17+

Since v2:
- Fixed net/vhost-vdpa (new patch)
- Use QOM-cast macros (bonus)

Since v1:
- extract QMP inject_nmi/memsave/pmemsave out of cpus.c
  (first 12 patches left unchanged).

Another HMP cleanup series to help Marc-André with his
'Make HMP optional' series [*].

We could also remove "exec/hwaddr.h" by moving gpa2hva()
declaration elsewhere, and "qapi/qapi-types-misc.h" by
moving monitor_fdset_add_fd() out to some "monitor/fdset.h"
header.

[*] 20260626-qemu-no-hmp-v2-0-8af31bc54c61@redhat.com
Based-on: <20260812121232.71958-1-philmd@oss.qualcomm.com>

Philippe Mathieu-Daudé (23):
  hexagon: Remove unnecessary 'monitor/monitor.h' header
  net/vhost-vdpa: Include missing 'qemu/iov.h' header
  tests/unit: Include 'qemu/main-loop.h' header in test-util-sockets.c
  qapi/qmp-dispatch: Include 'qemu/aio-wait.h' and 'monitor/monitor.h'
  qapi/qmp-registry: Remove unnecessary 'monitor/monitor.h' header
  migration/hmp-cmds: Include 'block/block-global-state.h' header
  monitor: Include missing 'qemu/aio-wait.h' header
  monitor: Include missing 'qemu/lockable.h' header
  monitor: Include missing 'qemu/coroutine-core.h' header
  monitor: Reduce inclusion of 'qapi/qapi-emit-events.h' header
  monitor: Remove unnecessary 'block/block.h' header
  system: Remove unnecessary 'monitor/monitor.h' header
  system/dirtylimit: Extract HMP code to dirtylimit-hmp-cmds.c
  system: Move qmp_inject_nmi() to hw/core/machine-qmp-cmds.c
  system: Extract QMP memsave/pmemsave commands to physmem-qmp-cmds.c
  system: Move runstate-related code from cpus.c to runstate.c
  monitor: Rename MonitorQMP @mon -> @qmon
  monitor: Rename MonitorHMP @mon -> @hmon
  monitor: Better express monitor_read()'s opaque arg is of Monitor type
  monitor: Use QOM MONITOR() macro to access MonitorQMP->parent_obj
  monitor: Use QOM MONITOR() macro to access MonitorHMP->parent_obj
  monitor: Replace container_of(MonitorHMP, parent_obj) -> MONITOR_HMP()
  monitor/hmp: Remove unnecessary 'monitor/monitor.h' header

 MAINTAINERS                      |   2 +
 include/hw/hexagon/hexagon_tlb.h |   2 +-
 include/monitor/hmp.h            |   1 -
 include/monitor/monitor.h        |   7 +-
 include/qapi/qmp-registry.h      |   1 -
 monitor/monitor-internal.h       |   7 +-
 target/hexagon/hex_mmu.h         |   3 +-
 hw/core/machine-qmp-cmds.c       |   6 +
 migration/migration-hmp-cmds.c   |   5 +-
 monitor/fds.c                    |   1 +
 monitor/hmp-cmds.c               |  10 +-
 monitor/hmp.c                    | 164 ++++++++++---------
 monitor/monitor.c                |   2 +
 monitor/qmp-cmds-control.c       |  18 +--
 monitor/qmp-cmds.c               |  13 +-
 monitor/qmp.c                    | 270 ++++++++++++++++---------------
 net/vhost-vdpa.c                 |   1 +
 qapi/qmp-dispatch.c              |   2 +
 system/cpus.c                    | 247 ----------------------------
 system/device_tree.c             |   1 -
 system/dirtylimit-hmp-cmds.c     |  74 +++++++++
 system/dirtylimit.c              |  60 -------
 system/physmem-qmp-cmds.c        | 107 ++++++++++++
 system/physmem.c                 |   2 -
 system/runstate.c                | 154 ++++++++++++++++++
 tests/unit/test-util-sockets.c   |   1 +
 ui/ui-hmp-cmds.c                 |   6 +-
 system/meson.build               |   2 +
 28 files changed, 617 insertions(+), 552 deletions(-)
 create mode 100644 system/dirtylimit-hmp-cmds.c
 create mode 100644 system/physmem-qmp-cmds.c

-- 
2.53.0