1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore

Stefan Hajnoczi posted 1 patch 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260811183144.190135-1-stefanha@redhat.com
Maintainers: Alexander Bulekov <alxndr@bu.edu>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Fabiano Rosas <farosas@suse.de>, Darren Kenny <darren.kenny@oracle.com>, Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>
tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Stefan Hajnoczi 2 weeks ago 
As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.

Use the latest x86 q35 machine instead, otherwise we get:

  $ qemu-system-x86_64 -M pc-q35-5.2
  qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
  Use -machine help to list supported machines

See commit a35f8577a07 ("include/hw: add macros for deprecation
& removal of versioned machines") and f59ee044067 ("include/hw/boards:
cope with dev/rc versions in deprecation checks") for explanation
on automatically removed versioned machines.

This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
<philmd@linaro.org>.

Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
index e37b48b2cc1..102a5ccb67e 100644
--- a/tests/qtest/fuzz-virtio-scsi-test.c
+++ b/tests/qtest/fuzz-virtio-scsi-test.c
@@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
 {
     QTestState *s;
 
-    s = qtest_init("-M pc-q35-5.2 -m 512M "
+    s = qtest_init("-M q35 -m 512M "
                    "-device virtio-scsi,num_queues=8,addr=03.0 ");
 
     qtest_outl(s, 0xcf8, 0x80001811);
-- 
2.55.0
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Thomas Huth 1 week, 6 days ago 
On 11/08/2026 20.31, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>    $ qemu-system-x86_64 -M pc-q35-5.2
>    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>    Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
> index e37b48b2cc1..102a5ccb67e 100644
> --- a/tests/qtest/fuzz-virtio-scsi-test.c
> +++ b/tests/qtest/fuzz-virtio-scsi-test.c
> @@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
>   {
>       QTestState *s;
>   
> -    s = qtest_init("-M pc-q35-5.2 -m 512M "
> +    s = qtest_init("-M q35 -m 512M "
>                      "-device virtio-scsi,num_queues=8,addr=03.0 ");
>   
>       qtest_outl(s, 0xcf8, 0x80001811);

I wonder whether we should rather remove the test completely instead? Those 
tests based on the fuzzers rely on a certain way of doing their MMIO - if a 
newer machine type has a slightly different MMIO layout, the test basically 
does not test anything useful anymore. WDYT?

  Thomas
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Stefan Hajnoczi 1 week, 6 days ago 
On Wed, Aug 12, 2026 at 4:35 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 11/08/2026 20.31, Stefan Hajnoczi wrote:
> > As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> >
> > Use the latest x86 q35 machine instead, otherwise we get:
> >
> >    $ qemu-system-x86_64 -M pc-q35-5.2
> >    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
> >    Use -machine help to list supported machines
> >
> > See commit a35f8577a07 ("include/hw: add macros for deprecation
> > & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> > cope with dev/rc versions in deprecation checks") for explanation
> > on automatically removed versioned machines.
> >
> > This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> > not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> > <philmd@linaro.org>.
> >
> > Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
> > index e37b48b2cc1..102a5ccb67e 100644
> > --- a/tests/qtest/fuzz-virtio-scsi-test.c
> > +++ b/tests/qtest/fuzz-virtio-scsi-test.c
> > @@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
> >   {
> >       QTestState *s;
> >
> > -    s = qtest_init("-M pc-q35-5.2 -m 512M "
> > +    s = qtest_init("-M q35 -m 512M "
> >                      "-device virtio-scsi,num_queues=8,addr=03.0 ");
> >
> >       qtest_outl(s, 0xcf8, 0x80001811);
>
> I wonder whether we should rather remove the test completely instead? Those
> tests based on the fuzzers rely on a certain way of doing their MMIO - if a
> newer machine type has a slightly different MMIO layout, the test basically
> does not test anything useful anymore. WDYT?

It is likely that these hardcoded MMIO registers will continue to work
because q35 won't change its PCI host controller or virtio-pci
register layout.

But if you feel strongly about removing it, feel free to go ahead. I'm
not 100% sure either.

Stefan
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Philippe Mathieu-Daudé 1 week, 6 days ago 
On 11/8/26 20:31, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>    $ qemu-system-x86_64 -M pc-q35-5.2
>    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>    Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Stefan Hajnoczi 2 weeks ago 
On Tue, Aug 11, 2026 at 02:31:44PM -0400, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my staging tree:
https://gitlab.com/stefanha/qemu/commits/staging

Stefan
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Daniel P. Berrangé 2 weeks ago 
On Tue, Aug 11, 2026 at 02:31:44PM -0400, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Posted by Peter Maydell 2 weeks ago 
On Tue, 11 Aug 2026 at 19:32, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
>
> Use the latest x86 q35 machine instead, otherwise we get:
>
>   $ qemu-system-x86_64 -M pc-q35-5.2
>   qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>   Use -machine help to list supported machines
>
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
>
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.