hw/nvme: add SPDM_SOCKET Kconfig dependency

[PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency

Posted by Stefan Hajnoczi 1 month, 2 weeks ago

The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
a Kconfig dependency to avoid build errors when NVME_PCI is enabled
without SPDM_SOCKET.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/nvme/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
index cfa2ab0f9d5..cfeeed64cd7 100644
--- a/hw/nvme/Kconfig
+++ b/hw/nvme/Kconfig
@@ -2,3 +2,4 @@ config NVME_PCI
     bool
     default y if PCI_DEVICES || PCIE_DEVICES
     depends on PCI
+    select SPDM_SOCKET
-- 
2.55.0

Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency

Posted by Klaus Jensen 1 month, 2 weeks ago

On Aug 10 17:48, Stefan Hajnoczi wrote:
> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
> without SPDM_SOCKET.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/nvme/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index cfa2ab0f9d5..cfeeed64cd7 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -2,3 +2,4 @@ config NVME_PCI
>      bool
>      default y if PCI_DEVICES || PCIE_DEVICES
>      depends on PCI
> +    select SPDM_SOCKET
> -- 
> 2.55.0
> 
> 

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>

Stefan, Philippe,

Do you want to grab this through trivial fixes tree or should I send a
pull?

Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 11/8/26 08:22, Klaus Jensen wrote:
> On Aug 10 17:48, Stefan Hajnoczi wrote:
>> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
>> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
>> without SPDM_SOCKET.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>   hw/nvme/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
>> index cfa2ab0f9d5..cfeeed64cd7 100644
>> --- a/hw/nvme/Kconfig
>> +++ b/hw/nvme/Kconfig
>> @@ -2,3 +2,4 @@ config NVME_PCI
>>       bool
>>       default y if PCI_DEVICES || PCIE_DEVICES
>>       depends on PCI
>> +    select SPDM_SOCKET
>> -- 
>> 2.55.0
>>
>>
> 
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> 
> Stefan, Philippe,
> 
> Do you want to grab this through trivial fixes tree or should I send a
> pull?

Sure, queued via hw-misc, thanks!

Re: [PATCH] hw/nvme: add SPDM_SOCKET Kconfig dependency

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 10/8/26 23:48, Stefan Hajnoczi wrote:
> The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add
> a Kconfig dependency to avoid build errors when NVME_PCI is enabled
> without SPDM_SOCKET.
> 

Fixes: 4f947b10d52 ("hw/nvme: Add SPDM over DOE support")

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   hw/nvme/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index cfa2ab0f9d5..cfeeed64cd7 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -2,3 +2,4 @@ config NVME_PCI
>       bool
>       default y if PCI_DEVICES || PCIE_DEVICES
>       depends on PCI
> +    select SPDM_SOCKET