[PATCH 0/4] hw/nmi: Safer vCPU delivery

Philippe Mathieu-Daudé posted 4 patches 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260810213723.58467-1-philmd@oss.qualcomm.com
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Corey Minyard <minyard@acm.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Nicholas Piggin <npiggin@gmail.com>, Aditya Gupta <adityag@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>
include/hw/core/nmi.h      | 10 +++++++++-
hw/core/nmi.c              | 25 ++++++++++++++++++++++---
hw/hppa/machine.c          |  4 ++--
hw/i386/x86.c              |  5 ++---
hw/intc/m68k_irqc.c        |  4 ++--
hw/ipmi/ipmi.c             |  2 +-
hw/m68k/q800-glue.c        |  4 ++--
hw/misc/macio/gpio.c       |  4 ++--
hw/ppc/pnv.c               |  7 +++----
hw/ppc/spapr.c             |  4 ++--
hw/s390x/s390-virtio-ccw.c |  6 ++----
hw/watchdog/watchdog.c     |  2 +-
12 files changed, 50 insertions(+), 27 deletions(-)
[PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
Hi Marc-André,

I don't remember what I suggested particularly for
20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
but this series is what I had in mind back then.

If you find it worthy, please consider including it
in your "Make HMP optional" work.

Regard,

Phil.

Philippe Mathieu-Daudé (4):
  hw/nmi: Allow delivering to first available vCPU (not by index)
  hw/nmi: Introduce nmi_cpu_handler() for vcpu-specific delivery
  hw/s390x: Deliver per-vcpu NMI using nmi_cpu_handler
  hw/nmi: Remove unused @cpu_index and @errp arguments

 include/hw/core/nmi.h      | 10 +++++++++-
 hw/core/nmi.c              | 25 ++++++++++++++++++++++---
 hw/hppa/machine.c          |  4 ++--
 hw/i386/x86.c              |  5 ++---
 hw/intc/m68k_irqc.c        |  4 ++--
 hw/ipmi/ipmi.c             |  2 +-
 hw/m68k/q800-glue.c        |  4 ++--
 hw/misc/macio/gpio.c       |  4 ++--
 hw/ppc/pnv.c               |  7 +++----
 hw/ppc/spapr.c             |  4 ++--
 hw/s390x/s390-virtio-ccw.c |  6 ++----
 hw/watchdog/watchdog.c     |  2 +-
 12 files changed, 50 insertions(+), 27 deletions(-)

-- 
2.53.0


Re: [PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 10/8/26 23:37, Philippe Mathieu-Daudé wrote:
> Hi Marc-André,
> 
> I don't remember what I suggested particularly for
> 20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
> but this series is what I had in mind back then.
> 
> If you find it worthy, please consider including it
> in your "Make HMP optional" work.

Not well explained, this series disentangle HMP from
the generic NMI class.

> 
> Regard,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (4):
>    hw/nmi: Allow delivering to first available vCPU (not by index)
>    hw/nmi: Introduce nmi_cpu_handler() for vcpu-specific delivery
>    hw/s390x: Deliver per-vcpu NMI using nmi_cpu_handler
>    hw/nmi: Remove unused @cpu_index and @errp arguments
> 
>   include/hw/core/nmi.h      | 10 +++++++++-
>   hw/core/nmi.c              | 25 ++++++++++++++++++++++---
>   hw/hppa/machine.c          |  4 ++--
>   hw/i386/x86.c              |  5 ++---
>   hw/intc/m68k_irqc.c        |  4 ++--
>   hw/ipmi/ipmi.c             |  2 +-
>   hw/m68k/q800-glue.c        |  4 ++--
>   hw/misc/macio/gpio.c       |  4 ++--
>   hw/ppc/pnv.c               |  7 +++----
>   hw/ppc/spapr.c             |  4 ++--
>   hw/s390x/s390-virtio-ccw.c |  6 ++----
>   hw/watchdog/watchdog.c     |  2 +-
>   12 files changed, 50 insertions(+), 27 deletions(-)
> 


Re: [PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 11/8/26 10:44, Philippe Mathieu-Daudé wrote:
> On 10/8/26 23:37, Philippe Mathieu-Daudé wrote:
>> Hi Marc-André,
>>
>> I don't remember what I suggested particularly for
>> 20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
>> but this series is what I had in mind back then.
>>
>> If you find it worthy, please consider including it
>> in your "Make HMP optional" work.
> 
> Not well explained, this series disentangle HMP from
> the generic NMI class.

Oh no, one patch is missing!

> 
>>
>> Regard,
>>
>> Phil.
>>
>> Philippe Mathieu-Daudé (4):
>>    hw/nmi: Allow delivering to first available vCPU (not by index)
>>    hw/nmi: Introduce nmi_cpu_handler() for vcpu-specific delivery
>>    hw/s390x: Deliver per-vcpu NMI using nmi_cpu_handler
>>    hw/nmi: Remove unused @cpu_index and @errp arguments
>>
>>   include/hw/core/nmi.h      | 10 +++++++++-
>>   hw/core/nmi.c              | 25 ++++++++++++++++++++++---
>>   hw/hppa/machine.c          |  4 ++--
>>   hw/i386/x86.c              |  5 ++---
>>   hw/intc/m68k_irqc.c        |  4 ++--
>>   hw/ipmi/ipmi.c             |  2 +-
>>   hw/m68k/q800-glue.c        |  4 ++--
>>   hw/misc/macio/gpio.c       |  4 ++--
>>   hw/ppc/pnv.c               |  7 +++----
>>   hw/ppc/spapr.c             |  4 ++--
>>   hw/s390x/s390-virtio-ccw.c |  6 ++----
>>   hw/watchdog/watchdog.c     |  2 +-
>>   12 files changed, 50 insertions(+), 27 deletions(-)
>>
> 
> 


Re: [PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 11/8/26 10:50, Philippe Mathieu-Daudé wrote:
> On 11/8/26 10:44, Philippe Mathieu-Daudé wrote:
>> On 10/8/26 23:37, Philippe Mathieu-Daudé wrote:
>>> Hi Marc-André,
>>>
>>> I don't remember what I suggested particularly for
>>> 20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
>>> but this series is what I had in mind back then.
>>>
>>> If you find it worthy, please consider including it
>>> in your "Make HMP optional" work.
>>
>> Not well explained, this series disentangle HMP from
>> the generic NMI class.

Actually previous version is better:
https://lore.kernel.org/qemu-devel/20240220150833.13674-1-philmd@linaro.org/

> 
> Oh no, one patch is missing!
> 
>>
>>>
>>> Regard,
>>>
>>> Phil.
>>>
>>> Philippe Mathieu-Daudé (4):
>>>    hw/nmi: Allow delivering to first available vCPU (not by index)
>>>    hw/nmi: Introduce nmi_cpu_handler() for vcpu-specific delivery
>>>    hw/s390x: Deliver per-vcpu NMI using nmi_cpu_handler
>>>    hw/nmi: Remove unused @cpu_index and @errp arguments
>>>
>>>   include/hw/core/nmi.h      | 10 +++++++++-
>>>   hw/core/nmi.c              | 25 ++++++++++++++++++++++---
>>>   hw/hppa/machine.c          |  4 ++--
>>>   hw/i386/x86.c              |  5 ++---
>>>   hw/intc/m68k_irqc.c        |  4 ++--
>>>   hw/ipmi/ipmi.c             |  2 +-
>>>   hw/m68k/q800-glue.c        |  4 ++--
>>>   hw/misc/macio/gpio.c       |  4 ++--
>>>   hw/ppc/pnv.c               |  7 +++----
>>>   hw/ppc/spapr.c             |  4 ++--
>>>   hw/s390x/s390-virtio-ccw.c |  6 ++----
>>>   hw/watchdog/watchdog.c     |  2 +-
>>>   12 files changed, 50 insertions(+), 27 deletions(-)
>>>
>>
>>
> 
> 


Re: [PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Daniel P. Berrangé 1 month, 2 weeks ago
On Tue, Aug 11, 2026 at 11:36:59AM +0200, Philippe Mathieu-Daudé wrote:
> On 11/8/26 10:50, Philippe Mathieu-Daudé wrote:
> > On 11/8/26 10:44, Philippe Mathieu-Daudé wrote:
> > > On 10/8/26 23:37, Philippe Mathieu-Daudé wrote:
> > > > Hi Marc-André,
> > > > 
> > > > I don't remember what I suggested particularly for
> > > > 20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
> > > > but this series is what I had in mind back then.
> > > > 
> > > > If you find it worthy, please consider including it
> > > > in your "Make HMP optional" work.
> > > 
> > > Not well explained, this series disentangle HMP from
> > > the generic NMI class.
> 
> Actually previous version is better:
> https://lore.kernel.org/qemu-devel/20240220150833.13674-1-philmd@linaro.org/

Are you going to rebase & resend that ?   The old thread has a lot
of commentary that I don't think it is worth reviewing the old code
again until updated.


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|


Re: [PATCH 0/4] hw/nmi: Safer vCPU delivery
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 11/8/26 11:49, Daniel P. Berrangé wrote:
> On Tue, Aug 11, 2026 at 11:36:59AM +0200, Philippe Mathieu-Daudé wrote:
>> On 11/8/26 10:50, Philippe Mathieu-Daudé wrote:
>>> On 11/8/26 10:44, Philippe Mathieu-Daudé wrote:
>>>> On 10/8/26 23:37, Philippe Mathieu-Daudé wrote:
>>>>> Hi Marc-André,
>>>>>
>>>>> I don't remember what I suggested particularly for
>>>>> 20260626-qemu-no-hmp-v2-7-8af31bc54c61@redhat.com,
>>>>> but this series is what I had in mind back then.
>>>>>
>>>>> If you find it worthy, please consider including it
>>>>> in your "Make HMP optional" work.
>>>>
>>>> Not well explained, this series disentangle HMP from
>>>> the generic NMI class.
>>
>> Actually previous version is better:
>> https://lore.kernel.org/qemu-devel/20240220150833.13674-1-philmd@linaro.org/
> 
> Are you going to rebase & resend that ?   The old thread has a lot
> of commentary that I don't think it is worth reviewing the old code
> again until updated.

Please discard this series.

Old series rebased and reposted (addressing comments) as v3 here:
https://lore.kernel.org/qemu-devel/20260811105425.7429-1-philmd@oss.qualcomm.com/