[PULL v2 0/7] IDE patches

Denis V. Lunev posted 7 patches 1 week, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260804170015.3128363-1-den@openvz.org
Maintainers: John Snow <jsnow@redhat.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
hw/ide/atapi.c            | 180 +++++++++++++++-----------------
tests/qtest/ahci-test.c   | 134 ++++++++++++++++++++++++
tests/qtest/ide-test.c    | 211 ++++++++++++++++++++++++--------------
tests/qtest/libqos/ahci.c |   5 +
tests/qtest/libqos/ahci.h |   2 +
5 files changed, 360 insertions(+), 172 deletions(-)
[PULL v2 0/7] IDE patches
Posted by Denis V. Lunev 1 week, 6 days ago
The following changes since commit e1705a25aff35635c360bbaba4c2731d019a422a:

  Update version for v11.1.0-rc2 release (2026-07-29 06:16:08 -0400)

are available in the Git repository at:

  https://gitlab.com/dlunev/qemu tags/pull-ide-2026-08-04

for you to fetch changes up to 9a249de6ae86124b436b5e839e285aeb333ea8c0:

  tests/qtest/ahci: regression test for ATAPI read vs. drain (2026-08-04 18:40:34 +0200)

----------------------------------------------------------------
IDE patches

- fix a main-loop deadlock when an ATAPI PIO read spanning several
  sectors is in flight while a drain starts: the nested sector fetch
  was issued synchronously from inside the completion of the first
  read and queued behind the drain, which then never finished
- read the whole ATAPI elementary transfer in one asynchronous
  request instead, removing cd_read_sector_sync()
- extend the IDE/AHCI qtest coverage of ATAPI CD reads: parametrized
  read helper, multi-sector DMA, raw 2352-byte READ CD on both
  delivery paths, and a regression test for the deadlock above

Changes since v1:
- MAINTAINERS patch dropped
- spare blank line no longer added and removed within the series

NOTE: 'hw/ide: Don't divide by zero if guest specifies 0 sectors requires'
is not ready for me, skipped from this submission.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

----------------------------------------------------------------
Denis V. Lunev (7):
      tests/qtest/ide-test: parametrize the ATAPI CD-ROM read test
      tests/qtest/ide-test: add a multi-sector ATAPI DMA read test
      tests/qtest/ide-test: cover raw (2352-byte) ATAPI CD reads
      tests/qtest/libqos/ahci: support raw (2352-byte) READ CD
      tests/qtest/ahci: cover raw (2352-byte) ATAPI CD reads
      hw/ide/atapi: read the whole elementary transfer asynchronously
      tests/qtest/ahci: regression test for ATAPI read vs. drain

 hw/ide/atapi.c            | 180 +++++++++++++++-----------------
 tests/qtest/ahci-test.c   | 134 ++++++++++++++++++++++++
 tests/qtest/ide-test.c    | 211 ++++++++++++++++++++++++--------------
 tests/qtest/libqos/ahci.c |   5 +
 tests/qtest/libqos/ahci.h |   2 +
 5 files changed, 360 insertions(+), 172 deletions(-)

--
2.53.0


Re: [PULL v2 0/7] IDE patches
Posted by Richard Henderson 5 days, 10 hours ago
On 8/4/26 10:00, Denis V. Lunev wrote:
> The following changes since commit e1705a25aff35635c360bbaba4c2731d019a422a:
> 
>    Update version for v11.1.0-rc2 release (2026-07-29 06:16:08 -0400)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/dlunev/qemu tags/pull-ide-2026-08-04
> 
> for you to fetch changes up to 9a249de6ae86124b436b5e839e285aeb333ea8c0:
> 
>    tests/qtest/ahci: regression test for ATAPI read vs. drain (2026-08-04 18:40:34 +0200)

fatal: couldn't find remote ref tags/pull-ide-2026-08-04
fatal: remote error: upload-pack: not our ref 9a249de6ae86124b436b5e839e285aeb333ea8c0

Did you remove the tag?  In any case, please resend.


r~
Re: [PULL v2 0/7] IDE patches
Posted by Denis V. Lunev 4 days, 7 hours ago
On 8/12/26 18:19, Richard Henderson wrote:
> This email originated from an IP that might not be authorized by the domain it was sent from.
> Do not click links or open attachments unless it is an email you expected to receive.
> On 8/4/26 10:00, Denis V. Lunev wrote:
>> The following changes since commit e1705a25aff35635c360bbaba4c2731d019a422a:
>>
>>    Update version for v11.1.0-rc2 release (2026-07-29 06:16:08 -0400)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/dlunev/qemu tags/pull-ide-2026-08-04
>>
>> for you to fetch changes up to 9a249de6ae86124b436b5e839e285aeb333ea8c0:
>>
>>    tests/qtest/ahci: regression test for ATAPI read vs. drain (2026-08-04 18:40:34 +0200)
> fatal: couldn't find remote ref tags/pull-ide-2026-08-04
> fatal: remote error: upload-pack: not our ref 9a249de6ae86124b436b5e839e285aeb333ea8c0
>
> Did you remove the tag?  In any case, please resend.
>
>
> r~
Sorry, seems I have mistaken on this pull request.

Re-sent.

Thank you in advance,
    Den

Re: [PULL v2 0/7] IDE patches
Posted by Stefan Hajnoczi 1 week, 6 days ago
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.
Re: [PULL v2 0/7] IDE patches
Posted by Denis V. Lunev 5 days, 13 hours ago
On 8/5/26 02:55, Stefan Hajnoczi wrote:
> Applied, thanks.
>
> Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.
Hi, Stefan!

It is kinda strange but I do not see this series neither
in master, no in staging today.

The head for me is

commit e8d693e12af9cbb89d724baadfcc08559669e279 (upstream/staging,
upstream/master, upstream/HEAD)
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Aug 11 14:31:44 2026 -0400

I see only this patch merged:

athena ~/src/qemu $ git log --author openvz.org hw/ide/
commit d9f78431d8ebdc2d03ad74461138c1c9eb076aa5
Author: Denis V. Lunev <den@openvz.org>
Date:   Fri Jun 19 13:21:49 2026 +0200

    hw/ide/ahci: cancel in-flight buffered reads on command engine restart

Does something missed/goes wrong?

Thank you in advance,
    Den

Re: [PULL v2 0/7] IDE patches
Posted by Stefan Hajnoczi 5 days, 12 hours ago
On Wed, Aug 12, 2026 at 02:48:45PM +0200, Denis V. Lunev wrote:
> On 8/5/26 02:55, Stefan Hajnoczi wrote:
> > Applied, thanks.
> >
> > Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.
> Hi, Stefan!
> 
> It is kinda strange but I do not see this series neither
> in master, no in staging today.
> 
> The head for me is
> 
> commit e8d693e12af9cbb89d724baadfcc08559669e279 (upstream/staging,
> upstream/master, upstream/HEAD)
> Author: Stefan Hajnoczi <stefanha@redhat.com>
> Date:   Tue Aug 11 14:31:44 2026 -0400
> 
> I see only this patch merged:
> 
> athena ~/src/qemu $ git log --author openvz.org hw/ide/
> commit d9f78431d8ebdc2d03ad74461138c1c9eb076aa5
> Author: Denis V. Lunev <den@openvz.org>
> Date:   Fri Jun 19 13:21:49 2026 +0200
> 
>     hw/ide/ahci: cancel in-flight buffered reads on command engine restart
> 
> Does something missed/goes wrong?

I see the same thing. Sorry, I must have messed up when building the
staging tree and dropped your series.

Richard Henderson is handling qemu.git pull requests for the 11.2
release and I've asked him to merge your series.

Stefan
Re: [PULL v2 0/7] IDE patches
Posted by Denis V. Lunev 5 days, 11 hours ago
On 8/12/26 16:32, Stefan Hajnoczi wrote:
> On Wed, Aug 12, 2026 at 02:48:45PM +0200, Denis V. Lunev wrote:
>> On 8/5/26 02:55, Stefan Hajnoczi wrote:
>>> Applied, thanks.
>>>
>>> Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.
>> Hi, Stefan!
>>
>> It is kinda strange but I do not see this series neither
>> in master, no in staging today.
>>
>> The head for me is
>>
>> commit e8d693e12af9cbb89d724baadfcc08559669e279 (upstream/staging,
>> upstream/master, upstream/HEAD)
>> Author: Stefan Hajnoczi <stefanha@redhat.com>
>> Date:   Tue Aug 11 14:31:44 2026 -0400
>>
>> I see only this patch merged:
>>
>> athena ~/src/qemu $ git log --author openvz.org hw/ide/
>> commit d9f78431d8ebdc2d03ad74461138c1c9eb076aa5
>> Author: Denis V. Lunev <den@openvz.org>
>> Date:   Fri Jun 19 13:21:49 2026 +0200
>>
>>     hw/ide/ahci: cancel in-flight buffered reads on command engine restart
>>
>> Does something missed/goes wrong?
> I see the same thing. Sorry, I must have messed up when building the
> staging tree and dropped your series.
>
> Richard Henderson is handling qemu.git pull requests for the 11.2
> release and I've asked him to merge your series.
>
> Stefan
Thanks a lot!

Den